This is an archive of the discontinued LLVM Phabricator instance.

[x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage
ClosedPublic

Authored by mharoush on Sep 28 2016, 2:49 AM.

Download Raw Diff

Details

Reviewers

myatsina
delena
echristo
rnk
m_zuckerman

Commits

rG4fe34fa2ecbf: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage
rC285555: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage
rL285555: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage

Summary

This patch enables usage of k registers in inline assembly syntax.

Diff Detail

Repository: rL LLVM

Event Timeline

mharoush updated this revision to Diff 72787.Sep 28 2016, 2:49 AM

mharoush retitled this revision from to [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage.

mharoush updated this object.

mharoush added reviewers: delena, myatsina, rnk, echristo.

mharoush set the repository for this revision to rL LLVM.

mharoush added a subscriber: cfe-commits.

Herald added a subscriber: mehdi_amini. · View Herald TranscriptSep 28 2016, 2:49 AM

I'm pretty sure GCCRegNames is used to parse constraint lists, not to parse inline asm text. Your test should try using kN as a constraint.

This patch is a part of a larger support for k constraints, its main purpose is to add the option to choose the specific kN register while using basic inline assembly, the constraint support for extended inline assembly is being supported by another patch D25062 D25063

mharoush added a reviewer: m_zuckerman.Oct 5 2016, 2:03 AM

mharoush added a child revision: D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..Oct 5 2016, 4:47 AM

mharoush added a child revision: D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..

ping

delena accepted this revision.Oct 30 2016, 5:52 AM

delena edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2016, 5:52 AM

Closed by commit rL285555: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage (authored by mzuckerm). · Explain WhyOct 31 2016, 2:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

cfe/

trunk/

lib/

Basic/

Targets.cpp

1 line

test/

CodeGen/

avx512-inline-asm-kregisters-basics.c

17 lines

Diff 76370

cfe/trunk/lib/Basic/Targets.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 2,391 Lines • ▼ Show 20 Lines	static const char* const GCCRegNames[] = {
"xmm16", "xmm17", "xmm18", "xmm19", "xmm20", "xmm21", "xmm22", "xmm23",		"xmm16", "xmm17", "xmm18", "xmm19", "xmm20", "xmm21", "xmm22", "xmm23",
"xmm24", "xmm25", "xmm26", "xmm27", "xmm28", "xmm29", "xmm30", "xmm31",		"xmm24", "xmm25", "xmm26", "xmm27", "xmm28", "xmm29", "xmm30", "xmm31",
"ymm16", "ymm17", "ymm18", "ymm19", "ymm20", "ymm21", "ymm22", "ymm23",		"ymm16", "ymm17", "ymm18", "ymm19", "ymm20", "ymm21", "ymm22", "ymm23",
"ymm24", "ymm25", "ymm26", "ymm27", "ymm28", "ymm29", "ymm30", "ymm31",		"ymm24", "ymm25", "ymm26", "ymm27", "ymm28", "ymm29", "ymm30", "ymm31",
"zmm0", "zmm1", "zmm2", "zmm3", "zmm4", "zmm5", "zmm6", "zmm7",		"zmm0", "zmm1", "zmm2", "zmm3", "zmm4", "zmm5", "zmm6", "zmm7",
"zmm8", "zmm9", "zmm10", "zmm11", "zmm12", "zmm13", "zmm14", "zmm15",		"zmm8", "zmm9", "zmm10", "zmm11", "zmm12", "zmm13", "zmm14", "zmm15",
"zmm16", "zmm17", "zmm18", "zmm19", "zmm20", "zmm21", "zmm22", "zmm23",		"zmm16", "zmm17", "zmm18", "zmm19", "zmm20", "zmm21", "zmm22", "zmm23",
"zmm24", "zmm25", "zmm26", "zmm27", "zmm28", "zmm29", "zmm30", "zmm31",		"zmm24", "zmm25", "zmm26", "zmm27", "zmm28", "zmm29", "zmm30", "zmm31",
		"k0", "k1", "k2", "k3", "k4", "k5", "k6", "k7",
};		};

const TargetInfo::AddlRegName AddlRegNames[] = {		const TargetInfo::AddlRegName AddlRegNames[] = {
{ { "al", "ah", "eax", "rax" }, 0 },		{ { "al", "ah", "eax", "rax" }, 0 },
{ { "bl", "bh", "ebx", "rbx" }, 3 },		{ { "bl", "bh", "ebx", "rbx" }, 3 },
{ { "cl", "ch", "ecx", "rcx" }, 2 },		{ { "cl", "ch", "ecx", "rcx" }, 2 },
{ { "dl", "dh", "edx", "rdx" }, 1 },		{ { "dl", "dh", "edx", "rdx" }, 1 },
{ { "esi", "rsi" }, 4 },		{ { "esi", "rsi" }, 4 },
▲ Show 20 Lines • Show All 6,373 Lines • Show Last 20 Lines

cfe/trunk/test/CodeGen/avx512-inline-asm-kregisters-basics.c

				// RUN: %clang_cc1 %s -target-cpu skylake-avx512 -O0 -S -o - -Wall -Werror \| FileCheck %s
				// This test checks basic inline assembly recognition of k0-k7 registers for avx512.

				void test_basic_inline_asm_with_k_regs() {
				//CHECK: #APP
				//CHECK: kandw %k1, %k2, %k3
				//CHECK: #NO_APP
				asm("kandw %k1, %k2, %k3\t");
				//CHECK: #APP
				//CHECK: kandw %k4, %k5, %k6
				//CHECK: #NO_APP
				asm("kandw %k4, %k5, %k6\t");
				//CHECK: #APP
				//CHECK: kandw %k7, %k0, %k1
				//CHECK: #NO_APP
				asm("kandw %k7, %k0, %k1\t");
				}
				No newline at end of file