Page MenuHomePhabricator

mharoush (Matan)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2016, 9:16 AM (240 w, 2 d)

Recent Activity

Jul 25 2017

mharoush committed rL308966: This patch enables the usage of constant Enum identifiers within Microsoft….
This patch enables the usage of constant Enum identifiers within Microsoft…
Jul 25 2017, 3:45 AM
mharoush committed rL308965: This patch enables the usage of constant Enum identifiers within Microsoft….
This patch enables the usage of constant Enum identifiers within Microsoft…
Jul 25 2017, 3:45 AM
mharoush closed D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax by committing rL308965: This patch enables the usage of constant Enum identifiers within Microsoft….
Jul 25 2017, 3:45 AM · Restricted Project
mharoush added a comment to D35204: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.

ping

Jul 25 2017, 2:51 AM

Jul 16 2017

mharoush updated the diff for D35204: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.

Cosmetics + ping

Jul 16 2017, 7:12 AM
mharoush updated the diff for D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.

Cosmetics + ping

Jul 16 2017, 7:02 AM

Jul 10 2017

mharoush updated the summary of D35204: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.
Jul 10 2017, 8:59 AM
mharoush added reviewers for D35205: [Clang][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints: coby, rnk.
Jul 10 2017, 8:58 AM
mharoush created D35205: [Clang][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.
Jul 10 2017, 8:57 AM
mharoush created D35204: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.
Jul 10 2017, 8:53 AM

Jul 5 2017

mharoush added a comment to D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.

ping

Jul 5 2017, 11:46 PM · Restricted Project
mharoush added a comment to D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.

ping

Jul 5 2017, 11:45 PM

Jun 28 2017

mharoush added inline comments to D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.
Jun 28 2017, 6:00 AM
mharoush updated the diff for D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.

simplified the rewrite condition of complex expressions and eliminated the need to use the ReplaceEnumIdentifier flag. This requires making small adjustments to some of the older test cases seen in [D33277]. Made some minor alterations and clarifications to satisfy reviewer comments.

Jun 28 2017, 5:59 AM
mharoush updated the diff for D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.

Updated inline asm tests to look for decimal immediate value instead of looking for the original string e.g. 10 vs 0xA and other variations.
Also updated the test cases to use check-same etc.

Jun 28 2017, 5:53 AM · Restricted Project

Jun 26 2017

mharoush added a reviewer for D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax: echristo.
Jun 26 2017, 12:36 AM · Restricted Project

Jun 19 2017

mharoush added a comment to D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.

ping

Jun 19 2017, 6:48 AM

Jun 12 2017

mharoush added a comment to D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.

ping

Jun 12 2017, 4:23 AM
mharoush updated the diff for D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.

Restored old test case for constant int folding and added check-label directives for each tester function.

Jun 12 2017, 4:21 AM · Restricted Project

Jun 7 2017

mharoush updated the diff for D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.

added struct case to the test

Jun 7 2017, 4:41 AM · Restricted Project
mharoush updated the diff for D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.
Jun 7 2017, 4:18 AM · Restricted Project
mharoush added inline comments to D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.
Jun 7 2017, 4:15 AM
mharoush updated the diff for D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.

Simplified the AsmRewrite condition in x86AsmParser. Some fixes to simplify the Intel State Machine immediate value rewrite treatment divergence.

Jun 7 2017, 4:11 AM

May 22 2017

mharoush added inline comments to D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.
May 22 2017, 9:28 AM · Restricted Project
mharoush updated the diff for D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.

removed functions and dropped an irrelevant test case.

May 22 2017, 9:23 AM · Restricted Project
mharoush added inline comments to D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.
May 22 2017, 9:15 AM
mharoush updated the diff for D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.

Using identifier info to pass enum information.

May 22 2017, 9:15 AM

May 17 2017

mharoush updated the summary of D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.
May 17 2017, 7:28 AM · Restricted Project
mharoush created D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.
May 17 2017, 7:27 AM
mharoush created D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax.
May 17 2017, 7:24 AM · Restricted Project

Oct 23 2016

mharoush added inline comments to D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..
Oct 23 2016, 12:41 AM
mharoush updated the diff for D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..

Only test affected(correct version this time: checking LLVM IR instead of x86 asm),
This test depends on D25012 being applied.

Oct 23 2016, 12:40 AM

Oct 20 2016

mharoush added a comment to D25011: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage.

ping

Oct 20 2016, 3:24 AM
mharoush updated the diff for D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..

Added LLVM_FALLTHROUGH

Oct 20 2016, 3:22 AM
mharoush updated the diff for D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..

I renamed the test file to be more informative, added LLVM_FALLTHROUGH, removed check of {z} and changed the test to check LLVM IR.

Oct 20 2016, 3:20 AM
mharoush added a comment to D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm..

ping

Oct 20 2016, 2:18 AM

Oct 18 2016

mharoush updated the diff for D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..

Added default case, minor ws style.

Oct 18 2016, 7:57 AM
mharoush updated the diff for D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..

fixed Reids comments

Oct 18 2016, 6:06 AM

Oct 5 2016

mharoush added a reviewer for D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.: rnk.
Oct 5 2016, 4:51 AM
mharoush added a reviewer for D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.: rnk.
Oct 5 2016, 4:51 AM
mharoush added a reviewer for D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.: m_zuckerman.
Oct 5 2016, 2:04 AM
mharoush added a reviewer for D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.: m_zuckerman.
Oct 5 2016, 2:04 AM
mharoush added a reviewer for D25011: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage: m_zuckerman.
Oct 5 2016, 2:03 AM
mharoush added a reviewer for D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm.: m_zuckerman.
Oct 5 2016, 1:59 AM
mharoush added a comment to D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm..

Done

Oct 5 2016, 1:41 AM
mharoush updated the diff for D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm..
Oct 5 2016, 1:40 AM
mharoush added a comment to D25011: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage.

This patch is a part of a larger support for k constraints, its main purpose is to add the option to choose the specific kN register while using basic inline assembly, the constraint support for extended inline assembly is being supported by another patch D25062 D25063

Oct 5 2016, 1:19 AM

Sep 29 2016

mharoush added a reviewer for D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.: echristo.
Sep 29 2016, 1:29 AM
mharoush added a reviewer for D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.: echristo.
Sep 29 2016, 1:28 AM
mharoush retitled D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions. from [x86][inline-asm][AVX512] [x86][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions to [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..
Sep 29 2016, 1:05 AM
mharoush updated D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..
Sep 29 2016, 1:05 AM
mharoush retitled D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions. from [x86][inliine-asm][AVX512][clang] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions to [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions..
Sep 29 2016, 1:01 AM
mharoush retitled D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions. from [x86][inline-asm][AVX512] [x86][inliine-asm][AVX512][llvm] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions to [x86][inline-asm][AVX512] [x86][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.
Sep 29 2016, 1:00 AM
mharoush retitled D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions. from to [x86][inliine-asm][AVX512][clang] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.
Sep 29 2016, 12:52 AM
mharoush retitled D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions. from to [x86][inline-asm][AVX512] [x86][inliine-asm][AVX512][llvm] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.
Sep 29 2016, 12:50 AM

Sep 28 2016

mharoush retitled D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm. from to [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm..
Sep 28 2016, 2:52 AM
mharoush retitled D25011: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage from to [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage.
Sep 28 2016, 2:49 AM