User Details
User Details
- User Since
- Jun 17 2015, 1:09 AM (432 w, 5 d)
Jun 2 2020
Jun 2 2020
m_zuckerman added a reviewer for D57504: RFC: Prototype & Roadmap for vector predication in LLVM: m_zuckerman.
Dec 18 2017
Dec 18 2017
Dec 17 2017
Dec 17 2017
m_zuckerman updated the diff for D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
SORRY
m_zuckerman added inline comments to D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
m_zuckerman added inline comments to D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
Dec 14 2017
Dec 14 2017
m_zuckerman added a comment to D40287: [X86][AVX][AVX2]: Adding full coverage of MC encoding for the AVX, AVX2 isa set.<NFC>.
LGTM, if no one has something to add
Dec 13 2017
Dec 13 2017
m_zuckerman updated the diff for D39547: [AVX512] Adding support for load truncate store of I1.
m_zuckerman updated the diff for D39547: [AVX512] Adding support for load truncate store of I1.
Dec 12 2017
Dec 12 2017
m_zuckerman added a comment to D34141: [X86] Recognize constant arrays with special values and replace loads from it with subtract and shift instructions, which then will be replaced by X86 BZHI machine instruction..
LGTM with no one has nothing to add !!!
Nov 26 2017
Nov 26 2017
m_zuckerman updated the summary of D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
Nov 2 2017
Nov 2 2017
m_zuckerman updated the diff for D39547: [AVX512] Adding support for load truncate store of I1.
m_zuckerman updated the diff for D39547: [AVX512] Adding support for load truncate store of I1.
m_zuckerman updated the diff for D39547: [AVX512] Adding support for load truncate store of I1.
Oct 30 2017
Oct 30 2017
m_zuckerman added inline comments to D38312: adding pattern for broadcastm.
m_zuckerman added inline comments to D38312: adding pattern for broadcastm.
Oct 29 2017
Oct 29 2017
m_zuckerman added a comment to D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1 .
m_zuckerman updated the diff for D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1 .
Oct 27 2017
Oct 27 2017
m_zuckerman added inline comments to D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1 .
m_zuckerman updated the diff for D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1 .
m_zuckerman updated the diff for D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1 .
Oct 26 2017
Oct 26 2017
m_zuckerman updated the diff for D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1 .
Oct 25 2017
Oct 25 2017
m_zuckerman updated the summary of D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1 .
m_zuckerman added reviewers for D39292: [X86][AVX512] Adding new patterns for extract_subvector of vXi1 : guyblank, igorb, zvi, ayman, craig.topper.
Oct 24 2017
Oct 24 2017
m_zuckerman added inline comments to D38312: adding pattern for broadcastm.
Oct 17 2017
Oct 17 2017
Oct 16 2017
Oct 16 2017
m_zuckerman added inline comments to D38762: Cost calculation for interleave load/store patterns {v8i8,v16i8,v32i8,v64i8}.
Oct 15 2017
Oct 15 2017
Oct 14 2017
Oct 14 2017
m_zuckerman added inline comments to D38762: Cost calculation for interleave load/store patterns {v8i8,v16i8,v32i8,v64i8}.
Oct 10 2017
Oct 10 2017
m_zuckerman added inline comments to D38037: [InstCombine] Compacting or instructions whose operands are shift instructions.
Oct 9 2017
Oct 9 2017
m_zuckerman added a comment to D38689: [X86] Fix a bug with i386 subtarget in LowerCONCAT_VECTORSvXi1 func.
LGTM
after LLVM-SIDE
m_zuckerman added a comment to D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part.
Please add dependent parent.
LGTM After the parent commit (LLVM side).
Oct 7 2017
Oct 7 2017
Sep 29 2017
Sep 29 2017
Sep 28 2017
Sep 28 2017
Sep 26 2017
Sep 26 2017
Sep 25 2017
Sep 25 2017
LGTM THANKS ,
m_zuckerman added inline comments to D38220: [X86] Finishing broadcast[f|i]32x2 intrinsics lowering to IR..
Sep 21 2017
Sep 21 2017
Sep 14 2017
Sep 14 2017
Sep 11 2017
Sep 11 2017
m_zuckerman retitled D37687: [X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess (VF64 stride 3) from [X86][LLVM]Expanding Supports lowerInterleaved{store|load}}() in X86InterleavedAccess (VF64 stride 3) to [X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess (VF64 stride 3) .
m_zuckerman retitled D37687: [X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess (VF64 stride 3) from [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF64 stride 3) to [X86][LLVM]Expanding Supports lowerInterleaved{store|load}}() in X86InterleavedAccess (VF64 stride 3) .
Sep 10 2017
Sep 10 2017
Sep 7 2017
Sep 7 2017
m_zuckerman closed D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
commit to https://reviews.llvm.org/rL312722
Sep 6 2017
Sep 6 2017
Sep 5 2017
Sep 5 2017
Sep 4 2017
Sep 4 2017
m_zuckerman updated the diff for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Update according to Zvi comments
Sep 3 2017
Sep 3 2017
Aug 30 2017
Aug 30 2017
Aug 29 2017
Aug 29 2017
Aug 28 2017
Aug 28 2017
m_zuckerman added a comment to D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Ping
Aug 24 2017
Aug 24 2017
Aug 22 2017
Aug 22 2017
Aug 21 2017
Aug 21 2017
Aug 10 2017
Aug 10 2017
m_zuckerman accepted D36570: [X86][AsmParser][AVX512] Error appropriately when K0 is tried as a write-mask.
It sounds reasonable
LGTM
m_zuckerman added inline comments to D36570: [X86][AsmParser][AVX512] Error appropriately when K0 is tried as a write-mask.
Aug 8 2017
Aug 8 2017
Aug 7 2017
Aug 7 2017
Aug 1 2017
Aug 1 2017