m_zuckerman (michael zuckerman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 1:09 AM (118 w, 4 d)

Recent Activity

Thu, Sep 21

m_zuckerman updated the diff for D37117: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF{8|16|32} stride 3)...
Thu, Sep 21, 3:09 AM
m_zuckerman updated the diff for D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Thu, Sep 21, 2:17 AM

Thu, Sep 14

m_zuckerman updated the diff for D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Thu, Sep 14, 1:58 AM

Mon, Sep 11

m_zuckerman updated the diff for D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Mon, Sep 11, 2:55 PM
m_zuckerman retitled D37687: [X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess (VF64 stride 3) from [X86][LLVM]Expanding Supports lowerInterleaved{store|load}}() in X86InterleavedAccess (VF64 stride 3) to [X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess (VF64 stride 3) .
Mon, Sep 11, 7:13 AM
m_zuckerman retitled D37687: [X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess (VF64 stride 3) from [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF64 stride 3) to [X86][LLVM]Expanding Supports lowerInterleaved{store|load}}() in X86InterleavedAccess (VF64 stride 3) .
Mon, Sep 11, 7:04 AM
m_zuckerman created D37687: [X86][LLVM]Expanding Supports lowerInterleaved{store|load}() in X86InterleavedAccess (VF64 stride 3) .
Mon, Sep 11, 7:02 AM

Sun, Sep 10

m_zuckerman updated the diff for D37117: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF{8|16|32} stride 3)...
Sun, Sep 10, 6:56 AM
m_zuckerman updated the diff for D37117: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF{8|16|32} stride 3)...
Sun, Sep 10, 4:21 AM
m_zuckerman updated the diff for D37117: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF{8|16|32} stride 3)...
Sun, Sep 10, 4:19 AM

Thu, Sep 7

m_zuckerman closed D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..

commit to https://reviews.llvm.org/rL312722

Thu, Sep 7, 7:35 AM
m_zuckerman added 1 commit(s) for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3).: rL312722: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess….
Thu, Sep 7, 7:35 AM
m_zuckerman added an edge to rL312722: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess…: D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Thu, Sep 7, 7:35 AM

Wed, Sep 6

m_zuckerman updated the diff for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Wed, Sep 6, 3:25 AM

Tue, Sep 5

m_zuckerman updated the diff for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Tue, Sep 5, 4:24 AM

Mon, Sep 4

m_zuckerman updated the diff for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..

Update according to Zvi comments

Mon, Sep 4, 2:05 PM

Sun, Sep 3

m_zuckerman updated the diff for D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Sun, Sep 3, 1:17 AM

Wed, Aug 30

m_zuckerman added inline comments to D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Wed, Aug 30, 5:12 AM
m_zuckerman updated the diff for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Wed, Aug 30, 4:00 AM

Tue, Aug 29

m_zuckerman updated the diff for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Tue, Aug 29, 6:31 AM
m_zuckerman added inline comments to D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Tue, Aug 29, 2:16 AM
m_zuckerman updated the diff for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Tue, Aug 29, 2:15 AM

Mon, Aug 28

m_zuckerman added a comment to D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..

Ping

Mon, Aug 28, 6:33 AM
m_zuckerman updated the diff for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Mon, Aug 28, 6:33 AM
m_zuckerman added inline comments to D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Mon, Aug 28, 6:29 AM

Aug 24 2017

m_zuckerman updated the diff for D37117: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF{8|16|32} stride 3)...
Aug 24 2017, 12:52 PM
m_zuckerman added a dependency for D37117: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF{8|16|32} stride 3)..: D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Aug 24 2017, 12:46 PM
m_zuckerman added a dependent revision for D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3).: D37117: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF{8|16|32} stride 3)...
Aug 24 2017, 12:46 PM
m_zuckerman created D37117: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF{8|16|32} stride 3)...
Aug 24 2017, 12:45 PM

Aug 22 2017

m_zuckerman added inline comments to D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Aug 22 2017, 12:58 AM
m_zuckerman updated the diff for D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Aug 22 2017, 12:56 AM

Aug 21 2017

m_zuckerman created D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Aug 21 2017, 7:34 AM
m_zuckerman abandoned D20055: [Clang][Intrinsics] Adding avx512f missing intrinsics {cast} .
Aug 21 2017, 4:45 AM

Aug 10 2017

m_zuckerman accepted D36570: [X86][AsmParser][AVX512] Error appropriately when K0 is tried as a write-mask.

It sounds reasonable
LGTM

Aug 10 2017, 4:45 AM
m_zuckerman added inline comments to D36570: [X86][AsmParser][AVX512] Error appropriately when K0 is tried as a write-mask.
Aug 10 2017, 3:18 AM

Aug 8 2017

m_zuckerman accepted D35785: [AsmParser][AVX512]Enhance OpMask/Zero/Merge syntax check rubostness.
Aug 8 2017, 5:44 AM

Aug 7 2017

m_zuckerman updated the diff for D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Aug 7 2017, 1:34 PM

Aug 1 2017

m_zuckerman abandoned D11215: Adding altmacro support in integrated assembler. continue of D10591 .
Aug 1 2017, 11:01 PM
m_zuckerman updated the diff for D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..
Aug 1 2017, 9:17 AM

Jul 31 2017

m_zuckerman abandoned D18794: [Clang][BuiltIn][avx512] Adding builtins and tests to clang.
Jul 31 2017, 11:11 PM
m_zuckerman abandoned D20359: [LLVM][AVX512][Intrinsics] Convert AVX non-temporal store builtins to LLVM-native IR..
Jul 31 2017, 11:08 PM
m_zuckerman abandoned D21505: [Clang][AVX512][Intrinsics]Adding intrinsics for mov{ss|sd} instruction set .
Jul 31 2017, 11:08 PM
m_zuckerman closed D20358: [Clang][AVX512][Intrinsics]Convert AVX non-temporal store builtins to LLVM-native IR..
Jul 31 2017, 11:08 PM
m_zuckerman added inline comments to D35785: [AsmParser][AVX512]Enhance OpMask/Zero/Merge syntax check rubostness.
Jul 31 2017, 10:35 PM
m_zuckerman added inline comments to D35785: [AsmParser][AVX512]Enhance OpMask/Zero/Merge syntax check rubostness.
Jul 31 2017, 10:33 PM
m_zuckerman added a comment to D35785: [AsmParser][AVX512]Enhance OpMask/Zero/Merge syntax check rubostness.

Expect (see above ) from that Look good to me

Jul 31 2017, 12:38 PM
m_zuckerman added inline comments to D35785: [AsmParser][AVX512]Enhance OpMask/Zero/Merge syntax check rubostness.
Jul 31 2017, 12:35 PM

Jul 30 2017

m_zuckerman updated the summary of D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Jul 30 2017, 5:38 AM
m_zuckerman created D36058: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF8 stride 4)..
Jul 30 2017, 5:22 AM

Jul 28 2017

m_zuckerman updated the diff for D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..
Jul 28 2017, 8:02 AM

Jul 25 2017

m_zuckerman added a dependency for D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4).: D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 25 2017, 3:30 AM
m_zuckerman added a dependent revision for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess.: D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..
Jul 25 2017, 3:30 AM
m_zuckerman updated the diff for D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..

Small modification on the function name

Jul 25 2017, 3:27 AM
m_zuckerman retitled D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4). from [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess. to [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..
Jul 25 2017, 3:25 AM
m_zuckerman created D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..
Jul 25 2017, 3:24 AM

Jul 24 2017

m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 24 2017, 11:59 AM
m_zuckerman added a comment to D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio.

I returned the RDRAND into the Goldmont and I will fix it later in another patch.

Jul 24 2017, 1:14 AM
m_zuckerman updated the diff for D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio.
Jul 24 2017, 1:12 AM

Jul 23 2017

m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

I returned to the previous patch with small modification as @RKSimon asked.

Jul 23 2017, 12:28 AM
m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

I returned to the previous patch with small modification as @RKSimon asked.

Jul 23 2017, 12:28 AM
m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 23 2017, 12:28 AM
m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 23 2017, 12:21 AM

Jul 21 2017

m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

build.CreateShuffleVector accepts only uint32_t. I created a static CreateShuffleVector that do reinterpret_cast the int to uint. This solves our dependency on the template.

Jul 21 2017, 7:06 AM
m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 21 2017, 6:06 AM

Jul 19 2017

m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

ping

Jul 19 2017, 1:23 AM

Jul 17 2017

m_zuckerman added inline comments to D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio.
Jul 17 2017, 5:07 AM

Jul 16 2017

m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

Hi Michael, I have one small additional comment. Otherwise, this looks good.

Jul 16 2017, 1:56 AM

Jul 13 2017

m_zuckerman created D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio.
Jul 13 2017, 6:48 AM
m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 13 2017, 4:33 AM

Jul 12 2017

m_zuckerman added inline comments to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 12 2017, 9:50 AM
m_zuckerman added inline comments to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 12 2017, 2:34 AM
m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 12 2017, 2:33 AM

Jul 5 2017

m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
In D34601#799242, @zvi wrote:

Michael, can you please add AVX512 targets to the tests so we ensure that the AVX512 targets are at least as good as the AVX2 targets?

Jul 5 2017, 7:53 AM

Jul 3 2017

m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

In the new patch I added a test checks the AVX sequence and new if verifies that VF32 is with store instructions.

Jul 3 2017, 7:46 AM

Jul 1 2017

m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jul 1 2017, 5:11 AM

Jun 29 2017

m_zuckerman updated the diff for D34807: [Clang][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 29 2017, 6:05 AM
m_zuckerman abandoned D34505: [Clang][X86][Goldmont] Adding new target-cpu: Goldmont .
Jun 29 2017, 4:51 AM
m_zuckerman updated the diff for D34807: [Clang][X86][Goldmont] Adding new target-cpu: Goldmont.

Remove extra feature -fsgsbase

Jun 29 2017, 3:07 AM
m_zuckerman created D34807: [Clang][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 29 2017, 1:03 AM

Jun 28 2017

m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

Have you tried enabling this also for AVX? (I understand if not, because with the current cost numbers that TTI returns for interleaved accesses on AVX we'll probably determine it's not worth vectorizing... so that may need to come along with an update of getInterleavedMemoryOpCost -- maybe at least a TODO comment is needed).

Jun 28 2017, 8:38 AM
m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jun 28 2017, 8:30 AM

Jun 27 2017

m_zuckerman updated the diff for D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 27 2017, 4:45 AM
m_zuckerman added a comment to D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.

I removed from the list of features two features FeatureSlowDivide64 and FeatureSlowPMULLD. According to the optimization manual ,that Igor added ,this issues were fixed in the GoldMont processor. Regard @RKSimon I agree with you that we want to remove the isglm() until use. But I prefer no touch the IntelGLM since I want to specialize Goldmont from the other ATOM processors .

Jun 27 2017, 3:32 AM
m_zuckerman updated the diff for D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 27 2017, 3:22 AM
m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

ping

Jun 27 2017, 1:49 AM
m_zuckerman updated subscribers of D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 27 2017, 1:19 AM

Jun 26 2017

m_zuckerman added a comment to D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..

Would it be beneficial to work on a more general solution for the 128-bit subvector issue? Won't 16x16 and 8x32 (as well as all the 512-bit equivalents) still suffer?

Jun 26 2017, 8:37 AM
m_zuckerman updated the diff for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess..
Jun 26 2017, 7:59 AM
m_zuckerman updated the diff for D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 26 2017, 1:52 AM

Jun 25 2017

m_zuckerman added a comment to D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.

removing SMAP feature.

Jun 25 2017, 9:27 AM
m_zuckerman updated the diff for D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 25 2017, 9:26 AM
m_zuckerman updated the diff for D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 25 2017, 9:12 AM
m_zuckerman abandoned D34603: [X86][LLVM]Adding SMAP feature and test.
Jun 25 2017, 8:37 AM
m_zuckerman reclaimed D34603: [X86][LLVM]Adding SMAP feature and test.
Jun 25 2017, 8:37 AM
m_zuckerman abandoned D34603: [X86][LLVM]Adding SMAP feature and test.
Jun 25 2017, 8:37 AM
m_zuckerman added a comment to D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.

Don't add the SMAP feature flag. We should only have feature flags that are used by isel.

Jun 25 2017, 6:44 AM
m_zuckerman added a dependency for D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont: D34603: [X86][LLVM]Adding SMAP feature and test.
Jun 25 2017, 6:33 AM
m_zuckerman added a dependent revision for D34603: [X86][LLVM]Adding SMAP feature and test: D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont.
Jun 25 2017, 6:33 AM
m_zuckerman created D34603: [X86][LLVM]Adding SMAP feature and test.
Jun 25 2017, 6:28 AM
m_zuckerman added a reviewer for D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess.: DavidKreitzer.
Jun 25 2017, 1:54 AM