This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Refactor VOPC instructions
ClosedPublic

Authored by vpykhtin on Sep 13 2016, 11:24 PM.

Details

Summary

I decided to split VOP refactoring into parts as the change would be really huge and make a separate TD file for VOP[C123] and one common VOPInstructions.td. Classes with New suffix are to be renamed after the transition is done.

Lit testing is underway.

Diff Detail

Repository
rL LLVM

Event Timeline

vpykhtin updated this revision to Diff 71300.Sep 13 2016, 11:24 PM
vpykhtin retitled this revision from to [AMDGPU] Refactor VOPC instructions.
vpykhtin updated this object.
vpykhtin set the repository for this revision to rL LLVM.
vpykhtin added a project: Restricted Project.
vpykhtin added a subscriber: nhaustov.

Lit testing passed.

SamWot accepted this revision.Sep 14 2016, 4:35 AM
SamWot edited edge metadata.

LGTM
Don't forget to remove "New" suffix from classes names when finish with VOP instructioins.

This revision is now accepted and ready to land.Sep 14 2016, 4:35 AM
vpykhtin updated this revision to Diff 71515.Sep 15 2016, 9:28 AM
vpykhtin edited edge metadata.
vpykhtin removed rL LLVM as the repository for this revision.
vpykhtin removed a project: Restricted Project.

rebase.

Guys!!! I'm going on vacation starting 22 sept, lets submit this, I really want to fit with the rest of VOPs in the remaining time.

Tom, can you please run tests on this patch?

Thanks,
Valery

Ping.

Rebased this change in the branch https://github.com/vpykhtin/llvm/tree/vopc_td for testing.

This revision was automatically updated to reflect the committed changes.