Page MenuHomePhabricator

[ELF] - Linkerscript: implemented FILL command.
AbandonedPublic

Authored by grimar on Sep 2 2016, 6:00 AM.

Details

Reviewers
ruiu
rafael
Summary

The FILL command is similar to the ‘=fillexp’ output section attribute, but it only affects
the part of the section following the FILL command, rather than the entire section. If both
are used, the FILL command takes precedence.

This is PR30243

Diff Detail

Event Timeline

grimar updated this revision to Diff 70150.Sep 2 2016, 6:00 AM
grimar retitled this revision from to [ELF] - Linkerscript: implemented FILL command..
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar, davide, evgeny777.
ruiu edited edge metadata.Sep 2 2016, 6:35 AM

Did you find any uses case of multiple FILL commands in one section definition? It seems to me that it's too complicated. I'd like to handle it as an alias to =<fillexp> feature.

grimar added a comment.Sep 2 2016, 7:56 AM
In D24186#532797, @ruiu wrote:

Did you find any uses case of multiple FILL commands in one section definition? It seems to me that it's too complicated. I'd like to handle it as an alias to =<fillexp> feature.

I didn't yet. Not sure that simple alias will work here. FILL command only affects the part of the section following the FILL command. So it would be very different behavior in total even for simple case when single FILL is somewhere at the midde of section.

I leaved a question on PR30243 page, let see if anyone knows the real life use cases for it.

ruiu added a comment.Sep 2 2016, 8:06 AM

My point is do you really need that behavior. I suspect not.

emaste added a subscriber: emaste.Sep 2 2016, 10:47 AM

I leaved a question on PR30243 page, let see if anyone knows the real life use cases for it.

I'm not aware of any uses for fine-grained control over fill values off hand, but I haven't looked in detail.

grimar abandoned this revision.Sep 6 2016, 6:43 AM

So looks we dont need that complexity and trivial D24227 will be commited instead.