Page MenuHomePhabricator

[llvm-readobj] - Teach readobj to print DT_AUXILIARY dynamic tag in human readable form.
ClosedPublic

Authored by grimar on Sep 1 2016, 8:31 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar updated this revision to Diff 70016.Sep 1 2016, 8:31 AM
grimar retitled this revision from to [llvm-readobj] - Teach readobj to print DT_AUXILIARY dynamic tag in human readable form..
grimar updated this object.
grimar added reviewers: davide, rafael, echristo.
grimar added subscribers: llvm-commits, grimar, evgeny777.
emaste added a subscriber: emaste.Sep 1 2016, 9:07 AM
davide accepted this revision.Sep 1 2016, 9:12 AM
davide edited edge metadata.

This is fine.

This revision is now accepted and ready to land.Sep 1 2016, 9:12 AM
emaste added inline comments.Sep 1 2016, 9:14 AM
tools/llvm-readobj/ELFDumper.cpp
1554 ↗(On Diff #70016)

This list has a mostly-alphabetical order as well as OS or processor-specific grouping it seems. Should we (separately) add comments to separate the individual blocks?

echristo accepted this revision.Sep 1 2016, 11:07 AM
echristo edited edge metadata.

One inline comment.

tools/llvm-readobj/ELFDumper.cpp
1554 ↗(On Diff #70016)

Alphabetical and possibly with blocks would be nice, yes.

This revision was automatically updated to reflect the committed changes.