Support of lldb on Kfreebsd

[sylvestre.ledru]

Summary

Patch by Pino Toscano. Reported in http://bugs.debian.org/835665

[brucem]

cmake/LLDBDependencies.cmake

168

This really should turn into a check so that we don't need this to be extended for every single OS that gets added.

[krytarowski]

cmake/LLDBDependencies.cmake

168

There is now support for CMake >= 3.0, which offers a builtin check for it.

[emaste]

• in the future can you please upload with context (e.g. git diff -U9999)
• I think the OS names in utilsOsType.py are kept sorted and the actual enum values are not part of an ABI

[tfiala]

cmake/LLDBDependencies.cmake

168

I agree with previous comments - if we can convert this to a CMake built-in check, that would be ideal.

[tfiala]

@sylvestre.ledru, I think this will be ready to go if you can convert that check to a CMake built-in check. Maybe you can pass that along to Pino Toscano?

[emaste]

Two requested changes called out in comments above

[sylvestre.ledru]

Updated by Pino!

[tfiala]

cmake/modules/LLDBConfig.cmake

414

Hi Sylvestre!

It's hard to tell without more context, but it looks like this location has most/all configurations going through it. For OSes that don't actually have a backtrace package, I think this emits a cmake error, doesn't it?

This might need to be protected by the systems that need the backtrace package. (Probably Unix-like systems only?)

[krytarowski]

cmake/modules/LLDBConfig.cmake

414

It's sufficient to drop the REQUIRED keyword and it will be fine. ${Backtrace_LIBRARY} will be evaluated to NIL in case of lack of this dependency.

I'm unsure whether find_pacakge() might be after usage of ${Backtrace_LIBRARY}. I would reorder it at least for clarity for a reader.

[tfiala]

Okay. I think we need a minor tweak, to drop the REQUIRED on the Backtrace usage.

[tfiala]

Looks reasonable to me.

@beanz, any comments on this?

[beanz]

Looks fine to me.

cmake/LLDBDependencies.cmake

     endif()
   endif()
 endif()
-# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
-  list(APPEND LLDB_SYSTEM_LIBS execinfo)
-endif()
+list(APPEND LLDB_SYSTEM_LIBS ${Backtrace_LIBRARY})
 
 if (NOT LLDB_DISABLE_PYTHON AND NOT LLVM_BUILD_STATIC)
   list(APPEND LLDB_SYSTEM_LIBS ${PYTHON_LIBRARIES})

cmake/modules/LLDBConfig.cmake

     list(APPEND system_libs ${CURSES_LIBRARIES})
     include_directories(${CURSES_INCLUDE_DIR})
 endif ()
+
+find_package(Backtrace REQUIRED)

scripts/Python/modules/CMakeLists.txt

   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-macro-redefined")
 endif ()
 
-# build the Python readline suppression module only on Linux
-if (CMAKE_SYSTEM_NAME MATCHES "Linux" AND NOT __ANDROID_NDK__)
+# build the Python readline suppression module only on Linux or GNU systems
+if ((CMAKE_SYSTEM_NAME MATCHES "Linux" OR CMAKE_SYSTEM_NAME STREQUAL "GNU" OR CMAKE_SYSTEM_NAME STREQUAL "kFreeBSD") AND NOT __ANDROID_NDK__)
    add_subdirectory(readline)
 endif()

scripts/utilsOsType.py

         Linux = 3
         NetBSD = 4
         Windows = 5
+        kFreeBSD = 6
 else:
     class EnumOsType(object):
         values = ["Unknown",

                   "FreeBSD",
                   "Linux",
                   "NetBSD",
-                  "Windows"]
+                  "Windows",
+                  "kFreeBSD"]
         class __metaclass__(type):
 #++---------------------------------------------------------------------------
 # Details:  Fn acts as an enumeration.

         eOSType = EnumOsType.NetBSD
     elif strOS == "win32":
         eOSType = EnumOsType.Windows
+    elif strOS.startswith("gnukfreebsd"):
+        eOSType = EnumOsType.kFreeBSD
 
     return eOSType