This is an archive of the discontinued LLVM Phabricator instance.

Support of lldb on Kfreebsd

Authored by sylvestre.ledru on Aug 28 2016, 2:20 PM.

Diff Detail

Event Timeline

sylvestre.ledru retitled this revision from to Support of lldb on Kfreebsd .
sylvestre.ledru updated this object.
sylvestre.ledru added a reviewer: tfiala.
sylvestre.ledru added a project: Restricted Project.
sylvestre.ledru added a subscriber: Restricted Project.
brucem added a subscriber: brucem.Aug 28 2016, 9:13 PM
brucem added inline comments.

This really should turn into a check so that we don't need this to be extended for every single OS that gets added.

krytarowski added inline comments.

There is now support for CMake >= 3.0, which offers a builtin check for it.

emaste added a subscriber: emaste.Aug 29 2016, 6:54 AM
  • in the future can you please upload with context (e.g. git diff -U9999)
  • I think the OS names in are kept sorted and the actual enum values are not part of an ABI
tfiala added inline comments.Sep 9 2016, 10:24 AM

I agree with previous comments - if we can convert this to a CMake built-in check, that would be ideal.

tfiala edited edge metadata.Sep 19 2016, 10:10 AM

@sylvestre.ledru, I think this will be ready to go if you can convert that check to a CMake built-in check. Maybe you can pass that along to Pino Toscano?

emaste requested changes to this revision.Sep 19 2016, 11:53 AM
emaste added a reviewer: emaste.

Two requested changes called out in comments above

This revision now requires changes to proceed.Sep 19 2016, 11:53 AM
sylvestre.ledru edited edge metadata.

Updated by Pino!

tfiala added inline comments.Oct 11 2016, 5:56 PM

Hi Sylvestre!

It's hard to tell without more context, but it looks like this location has most/all configurations going through it. For OSes that don't actually have a backtrace package, I think this emits a cmake error, doesn't it?

This might need to be protected by the systems that need the backtrace package. (Probably Unix-like systems only?)

krytarowski added inline comments.Oct 11 2016, 6:04 PM

It's sufficient to drop the REQUIRED keyword and it will be fine. ${Backtrace_LIBRARY} will be evaluated to NIL in case of lack of this dependency.

I'm unsure whether find_pacakge() might be after usage of ${Backtrace_LIBRARY}. I would reorder it at least for clarity for a reader.

tfiala requested changes to this revision.Oct 13 2016, 6:00 PM
tfiala edited edge metadata.

Okay. I think we need a minor tweak, to drop the REQUIRED on the Backtrace usage.

This revision now requires changes to proceed.Oct 13 2016, 6:00 PM
sylvestre.ledru edited edge metadata.

Looks reasonable to me.

@beanz, any comments on this?

beanz added a comment.Dec 16 2016, 9:28 AM

Looks fine to me.

This revision was automatically updated to reflect the committed changes.