This is an archive of the discontinued LLVM Phabricator instance.

DebugInfo: use llvm::DINode::DIFlags type for debug info flags
ClosedPublic

Authored by vleschuk on Aug 22 2016, 6:46 AM.

Details

Summary

Use llvm::DINode::DIFlags type (strongly typed enum) for debug flags instead of unsigned int to avoid problems on platforms with sizeof(int) < 4: we already have flags with values > (1 << 16).

Diff Detail

Event Timeline

vleschuk updated this revision to Diff 68854.Aug 22 2016, 6:46 AM
vleschuk retitled this revision from to DebugInfo: use llvm::di_flags_t for debug info flags.
vleschuk updated this object.
vleschuk added reviewers: echristo, aprantl.
vleschuk added subscribers: llvm-commits, cfe-commits.
vleschuk updated this revision to Diff 69332.Aug 26 2016, 2:35 AM
vleschuk retitled this revision from DebugInfo: use llvm::di_flags_t for debug info flags to DebugInfo: use llvm::DIFlagsUnderlying type for debug info flags.
vleschuk updated this object.

Chnaged typedef name according to naming convention.

dblaikie accepted this revision.Aug 29 2016, 8:52 AM
dblaikie added a reviewer: dblaikie.
This revision is now accepted and ready to land.Aug 29 2016, 8:52 AM
vleschuk updated this revision to Diff 69755.Aug 30 2016, 2:16 PM
vleschuk retitled this revision from DebugInfo: use llvm::DIFlagsUnderlying type for debug info flags to DebugInfo: use llvm::DINode::DIFlags type for debug info flags.
vleschuk updated this object.
vleschuk edited edge metadata.

Switched to include/llvm/ADT/BitmaskEnum for debug info flags.

This revision was automatically updated to reflect the committed changes.