This is an archive of the discontinued LLVM Phabricator instance.

[AAP] (3) Add AAP backend stub
AbandonedPublic

Authored by edward-jones on Aug 18 2016, 8:45 AM.

Details

Reviewers
rengolin
asb
Summary

Introduce the barebones for the AAP backend. This builds on D23665.

Diff Detail

Event Timeline

edward-jones retitled this revision from to [AAP] (3) Add AAP backend stub.
edward-jones updated this object.
edward-jones added a reviewer: rengolin.
edward-jones added subscribers: simoncook, llvm-commits.
rengolin edited edge metadata.Aug 19 2016, 2:47 AM

AFAICR, people submit the code that can perform at least some simple tasks, not just the mock. So maybe this could already have parts of the codegen that you guys have.

The next 4 patches that I have add InstrInfo, RegisterInfo tablegen, and AsmParser and MC layer support. If I merged those changes into this one patch, then the backend would be able to run basic MC level tests. Alternatively I can submit those patches separately, as when combined they contain quite a lot of code.

Right, in this case, seems trivial enough. Thanks!

asb added a reviewer: asb.Oct 12 2016, 8:07 AM
asb added a subscriber: asb.
asb added inline comments.
lib/Target/AAP/TargetInfo/AAPTargetInfo.cpp
17

In rL283702, all the in-tree backends changed to put TheFooTarget behind a getter. This patch should do the same.

edward-jones edited edge metadata.

Updated the patch to move TheAAPTarget behind a getter

joerg added a subscriber: joerg.Dec 4 2016, 9:04 AM

Just being a bit pedantic here.

lib/Target/AAP/CMakeLists.txt
6

Extra spaces.

lib/Target/AAP/LLVMBuild.txt
2

Missing - for line length.

lib/Target/AAP/TargetInfo/AAPTargetInfo.cpp
28

Missing period.

lib/Target/AAP/TargetInfo/CMakeLists.txt
4

Extra space.

joerg added a comment.Dec 4 2016, 9:46 AM

This change should update the top-level CMakeLists.txt as well to extend LLVM_ALL_TARGETS, otherwise I don't think this is fully self-contained.

This change should update the top-level CMakeLists.txt as well to extend LLVM_ALL_TARGETS, otherwise I don't think this is fully self-contained.

The target is enabled through the CMake variable EXPERIMENTAL_TARGETS_TO_BUILD, so I haven't added AAP to LLVM_ALL_TARGETS

Rolled forward to top of tree and incorporated Joerg's suggestions.

Updated to reflect latest changes to LLVM

edward-jones abandoned this revision.Sep 7 2021, 9:47 AM