Page MenuHomePhabricator

[WebAssembly] Handle debug information and virtual registers without crashing (reland r278967)
ClosedPublic

Authored by ddcc on Aug 17 2016, 4:39 PM.

Details

Summary

Reland of r278967 (reverted in r278973), added lit.local.cfg to prevent test failures on non-WebAssembly builds.

Currently, enabling debug information when compiling for WebAssembly crashes the backend. This commit fixes these by skipping debug values in backend passes.

Diff Detail

Repository
rL LLVM

Event Timeline

ddcc updated this revision to Diff 68452.Aug 17 2016, 4:39 PM
ddcc retitled this revision from to [WebAssembly] Handle debug information and virtual registers without crashing (reland r278967).
ddcc updated this object.
ddcc added reviewers: jfb, aprantl, dschuff, echristo.
ddcc added subscribers: mehdi_amini, yurydelendik, dexonsmith and 4 others.
dexonsmith accepted this revision.Aug 17 2016, 4:41 PM
dexonsmith added a reviewer: dexonsmith.

Assuming this is the same as r278967 but with the shiny new lit.local.cfg, this LGTM!

This revision is now accepted and ready to land.Aug 17 2016, 4:41 PM

But note: the commit message should really mention the old commit (and the revert) and say what you fixed.

ddcc updated this object.Aug 17 2016, 4:45 PM
ddcc edited edge metadata.
This revision was automatically updated to reflect the committed changes.