This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU ]Refactor SOP instruction definitions.
ClosedPublic

Authored by vpykhtin on Aug 17 2016, 11:33 AM.

Details

Summary

This change factors out SOP instructions in the same way as previously DS instructions were done.

Diff Detail

Event Timeline

vpykhtin updated this revision to Diff 68389.Aug 17 2016, 11:33 AM
vpykhtin retitled this revision from to [AMDGPU ]Refactor SOx instruction definitions..
vpykhtin updated this object.
vpykhtin set the repository for this revision to rL LLVM.
vpykhtin added a project: Restricted Project.
vpykhtin added a subscriber: nhaustov.
arsenm added inline comments.
lib/Target/AMDGPU/SOxInstructions.td
1

s/SOx/SOP

SamWot accepted this revision.Aug 18 2016, 7:43 AM
SamWot edited edge metadata.
This revision is now accepted and ready to land.Aug 18 2016, 7:43 AM
vpykhtin updated this revision to Diff 69024.Aug 23 2016, 12:16 PM
vpykhtin retitled this revision from [AMDGPU ]Refactor SOx instruction definitions. to [AMDGPU ]Refactor SOP instruction definitions..
vpykhtin updated this object.
vpykhtin edited edge metadata.
vpykhtin removed rL LLVM as the repository for this revision.

s/SOx/SOP done.

Lit failures fixed.

Tom, can you please run additional testing on this?

artem.tamazov accepted this revision.Aug 25 2016, 6:37 AM
artem.tamazov edited edge metadata.

LGTM

arsenm added inline comments.Aug 25 2016, 10:16 AM
lib/Target/AMDGPU/SOPInstructions.td
83 ↗(On Diff #69024)

{ on previous line, same everywhere else

97–98 ↗(On Diff #69024)

Can you remove the extra spaces between all the instructions and the :

tstellarAMD accepted this revision.Aug 29 2016, 7:59 AM
tstellarAMD edited edge metadata.

Tests pass. LGTM.

This revision was automatically updated to reflect the committed changes.