This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add hidden kernel arguments to runtime metadata
ClosedPublic

Authored by yaxunl on Aug 11 2016, 1:59 PM.

Details

Summary

OpenCL kernels have hidden kernel arguments for global offset and printf buffer. For consistency, these hidden argument should be included in the runtime metadata. Also updated kernel argument kind metadata.

Diff Detail

Event Timeline

yaxunl updated this revision to Diff 67742.Aug 11 2016, 1:59 PM
yaxunl retitled this revision from to AMDGPU: Add hidden kernel arguments to runtime metadata.
yaxunl updated this object.
yaxunl added reviewers: nhaustov, arsenm.
yaxunl added subscribers: llvm-commits, tstellarAMD.
yaxunl updated this revision to Diff 68383.Aug 17 2016, 10:35 AM
yaxunl edited edge metadata.

Make changes about argument kind and address space qualifier.

arsenm added inline comments.Aug 17 2016, 11:46 AM
lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
884

Should Pass MCStreamer & instead of unique_ptr &

938–939

Space before (. Should also move switch into function with return instead of assign and break

940

Should use enum

1003

Enum. Remove ! and swap order

yaxunl updated this revision to Diff 68397.Aug 17 2016, 12:22 PM
yaxunl marked 4 inline comments as done.

Revised as Matt suggested.

yaxunl updated this revision to Diff 70203.Sep 2 2016, 12:14 PM
yaxunl updated this object.
yaxunl added a subscriber: Restricted Project.

Rebase patch.

yaxunl updated this revision to Diff 70401.Sep 6 2016, 7:49 AM

Fix base type name and type name metadata.

Ping!

runtime is ready for this change and waiting.

tstellarAMD accepted this revision.Sep 7 2016, 10:46 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Sep 7 2016, 10:46 AM
This revision was automatically updated to reflect the committed changes.