This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Update AMDGPURuntimeMetadata.h for enums of address space qualifiers
AbandonedPublic

Authored by yaxunl on Aug 9 2016, 11:26 AM.

Diff Detail

Event Timeline

yaxunl updated this revision to Diff 67380.Aug 9 2016, 11:26 AM
yaxunl retitled this revision from to AMDGPU: Update AMDGPURuntimeMetadata.h for enums of address space qualifiers.
yaxunl updated this object.
yaxunl added reviewers: nhaustov, arsenm.
yaxunl added subscribers: llvm-commits, tstellarAMD.
arsenm added inline comments.Aug 16 2016, 12:33 PM
lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141

Should probably have the values for flat and region

yaxunl added inline comments.Aug 16 2016, 12:47 PM
lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141

This is for OpenCL kernel argument reflection. flat and region address spaces do not show up in kernel arguments.

arsenm added inline comments.Aug 16 2016, 12:51 PM
lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141

Region would if that extension were ever finished. There's no real reason we can't support flat either. The values should be there to make sure they are reserved / keep the same values as the address space enum

yaxunl added inline comments.Aug 16 2016, 1:02 PM
lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141

What is the value for region and flat address space? Thanks.

arsenm added inline comments.Aug 16 2016, 1:17 PM
lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
136–141

generic is 4 and region is 5

yaxunl updated this revision to Diff 68364.Aug 17 2016, 8:37 AM
yaxunl edited edge metadata.

Added generic and region enum value.

yaxunl abandoned this revision.Sep 7 2016, 10:54 AM

superseded by D23424