This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Include <dlfcn.h> unconditionally
ClosedPublic

Authored by elram on Jun 23 2016, 11:51 AM.

Download Raw Diff

Details

Reviewers

Commits

rGca6d868f14f5: [compiler-rt] Include <dlfcn.h> unconditionally
rCRT291454: [compiler-rt] Include <dlfcn.h> unconditionally
rL291454: [compiler-rt] Include <dlfcn.h> unconditionally

Summary

Not sure why this was ifdef-ed in the first place.
All other sources include <dlfcn.h> directly without checking the platform.

This fixes a build issue with musl-libc.

Diff Detail

Repository: rL LLVM

Event Timeline

elram updated this revision to Diff 61705.Jun 23 2016, 11:51 AM

elram retitled this revision from to [compiler-rt] Include <dlfcn.h> unconditionally.

elram updated this object.

elram added a reviewer: aizatsky.

elram added a subscriber: llvm-commits.

Herald added subscribers: kubamracek, srhines, danalbert, tberghammer. · View Herald TranscriptJun 23 2016, 11:51 AM

aizatsky accepted this revision.Jun 23 2016, 2:49 PM

aizatsky edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2016, 2:49 PM

elram closed this revision.Jul 2 2016, 3:33 AM

I thought this was already committed. Sorry for the noise.

This revision is now accepted and ready to land.Jul 2 2016, 4:55 AM

Looks like patch was not committed.

Can someone commit this please?

Closed by commit rL291454: [compiler-rt] Include <dlfcn.h> unconditionally (authored by kuba.brecka). · Explain WhyJan 9 2017, 9:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

trunk/

lib/

sanitizer_common/

sanitizer_linux_libcdep.cc

3 lines

Diff 83642

compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc

	Show All 20 Lines
	#include "sanitizer_common.h"			#include "sanitizer_common.h"
	#include "sanitizer_flags.h"			#include "sanitizer_flags.h"
	#include "sanitizer_freebsd.h"			#include "sanitizer_freebsd.h"
	#include "sanitizer_linux.h"			#include "sanitizer_linux.h"
	#include "sanitizer_placement_new.h"			#include "sanitizer_placement_new.h"
	#include "sanitizer_procmaps.h"			#include "sanitizer_procmaps.h"
	#include "sanitizer_stacktrace.h"			#include "sanitizer_stacktrace.h"

	#if SANITIZER_ANDROID \|\| SANITIZER_FREEBSD
	#include <dlfcn.h> // for dlsym()			#include <dlfcn.h> // for dlsym()
	#endif

	#include <link.h>			#include <link.h>
	#include <pthread.h>			#include <pthread.h>
	#include <signal.h>			#include <signal.h>
	#include <sys/resource.h>			#include <sys/resource.h>
	#include <syslog.h>			#include <syslog.h>

	#if SANITIZER_FREEBSD			#if SANITIZER_FREEBSD
	#include <pthread_np.h>			#include <pthread_np.h>
	▲ Show 20 Lines • Show All 516 Lines • Show Last 20 Lines