This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Include <dlfcn.h> unconditionally
ClosedPublic

Authored by elram on Jun 23 2016, 11:51 AM.

Reviewers

Commits

Summary

Not sure why this was ifdef-ed in the first place.
All other sources include <dlfcn.h> directly without checking the platform.

This fixes a build issue with musl-libc.

elram retitled this revision from to [compiler-rt] Include <dlfcn.h> unconditionally.

elram updated this object.

elram added a reviewer: aizatsky.

elram added a subscriber: llvm-commits.

aizatsky edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2016, 2:49 PM

I thought this was already committed. Sorry for the noise.

This revision is now accepted and ready to land.Jul 2 2016, 4:55 AM

Looks like patch was not committed.

Can someone commit this please?

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

sanitizer_common/

3 lines

Context not available.
	#include "sanitizer_procmaps.h"	#include "sanitizer_procmaps.h"
	#include "sanitizer_stacktrace.h"	#include "sanitizer_stacktrace.h"

	#if SANITIZER_ANDROID \|\| SANITIZER_FREEBSD
	#include <dlfcn.h> // for dlsym()	#include <dlfcn.h> // for dlsym()
	#endif

	#include <link.h>	#include <link.h>
	#include <pthread.h>	#include <pthread.h>
	#include <signal.h>	#include <signal.h>
Context not available.