This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Include <dlfcn.h> unconditionally
ClosedPublic

Authored by elram on Jun 23 2016, 11:51 AM.

Details

Summary

Not sure why this was ifdef-ed in the first place.
All other sources include <dlfcn.h> directly without checking the platform.

This fixes a build issue with musl-libc.

Diff Detail

Repository
rL LLVM

Event Timeline

elram updated this revision to Diff 61705.Jun 23 2016, 11:51 AM
elram retitled this revision from to [compiler-rt] Include <dlfcn.h> unconditionally.
elram updated this object.
elram added a reviewer: aizatsky.
elram added a subscriber: llvm-commits.
aizatsky accepted this revision.Jun 23 2016, 2:49 PM
aizatsky edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2016, 2:49 PM
elram closed this revision.Jul 2 2016, 3:33 AM
elram reopened this revision.Jul 2 2016, 4:55 AM

I thought this was already committed. Sorry for the noise.

This revision is now accepted and ready to land.Jul 2 2016, 4:55 AM

Looks like patch was not committed.

elram added a comment.Jan 5 2017, 4:22 AM

Can someone commit this please?

This revision was automatically updated to reflect the committed changes.