[Polly][GSoC]Rename ScopInfo to ScopBuilder
ClosedPublic
Actions

Authored by cs14mtech11017 on May 31 2016, 12:18 PM.

Details

Reviewers

etherzhhb
Meinersbur
grosser
jdoerfert

Summary

This patch only renames ScopInfo class to ScopBuilder. This change is required because ScopBuilder class only creates SCoP objects, it is not a container class to store them. Valid SCoP objects will be contained in ScopInfoRegionPass and ScopInfoWrapperPass.

Depends on D20770

Diff Detail

Event Timeline

cs14mtech11017 updated this revision to Diff 59111.May 31 2016, 12:18 PM

cs14mtech11017 retitled this revision from to [Polly][GSoC]Renamed ScopInfo to ScopBuilder and updated its memory management..

cs14mtech11017 updated this object.

cs14mtech11017 added reviewers: grosser, Meinersbur, jdoerfert.

cs14mtech11017 added a parent revision: D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass.

Herald added a subscriber: sanjoy. · View Herald TranscriptMay 31 2016, 12:18 PM

cs14mtech11017 added a reviewer: etherzhhb.May 31 2016, 12:23 PM

cs14mtech11017 added a subscriber: Restricted Project.

jdoerfert added inline comments.Jun 1 2016, 2:53 AM

include/polly/ScopInfo.h
2529	Please do first the rename and than add this pass.

cs14mtech11017 updated this object.Jun 1 2016, 3:28 AM

Separated renaming of ScopInfo to ScoBuilder and adding a new pass ScopInfoWrapper pass into two patches.

cs14mtech11017 added subscribers: pollydev, llvm-commits, cs14mtech11017.Jun 1 2016, 10:19 AM

cs14mtech11017 retitled this revision from [Polly][GSoC]Renamed ScopInfo to ScopBuilder and updated its memory management. to [Polly][GSoC]Renamed ScopInfo to ScopBuilder and update its memory management..Jun 1 2016, 10:23 AM

Can you make two commits, one for
"Rename ScopInfo to ScopBuilder."
and another
"Update ScopBuilder's memory management."?

In a later step, we could move the ScopBuilder into its own ScopBuilder.cpp and remove its declaration from the public ScopInfo.h as it's only used by ScopInfoRegionPass.

This revision now requires changes to proceed.Jun 1 2016, 10:40 AM

llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

msg-27246-463.txt579 BDownload
signature.asc219 BDownload

LGTM.

cs14mtech11017 added a child revision: D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management.Jun 2 2016, 11:22 AM

LGTM.

Already committed by Johannes in r271521.

This revision is now accepted and ready to land.Jun 3 2016, 5:19 AM

Meinersbur closed this revision.Jun 3 2016, 5:19 AM

cs14mtech11017 added a child revision: D20962: [Polly][GSoC 2016]New function pass ScopInfoWrapperPass.Jun 3 2016, 7:33 AM

mreisinger added a subscriber: mreisinger.Jun 8 2016, 7:30 AM

mreisinger added inline comments.

include/polly/ScopInfo.h
2490	Maybe we should also rename this member from `SI` to `SB` then, to avoid confusion. I apologize for commenting after this patch has already been merged, unfortunately I've noticed this too late.