This is an archive of the discontinued LLVM Phabricator instance.

[Polly][GSoC 2016][WIP]New function pass DependenceInfoWrapperPass

Authored by cs14mtech11017 on Jun 7 2016, 3:08 PM.



This patch addresses -
#A new function pass to compute polyhedral dependences. This is required to avoid region pass manager
#Stores a map of Scop to Dependence object of all the scops present in a function. By default, access wise dependences are stored.

This is work in progress. Need reviews and comments to make it better.

Depends on D20962

Diff Detail


Event Timeline

cs14mtech11017 retitled this revision from to [Polly][GSoC 2016][WIP]New function pass DependenceInfoWrapperPass.
cs14mtech11017 updated this object.
cs14mtech11017 added subscribers: pollydev, llvm-commits.
grosser edited edge metadata.Jun 11 2016, 3:15 AM

Dear Utpal,

thanks for working on this. The general direction looks good. I leave the more detailed review to Johannes, Ether and whoever else has some input.


grosser added a subscriber: grosser.
jdoerfert edited edge metadata.Jun 27 2016, 2:45 AM

Please look at the comments and add some test cases as you did with the scopinfo function pass.

243 ↗(On Diff #59957)

Move this to the private section of the class please.

250 ↗(On Diff #59957)

@param S

808 ↗(On Diff #59957)

I am still not a fan of these lines and you introduce 2 of them in this patch. Could you remove them or do you think they really help?

825 ↗(On Diff #59957)

assertion message seems odd.

And why cant we recompute dependences for the same SCoP? Isn't that what this function is all about?

837 ↗(On Diff #59957)

Empty line + @brief comment in the cpp file.

cs14mtech11017 edited edge metadata.
cs14mtech11017 marked 3 inline comments as done.
This revision was automatically updated to reflect the committed changes.