cs14mtech11017 (Utpal Bora)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2015, 1:33 PM (134 w, 1 d)

Recent Activity

Jun 25 2017

cs14mtech11017 added a comment to D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".

It makes more sense to me to be using the --make-param flag to pass a test specific configuration options. If you want to add all these size classes, all the tests should support them, or have them mapped back to nearest size the tests can handle.

Jun 25 2017, 11:45 PM
cs14mtech11017 added a comment to D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".
  • Indeed, active test-suite development is done in the cmake build (test_suite.py in lnt). You may still change nt.py but landing features exclusively there would be bad.

Thanks for letting me know. Will update for both.

  • It seems the llvm test-suite today only checks for SMALL_PROBLEM_SIZE, occasionally LARGE_PROBLEM_SIZE and for SPEC you can choose the size manually. Do you plan to change the test-suite for the new sizes? We should probably do further discussions there.

I added these options only for Polybench. Have not inspected the other benchmarks. I would like to discuss how we can map these sizes for other benchmarks? One we agree upon something, I can make the changes for the test-suite.

  • Do you plan to set any rules/expectations on those new sizes? (Something like "mini" finished in half the time than "small")

I have not thought about it yet.

  • Out of interest: Why do you need finer control over the problem sizes?

I am working with Polybench, which supports multiple input dataset sizes. I did these changes for my experiments and thought it would be better to upload the changes for the community.

Jun 25 2017, 11:36 PM
cs14mtech11017 added a comment to D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".

I think nt.py is deprecated, and meant to be replaced by test_suite.py.

Maybe someone who already contributed to lnt should be necessary for acceptance.

A few of the most active developers on test-suite and lnt at least think it's better to use the (new) CMake+lit-based system to drive the test-suite rather than the (old) Makefile-based system. 'nt.py' in LNT is a layer around the Makefile-based system, "test_suite.py" is a layer around the CMake+lit-based system. I guess you could say that makes nt.py "deprecated".

Anyway, on the patch itself here: I don't really like adding ever more separate command line options for specifying different data sizes available in a test suite. Wouldn't it be better to introduce a command line argument spelled e.g. "--datasize=mini|small|standard|large|extra_large"? We could then also hopefully deprecate "--small", "--large", "--spec-with-ref", etc., making them aliases for the new command line option for backwards compatibility. Note that I haven't thought about what the best name would be for this option. Maybe "inputsize" is more in line with common terminology across benchmarks? Although it may be hard to guess from the "inputsize" exactly what it means without further explanation either...

I agree with you. I was planning to add such a flag for all the sizes "--datasize=mini|small|standard|large|extra_large". Did not do it for compatibility. Thanks for the suggestion about aliasing for backward compatibility. If we agree on adding such an option, I think "--testdatasize" will be appropriate. And I would argue about using a common flag like this one for all for all data sizes instead of using "--make-param" flag as pointed out by @cmatthews.

Jun 25 2017, 11:30 PM
cs14mtech11017 added a comment to D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".

I think nt.py is deprecated, and meant to be replaced by test_suite.py.

Maybe someone who already contributed to lnt should be necessary for acceptance.

Jun 25 2017, 11:21 PM

Jun 19 2017

cs14mtech11017 added reviewers for D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt": Meinersbur, grosser.
Jun 19 2017, 10:53 PM
cs14mtech11017 added reviewers for D34363: [LLVM Test-suite] Added Support for different dataset usage in Polybench: Meinersbur, grosser.
Jun 19 2017, 10:52 PM
cs14mtech11017 updated subscribers of D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".
Jun 19 2017, 1:53 PM
cs14mtech11017 updated subscribers of D34363: [LLVM Test-suite] Added Support for different dataset usage in Polybench.
Jun 19 2017, 1:52 PM
cs14mtech11017 updated the summary of D34363: [LLVM Test-suite] Added Support for different dataset usage in Polybench.
Jun 19 2017, 1:36 PM
cs14mtech11017 retitled D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt" from [lnt] Support for different DataSet usage in Polybench with nt test to [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".
Jun 19 2017, 1:36 PM
cs14mtech11017 created D34363: [LLVM Test-suite] Added Support for different dataset usage in Polybench.
Jun 19 2017, 1:35 PM
cs14mtech11017 created D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt".
Jun 19 2017, 1:24 PM

Jul 18 2016

cs14mtech11017 added inline comments to D22407: [Polly][GSoC 2016]New API to check vectorization legality of a loop.
Jul 18 2016, 4:38 AM
cs14mtech11017 updated the diff for D22407: [Polly][GSoC 2016]New API to check vectorization legality of a loop.
Jul 18 2016, 4:38 AM

Jul 15 2016

cs14mtech11017 updated the diff for D22402: [Polly][GSoC 2016]Do not process SCoPs with infeasible runtime context.
Jul 15 2016, 8:15 AM
cs14mtech11017 updated D22407: [Polly][GSoC 2016]New API to check vectorization legality of a loop.
Jul 15 2016, 7:35 AM
cs14mtech11017 updated the diff for D22407: [Polly][GSoC 2016]New API to check vectorization legality of a loop.
Jul 15 2016, 7:34 AM
cs14mtech11017 added inline comments to D22407: [Polly][GSoC 2016]New API to check vectorization legality of a loop.
Jul 15 2016, 7:29 AM
cs14mtech11017 updated the diff for D22407: [Polly][GSoC 2016]New API to check vectorization legality of a loop.

Updated as per review comments.

Jul 15 2016, 7:29 AM
cs14mtech11017 added a comment to D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.

I tested this with lnt and there are no crashes. However, there exists few failed cases with and without this patch.

Jul 15 2016, 7:14 AM
cs14mtech11017 added inline comments to D22402: [Polly][GSoC 2016]Do not process SCoPs with infeasible runtime context.
Jul 15 2016, 7:12 AM
cs14mtech11017 retitled D22407: [Polly][GSoC 2016]New API to check vectorization legality of a loop from to [Polly][GSoC 2016]New API to check vectorization legality of a loop.
Jul 15 2016, 5:51 AM
cs14mtech11017 added a dependent revision for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis: D22407: [Polly][GSoC 2016]New API to check vectorization legality of a loop.
Jul 15 2016, 5:51 AM
cs14mtech11017 retitled D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis from [Polly][GSoC 2016][WIP]Add PolyhedralInfo pass- new interface to Polly Analysis to [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jul 15 2016, 4:16 AM
cs14mtech11017 updated the diff for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jul 15 2016, 4:10 AM
cs14mtech11017 updated the diff for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jul 15 2016, 4:04 AM
cs14mtech11017 updated the diff for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jul 15 2016, 4:02 AM
cs14mtech11017 updated D22402: [Polly][GSoC 2016]Do not process SCoPs with infeasible runtime context.
Jul 15 2016, 1:13 AM
cs14mtech11017 retitled D22402: [Polly][GSoC 2016]Do not process SCoPs with infeasible runtime context from to [Polly][GSoC 2016]Do not process SCoPs with infeasible runtime context.
Jul 15 2016, 1:11 AM

Jul 11 2016

cs14mtech11017 added inline comments to D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jul 11 2016, 9:20 AM
cs14mtech11017 updated the diff for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.

Updated according to review comments.

Jul 11 2016, 9:15 AM

Jul 8 2016

cs14mtech11017 added a comment to D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.

Updated the patch with necessary changes. Added unit test cases.

Jul 8 2016, 6:29 AM
cs14mtech11017 updated the diff for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.

Fixed corrupt memory issues due to isl objects. Added test cases.

Jul 8 2016, 6:27 AM

Jul 6 2016

cs14mtech11017 updated the diff for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jul 6 2016, 8:10 AM
cs14mtech11017 updated subscribers of D22036: [polly] Add accelerator code generation pass skeleton.
Jul 6 2016, 4:48 AM
cs14mtech11017 updated subscribers of D22033: Add ppcg-0.04 to lib/External.
Jul 6 2016, 2:21 AM

Jul 3 2016

cs14mtech11017 updated the diff for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jul 3 2016, 11:00 AM

Jun 27 2016

cs14mtech11017 updated the diff for D21105: [Polly][GSoC 2016][WIP]New function pass DependenceInfoWrapperPass.
Jun 27 2016, 6:55 AM
cs14mtech11017 updated the diff for D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jun 27 2016, 3:23 AM

Jun 17 2016

cs14mtech11017 updated subscribers of D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jun 17 2016, 5:46 PM
cs14mtech11017 retitled D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis from to [Polly][GSoC 2016][WIP]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jun 17 2016, 5:21 PM

Jun 8 2016

cs14mtech11017 added inline comments to D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.
Jun 8 2016, 8:15 AM

Jun 7 2016

cs14mtech11017 added a comment to D21102: [Polly][GSoC 2016] Draft of using new pass manager to cache/invalidate scop analysis in a function pass.

Thanks a lot. I will experiment with it.
Created a new pass to calculate dependences for a function D21105.
We can introduce similar changes over their.

Jun 7 2016, 3:29 PM
cs14mtech11017 retitled D21105: [Polly][GSoC 2016][WIP]New function pass DependenceInfoWrapperPass from to [Polly][GSoC 2016][WIP]New function pass DependenceInfoWrapperPass.
Jun 7 2016, 3:08 PM
cs14mtech11017 added a dependent revision for D20962: [Polly][GSoC 2016]New function pass ScopInfoWrapperPass: D21105: [Polly][GSoC 2016][WIP]New function pass DependenceInfoWrapperPass.
Jun 7 2016, 3:08 PM
cs14mtech11017 added a comment to D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management.

Please review and comment.

Jun 7 2016, 3:02 PM
cs14mtech11017 added a comment to D20962: [Polly][GSoC 2016]New function pass ScopInfoWrapperPass.

Thank you for your inputs. I have updated the patch accordingly.
Please let me know if this set of test cases is not enough.

Jun 7 2016, 10:13 AM
cs14mtech11017 updated the diff for D20962: [Polly][GSoC 2016]New function pass ScopInfoWrapperPass.
Jun 7 2016, 10:08 AM

Jun 3 2016

cs14mtech11017 retitled D20962: [Polly][GSoC 2016]New function pass ScopInfoWrapperPass from to [Polly][GSoC 2016]New function pass ScopInfoWrapperPass.
Jun 3 2016, 7:33 AM
cs14mtech11017 added a dependent revision for D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder: D20962: [Polly][GSoC 2016]New function pass ScopInfoWrapperPass.
Jun 3 2016, 7:33 AM
cs14mtech11017 updated the diff for D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management.
Jun 3 2016, 6:54 AM
cs14mtech11017 added inline comments to D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management.
Jun 3 2016, 6:32 AM
cs14mtech11017 updated the diff for D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management.

Follow variable naming convention.
Delete ScopBuilder after new in ScopInfoRegionPass::runOnRegion.

Jun 3 2016, 5:09 AM

Jun 2 2016

cs14mtech11017 updated the diff for D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management.

Rebased over patch D20831 which is not committed yet.

Jun 2 2016, 11:22 AM
cs14mtech11017 added a dependent revision for D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder: D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management.
Jun 2 2016, 11:22 AM
cs14mtech11017 retitled D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management from to [Polly][GSoC 2016]Update ScopBuilder's memory management.
Jun 2 2016, 8:25 AM
cs14mtech11017 updated the diff for D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.

This patch only renames ScopInfo class to ScopBuilder. This change is required because ScopBuilder class only creates SCoP objects, it is not a container class to store them. Valid SCoP objects will be contained in ScopInfoRegionPass and ScopInfoWrapperPass.

Jun 2 2016, 4:46 AM

Jun 1 2016

cs14mtech11017 retitled D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder from [Polly][GSoC]Renamed ScopInfo to ScopBuilder and updated its memory management. to [Polly][GSoC]Renamed ScopInfo to ScopBuilder and update its memory management..
Jun 1 2016, 10:23 AM
cs14mtech11017 updated subscribers of D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.
Jun 1 2016, 10:19 AM
cs14mtech11017 updated the diff for D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.

Separated renaming of ScopInfo to ScoBuilder and adding a new pass ScopInfoWrapper pass into two patches.

Jun 1 2016, 3:31 AM
cs14mtech11017 updated D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.
Jun 1 2016, 3:28 AM

May 31 2016

cs14mtech11017 added a reviewer for D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder: etherzhhb.
May 31 2016, 12:23 PM
cs14mtech11017 retitled D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder from to [Polly][GSoC]Renamed ScopInfo to ScopBuilder and updated its memory management..
May 31 2016, 12:18 PM
cs14mtech11017 added a dependent revision for D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass: D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.
May 31 2016, 12:18 PM

May 30 2016

cs14mtech11017 added a comment to D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass.

Hello Tobias,

May 30 2016, 8:45 AM
cs14mtech11017 updated the diff for D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass.
  • Removed releaseMemory and print functions from ScopInfo class as they are not required any more.
May 30 2016, 8:37 AM
cs14mtech11017 added inline comments to D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass.
May 30 2016, 6:04 AM
cs14mtech11017 added a comment to D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass.

I have done the changes you requested. Have arc for the new patch.

May 30 2016, 4:42 AM
cs14mtech11017 updated the diff for D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass.
  • Decouple Scop building logic from pass logic
  • Removed createScopInfo function and inlined code into ScopInfo constructor.
May 30 2016, 4:24 AM

May 28 2016

cs14mtech11017 edited reviewers for D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass, added: jdoerfert; removed: Unknown Object (User).
May 28 2016, 6:24 AM
cs14mtech11017 retitled D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass from to [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass.
May 28 2016, 4:17 AM

Jul 29 2015

cs14mtech11017 updated the diff for D11425: Filter UnDef size values in Scop Detection.

Filter UnDef size values in Scop Detection.

Jul 29 2015, 2:08 AM
cs14mtech11017 added a comment to D11425: Filter UnDef size values in Scop Detection.

Yes I saw that now. Thanks for catching it so quickly. Now all the test cases are passing.

Jul 29 2015, 12:21 AM

Jul 28 2015

cs14mtech11017 added a comment to D11425: Filter UnDef size values in Scop Detection.

Hi Tobias,

Jul 28 2015, 11:42 PM

Jul 23 2015

cs14mtech11017 added a comment to D11425: Filter UnDef size values in Scop Detection.

Hi Utpal,

thanks for your work.

The patch itself looks good, but could you please include a test case in

Jul 23 2015, 5:08 AM

Jul 22 2015

cs14mtech11017 retitled D11425: Filter UnDef size values in Scop Detection from to Filter UnDef size values in Scop Detection.
Jul 22 2015, 12:59 PM