mreisinger (Matthias J. Reisinger)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2016, 1:10 PM (83 w, 5 d)

Recent Activity

Sep 20 2016

mreisinger updated D24560: [ScopDetection] Remove redundant checks for endless loops.
Sep 20 2016, 9:46 AM

Sep 19 2016

mreisinger added a comment to D24560: [ScopDetection] Remove redundant checks for endless loops.

Thank you for the positive feedback and the discussion! I updated the above summary to reflect the insight that Johannes provided.

Sep 19 2016, 1:20 PM
mreisinger updated D24560: [ScopDetection] Remove redundant checks for endless loops.
Sep 19 2016, 1:17 PM
mreisinger retitled D24560: [ScopDetection] Remove redundant checks for endless loops from [ScopDetection] Remove redundant checks for endless loops [NFC] to [ScopDetection] Remove redundant checks for endless loops.
Sep 19 2016, 1:30 AM

Sep 14 2016

mreisinger retitled D24560: [ScopDetection] Remove redundant checks for endless loops from to [ScopDetection] Remove redundant checks for endless loops [NFC].
Sep 14 2016, 6:36 AM

Aug 3 2016

mreisinger added a comment to D22864: [InstCombine] Refactor optimization of zext(or(icmp, icmp)) to enable more aggressive cast-folding.

Thank you for committing!

Aug 3 2016, 1:14 PM
mreisinger updated the diff for D22864: [InstCombine] Refactor optimization of zext(or(icmp, icmp)) to enable more aggressive cast-folding.

I now rebased the patch (I thereby also replaced my introduced cast<>s by dyn_cast<>s which is cleaner now, sorry for this post-acceptance change). I also reran make check and lnt now and the tests pass - all but the MultiSource/Benchmarks/MiBench/consumer-typeset/consumer-typeset.execution_time in lnt, but this seems to be independent from my changes since it also fails when testing with a clean llvm build that doesn't include my patch (I ran lnt via myvirtualenv/bin/lnt runtest nt --sandbox /tmp --cc ~/opt/llvm_release+asserts/bin/clang --test-suite ~/repos/llvm-test-suite). I don't know if that's a known issue, but at least I could not find an according bugzilla entry - I'll try to further investigate this.

Aug 3 2016, 7:25 AM

Aug 2 2016

mreisinger added a comment to D22864: [InstCombine] Refactor optimization of zext(or(icmp, icmp)) to enable more aggressive cast-folding.

Cool, thank you for reviewing! Since I don't have commit privileges, somebody else may have to merge this. Should I therefore rebase and reupload the patch?

Aug 2 2016, 2:04 PM

Aug 1 2016

mreisinger added a comment to D22864: [InstCombine] Refactor optimization of zext(or(icmp, icmp)) to enable more aggressive cast-folding.

Hi Sanjay, thank you for jumping in and for adding subscribers!

Aug 1 2016, 1:07 PM

Jul 27 2016

mreisinger updated D22864: [InstCombine] Refactor optimization of zext(or(icmp, icmp)) to enable more aggressive cast-folding.
Jul 27 2016, 9:43 AM
mreisinger retitled D22864: [InstCombine] Refactor optimization of zext(or(icmp, icmp)) to enable more aggressive cast-folding from to [InstCombine] Combine unfolding and optimization of casts in zext(or(icmp, icmp)).
Jul 27 2016, 7:09 AM

Jul 26 2016

mreisinger updated subscribers of D22828: [GSoC 2016][Polly][WIP] Extend the jscop interface to allow the user to declare new arrays and to reference these arrays from access expressions.
Jul 26 2016, 2:30 PM

Jul 20 2016

mreisinger updated D22561: [InstCombine] Provide more test cases for cast-folding [NFC].
Jul 20 2016, 2:41 AM
mreisinger added a comment to D22511: [InstCombine] Enable cast-folding in logic(cast(icmp), cast(icmp)).

Thank you for committing. See https://reviews.llvm.org/D22561 for additional test cases.

Jul 20 2016, 2:30 AM
mreisinger retitled D22561: [InstCombine] Provide more test cases for cast-folding [NFC] from to [InstCombine] Provide more test cases for cast-folding [NFC].
Jul 20 2016, 2:29 AM
mreisinger updated subscribers of D21486: [Polly][GSoC 2016]Add PolyhedralInfo pass- new interface to Polly Analysis.
Jul 20 2016, 2:00 AM
mreisinger updated subscribers of D21491: [GSoC 2016] [Polly] [WIP] Apply all necessary tilings and interchangings to get a macro-kernel.
Jul 20 2016, 1:40 AM

Jul 19 2016

mreisinger updated the diff for D22511: [InstCombine] Enable cast-folding in logic(cast(icmp), cast(icmp)).

Thank you, I updated the test cases accordingly.

Jul 19 2016, 9:14 AM
mreisinger updated D22511: [InstCombine] Enable cast-folding in logic(cast(icmp), cast(icmp)).
Jul 19 2016, 7:12 AM
mreisinger retitled D22511: [InstCombine] Enable cast-folding in logic(cast(icmp), cast(icmp)) from to [InstCombine] Enable cast-folding in logic(cast(icmp), cast(icmp)).
Jul 19 2016, 6:49 AM

Jul 18 2016

mreisinger updated the diff for D22449: [InstCombine] Minor cleanup of cast simplification code [NFC].

Thank you for bringing this to my notice @majnemer.

Jul 18 2016, 11:25 AM
mreisinger updated the diff for D22449: [InstCombine] Minor cleanup of cast simplification code [NFC].

Thank you for the feedback, I updated the patch accordingly.

Jul 18 2016, 9:24 AM
mreisinger updated D22449: [InstCombine] Minor cleanup of cast simplification code [NFC].
Jul 18 2016, 9:20 AM
mreisinger retitled D22449: [InstCombine] Minor cleanup of cast simplification code [NFC] from [InstCombine] NFC: Minor code cleanup to [InstCombine] Minor cleanup of cast simplification code [NFC].
Jul 18 2016, 9:10 AM
mreisinger updated the diff for D22449: [InstCombine] Minor cleanup of cast simplification code [NFC].

Fixed some typos.

Jul 18 2016, 8:41 AM
mreisinger updated D22449: [InstCombine] Minor cleanup of cast simplification code [NFC].
Jul 18 2016, 8:22 AM
mreisinger updated the diff for D22449: [InstCombine] Minor cleanup of cast simplification code [NFC].

I updated the patch now to only contain style changes (see title and summary for detailed information). And you were right Tobias (regarding \brief), since autobrief is enabled \brief can safely be dropped here.

Jul 18 2016, 8:20 AM
mreisinger added a comment to D22449: [InstCombine] Minor cleanup of cast simplification code [NFC].

Thank you a lot for this extensive feedback, Tobias! I agree that it makes to make this an NFC for the style changes for now. As soon as this is merged I will open a separate PR for the functional changes then. Before updating the patch I also have a few questions (also see my responses to your inline comments).

Jul 18 2016, 2:26 AM

Jul 17 2016

mreisinger added a comment to D21003: Fix mentor name.

Sorry, I should have mentioned that I also don't have commit access on the repo. Thank you for committing @gareevroman.

Jul 17 2016, 6:22 AM
mreisinger retitled D22449: [InstCombine] Minor cleanup of cast simplification code [NFC] from to Enable folding of (logic (cast icmp), (cast icmp)) to (cast (logic (icmp), (icmp))).
Jul 17 2016, 6:17 AM
mreisinger abandoned D22447: Enable folding of (logic (cast icmp), (cast icmp)) to (cast (logic (icmp), (icmp))).

I'll close this again, since I forgot to initially subscribe llvm-commits to this. Sorry for the inconvenience.

Jul 17 2016, 6:11 AM
mreisinger updated subscribers of D22447: Enable folding of (logic (cast icmp), (cast icmp)) to (cast (logic (icmp), (icmp))).
Jul 17 2016, 6:03 AM
mreisinger added a comment to D21003: Fix mentor name.

Is there any additional action required from my side in order to merge this change?

Jul 17 2016, 4:31 AM
mreisinger abandoned D21727: Detect more min/max patterns in ScalarEvolution.

Thank you for all the comments. I close this now, in favor of a different approach. The recent discussion on this can also be followed at https://groups.google.com/forum/#!topic/julia-dev/5io1KnEswqs

Jul 17 2016, 4:29 AM
mreisinger retitled D22447: Enable folding of (logic (cast icmp), (cast icmp)) to (cast (logic (icmp), (icmp))) from to Enable folding of (logic (cast icmp), (cast icmp)) to (cast (logic (icmp), (icmp))).
Jul 17 2016, 4:24 AM

Jun 27 2016

mreisinger added a comment to D21727: Detect more min/max patterns in ScalarEvolution.

Thank you for your comments Michael! However, regarding Sanjoy's concerns, I am unsure if it's really possible to change these patterns to be applicable in cases where the absence of a wraparound cannot be assured, like in the provided test cases. I hope not to overlook obvious opportunities for such a generalization. However, if it's indeed unattainable at the level of ScalarEvolution, this would at least unveil the necessity to handle this via canonicalization on the side of Julia's LLVM code generator. If true, I am sorry that this patch was needed to gain this insight.

Jun 27 2016, 2:02 PM

Jun 25 2016

mreisinger added a comment to D21727: Detect more min/max patterns in ScalarEvolution.

Thank you for bringing this to my notice, I will address these issues and update the patch.

Jun 25 2016, 12:41 PM
mreisinger added a comment to D21727: Detect more min/max patterns in ScalarEvolution.

Unfortunately, these changes cause the function createNodeForSelectOrPHI to get quite long. Originally I tried to combine the added code with the existing pattern matching logic in the ICMP_SGE and ICMP_UGE case branches. But in my opinion this caused the code to get too unclear, so I decided to separate the logic. In case the provided test cases are too compact, I can also try to define more extensive ones. Also I was not sure where the existing pattern matching logic is tested, therefore, for now, I added a separate test file for this.

Jun 25 2016, 8:43 AM
mreisinger updated D21727: Detect more min/max patterns in ScalarEvolution.
Jun 25 2016, 8:41 AM
mreisinger retitled D21727: Detect more min/max patterns in ScalarEvolution from to Detect more min/max patterns in ScalarEvolution.
Jun 25 2016, 8:31 AM

Jun 8 2016

mreisinger updated subscribers of D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.
Jun 8 2016, 7:30 AM

Jun 5 2016

mreisinger retitled D21003: Fix mentor name from to Fix mentor name.
Jun 5 2016, 12:52 PM

May 22 2016

mreisinger updated the diff for D20364: Enhance design of GSoC 2016 projects page and add details for Julia project.

I'm sorry, I was away this weekend. I applied a bigger style for the headings now.

May 22 2016, 10:45 PM

May 18 2016

mreisinger retitled D20364: Enhance design of GSoC 2016 projects page and add details for Julia project from to Enhance design of GSoC 2016 projects page and add details for Julia project.
May 18 2016, 6:17 AM