This patch implements microMIPS32r6 CFC1, CFC2, CTC1, CTC2, LDC1 and LDC2 instructions.
Details
Diff Detail
Event Timeline
Minor nits.
For the (in)valid tests, can you integrate them alphabetically into the corresponding instruction groups.
Can you rebase this to ToT?
lib/Target/Mips/MicroMipsInstrFPU.td | ||
---|---|---|
150 | Space between the FGR_32 and the {. | |
lib/Target/Mips/MipsInstrInfo.td | ||
1088 | Formatting, line length should not exceed 80 characters if possible. Start a newline after the new parameter (Operand MemOpnd). | |
1647 | Formatting, line length should not exceed 80 characters. Start a new line after "load>,". | |
test/MC/Mips/mips32r6/invalid.s | ||
16 | What is being tested here that line 15 does not cover? | |
test/MC/Mips/mips64r6/invalid.s | ||
16 | See my comment on mips32r6/invalid.s. |
Updated according to comments received from sdardis and also rebased to work with TOT.
LGTM with the highlighted nits addressed.
lib/Target/Mips/MicroMips32r6InstrInfo.td | ||
---|---|---|
633–635 | Formatting should be like: class LDWC1_DESC_BASE<string opstr, RegisterOperand RC, InstrItinClass Itin, SDPatternOperator OpNode = null_frag> : MipsR6Inst, HARDFLOAT { You can start a newline in the parameter list. | |
651–653 | The formatting should be like: class COP2LD_MMR6_DESC_BASE<string opstr, RegisterOperand COPOpnd, InstrItinClass Itin, SDPatternOperator OpNode = null_frag> { | |
test/MC/Mips/micromips32r6/valid.s | ||
42–45 | Line up the "# encoding: .." with the others. | |
58–59 | And here. | |
test/MC/Mips/mips32r5/invalid.s | ||
15 | Line up this check line with the rest. The top one is ok. | |
test/MC/Mips/mips64r5/invalid.s | ||
24 | Same again here. | |
test/MC/Mips/mips64r6/invalid.s | ||
12–16 | Restore the jalr.hb lines and submit that as a separate NFC change. | |
39–42 | Submit this as a separate change. |
Formatting should be like:
You can start a newline in the parameter list.