This is an archive of the discontinued LLVM Phabricator instance.

[PPC] Enable transformations in PPCPassConfig::addIRPasses at O2.
ClosedPublic

Authored by amehsan on Mar 29 2016, 10:25 AM.

Details

Summary

I am going to submit this patch right away, as it is discussed with Hal in detail. However I post this review, just to make sure it has enough visibility if anybody has any concern.
The motivation for this change is https://llvm.org/bugs/show_bug.cgi?id=25581

Diff Detail

Event Timeline

amehsan updated this revision to Diff 51943.Mar 29 2016, 10:25 AM
amehsan retitled this revision from to [PPC] Enable transformations in PPCPassConfig::addIRPasses at O2..
amehsan updated this object.
amehsan updated this object.

Just realized there are 29 regressions caused by this patch. I will go through them, and update the code review.

amehsan updated this revision to Diff 52245.Mar 31 2016, 11:21 AM

As I go through failing testcases and update them, I post them here.

Looks good to me when you fix all the testcases up.

Thanks!

Thanks Eric. Working on that :)

amehsan updated this revision to Diff 52439.Apr 1 2016, 3:59 PM
amehsan updated this revision to Diff 52573.Apr 4 2016, 9:56 AM
amehsan updated this revision to Diff 52783.Apr 6 2016, 6:22 AM

removed one testcase (after discussing it with Hal Finkel) because the testcase does not anymore serve the intended purpose. Even before my changes, when I do the code change that was committed with this test, the test still passes. One test shows that we are possibly missing some optimization opportunity now. At this point, this is for a VMX vector load and store, which is not really something that we care about. But I will open a bugzilla item to have it documented.

for missing opportunity in test/CodeGen/PowerPC/unal-altivec.ll
https://llvm.org/bugs/show_bug.cgi?id=27242

hfinkel accepted this revision.Apr 6 2016, 7:20 AM
hfinkel edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Apr 6 2016, 7:20 AM

committed r265683.

Updated release notes under r265694.

amehsan closed this revision.Apr 7 2016, 9:53 AM
test/CodeGen/PowerPC/subreg-postra.ll