I am going to submit this patch right away, as it is discussed with Hal in detail. However I post this review, just to make sure it has enough visibility if anybody has any concern.
The motivation for this change is https://llvm.org/bugs/show_bug.cgi?id=25581
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Just realized there are 29 regressions caused by this patch. I will go through them, and update the code review.
Comment Actions
removed one testcase (after discussing it with Hal Finkel) because the testcase does not anymore serve the intended purpose. Even before my changes, when I do the code change that was committed with this test, the test still passes. One test shows that we are possibly missing some optimization opportunity now. At this point, this is for a VMX vector load and store, which is not really something that we care about. But I will open a bugzilla item to have it documented.
Comment Actions
for missing opportunity in test/CodeGen/PowerPC/unal-altivec.ll
https://llvm.org/bugs/show_bug.cgi?id=27242