Adds support for BEQL and BNEL macros with immediate operands.
Patch by: Srdjan Obucina
Differential D17040
[mips] Expansion of BEQL and BNEL with immediate operands sdardis on Feb 9 2016, 1:54 PM. Authored by
Details Adds support for BEQL and BNEL macros with immediate operands. Patch by: Srdjan Obucina
Diff Detail Event TimelineComment Actions Overall this looks good to me. However, we'll have to add a few more tests before committing this. You can take a look at r239905 in order to get an idea of what we need to change: test/MC/Mips/branch-pseudos-bad.s Comment Actions Can You please be more precise what exactly You are expecting to be changed? branch-pseudo.s is a set of tests for branch instructions with register operands. I guess You think we need tests for global labels? branch-pseudo-bad.s also covers branch instructions with register operands. I guess You want to test for AT reg availability here? set-nomacro.s covers branch instructions, but not branch likely instructions? Do You want to add these two instructions here? For the sake of completeness, what about other branch likely instructions? Just be more precise, please... Comment Actions This patch has aged a bit and doesn't apply cleanly to trunk any longer. Can this be refreshed to a more recent trunk? |