Page MenuHomePhabricator

Adding doxygen comments to the LLVM intrinsics (part 4, pmmintrin.h)
ClosedPublic

Authored by kromanova on Feb 4 2016, 5:59 PM.

Details

Summary

Hello,

Here is the patch with the doxygen comments for the intrinsincs in the header file pmmintrin.h.
The doxygen comments are automatically generated based on SCE internal intrinsics document using DCG tool that I wrote.

I will submit more doxygen comments for the other intrinsic header files as soon as this patch is approved.

Here is the link to the general discussion about adding comments to x86 intrinsics headers.
http://permalink.gmane.org/gmane.comp.compilers.clang.devel/42032

Here are the links to the similar code reviews for the doxygen comments other header files.

http://reviews.llvm.org/D8762 (closed)
http://reviews.llvm.org/D15999 (closed)
http://reviews.llvm.org/D16562 (closed)

Katya.

Diff Detail

Repository
rL LLVM

Event Timeline

kromanova updated this revision to Diff 46988.Feb 4 2016, 5:59 PM
kromanova retitled this revision from to Adding doxygen comments to the LLVM intrinsics (part 4, pmmintrin.h).
kromanova updated this object.
kromanova set the repository for this revision to rL LLVM.
kromanova added a subscriber: cfe-commits.
echristo edited edge metadata.Feb 4 2016, 6:47 PM
echristo added a subscriber: echristo.

(Without looking)

Please go ahead and feel free to commit any documentation to the intrinsic
files. :)

Thank you!
Paul Robinson did a very detailed code review yesterday, so I suspect that this doxygen comment patch is of very good quality. ☺
Katya.

From: Eric Christopher [mailto:echristo@gmail.com]
Sent: Thursday, February 04, 2016 6:47 PM
To: reviews+D16913+public+13cb39057c4259cd@reviews.llvm.org; Romanova, Katya; Gao, Yunzhong; jonathan@codesourcery.com; gribozavr@gmail.com; craig.topper@gmail.com; Robinson, Paul
Cc: cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D16913: Adding doxygen comments to the LLVM intrinsics (part 4, pmmintrin.h)

(Without looking)

Please go ahead and feel free to commit any documentation to the intrinsic files. :)

:)

We can look at them/deal with them in post-commit review from here on out.
No need to block on me.

-eric

This revision was automatically updated to reflect the committed changes.