- User Since
- May 9 2013, 11:11 AM (489 w, 3 d)
Jun 19 2020
Jun 18 2020
Jun 10 2020
May 29 2020
Updated the patch to use iterators instead of pointers.
No need to review since Mehdi looked and approved already.
Instead of storing pointers in the vector as you suggested, I think it will be better to store iterators. See the code snippet below.
This approach better fits C++ style. For example, this will guarantee that if operator -> for type pointer to MapEntryTy will be overloaded, it will not affect the logic of the code.
What do you think? If you agree, I will submit a new revision with these changes.
I accidentally deleted a couple of important lines in previous patch. Please ignore it and look at the latest patch only.
Updated the code to fix code review comments.
May 19 2020
May 12 2020
Oct 16 2019
May 24 2018
May 22 2018
Good catch, thank you Craig! Did you know that you can reduce LLVM IR better than Delta? :)
Delta reduced the testcase quite well, but failed to remove this function.
May 21 2018
Mar 30 2018
Fixed code review comments from Steven Wu.
Mar 29 2018
Mar 1 2018
Feb 27 2018
Updated this patch to address Steven Wu's comments:
Feb 15 2018
Peter suggested that someone from Apple should have a look. I added Steven Wu as a reviewer.
Steven, could you (or someone else responsible for ld64 or ThinLTO) review and approve?
kromanova committed r325303: Allow 0 to be a valid value pruning interval in C LTO API.
Doug Yung (the reviewer for this patch) noticed that some lines exceed 80 characters limitation. I fixed that.
Feb 12 2018
Teresa said that Peter Collingbourne might be the code owner for C LTO API, so I'm including him as a reviewer for this code review as well. This review was sitting for a while. Peter, could you please have a look and approve if everything looks OK to you.
Teresa said that Peter Collingbourne might be the code owner for C LTO API, so I'm including him as a reviewer. This patch was sitting for a while. Peter, could you please have a look and approve if everything looks OK to you.
Feb 6 2018
Great! Teresa, please let me know if it's OK to commit or if you want me to change something in this patch.
I got an OK from Steven Wu, Apple's ThinLTO/ld64 developer.
I am definitely not against the change. It would be good to have the number means the same thing in C/C++ API. I think ld64 can be updated in advance before we release 7.0 so we can have a larger compatibility window so I don't think this should be a blocker.
Adding Apple's developers to the list of subscribers, since this patch is related to C LTO API .
Please let me know if more changes needed to this patch.
Feb 1 2018
We have a request for this feature in clang-format in Sony.
Jan 31 2018
Addressed code review comments.
Jan 29 2018
Will it possible to review this patch also? Thank you so much in advance.
Does someone knows who in Apple is responsible for ThinLTO? It might be helpful to add this person as a reviewer.
Will it possible to review this patch? Thank you so much in advance.
Jan 23 2018
Jan 19 2018
Jan 18 2018
Jan 9 2018
Jan 8 2018
Jan 5 2018
Jan 4 2018
Jan 3 2018
Dec 21 2017
Dec 19 2017
Dec 15 2017
Sep 20 2017
Thank you for the review, David! I have changed debug line version to V4, when DWARF V5 is requested (this is just a temporary measure until debug line V5 is supported).
Sep 18 2017
Jul 24 2017
This was for information purpose only (by Sean Silva's request) and no review was needed. All doxygen comments for x86 intrinsic had already landed, so I am abandoning this review.
Jul 12 2017
Jun 6 2017
May 16 2017
May 14 2017
Apr 28 2017
Apr 18 2017
Mar 21 2017
Feb 16 2017
Jan 31 2017
Jan 12 2017
Jan 11 2017
Changed the instruction name from VMOVSD to VMOVQ for _mm_loadu_si64
Jan 9 2017
Dec 27 2016
Dec 26 2016
Dec 23 2016
Dec 15 2016
I have committed this patch today r285355 and have to revert it shortly in r285362, because some tests were failing.