Page MenuHomePhabricator

kromanova (Katya Romanova)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2013, 11:11 AM (336 w, 2 d)

Recent Activity

Wed, Oct 16

kromanova committed rL375037: Request access for Ekaterina Romanova.
Request access for Ekaterina Romanova
Wed, Oct 16, 1:00 PM

May 24 2018

kromanova committed rL333167: Added a testcase for PR31593. A patch (r291535) that fixed this bug didn't have….
Added a testcase for PR31593. A patch (r291535) that fixed this bug didn't have…
May 24 2018, 1:50 AM
kromanova closed D47129: Testcase for PR31593.
May 24 2018, 1:50 AM

May 22 2018

kromanova committed rC333065: [DOXYGEN] Formatting changes for better intrinsics documentation rendering.
[DOXYGEN] Formatting changes for better intrinsics documentation rendering
May 22 2018, 11:37 PM
kromanova committed rL333065: [DOXYGEN] Formatting changes for better intrinsics documentation rendering.
[DOXYGEN] Formatting changes for better intrinsics documentation rendering
May 22 2018, 11:37 PM
kromanova updated the diff for D47129: Testcase for PR31593.

Good catch, thank you Craig! Did you know that you can reduce LLVM IR better than Delta? :)
Delta reduced the testcase quite well, but failed to remove this function.

May 22 2018, 2:36 PM

May 21 2018

kromanova updated the summary of D47175: [DOXYGEN] Formatting changes for better intrinsics documentation rendering.
May 21 2018, 7:53 PM
kromanova created D47175: [DOXYGEN] Formatting changes for better intrinsics documentation rendering.
May 21 2018, 6:41 PM
kromanova updated the summary of D47129: Testcase for PR31593.
May 21 2018, 1:56 AM
kromanova updated the summary of D47129: Testcase for PR31593.
May 21 2018, 1:54 AM
kromanova created D47129: Testcase for PR31593.
May 21 2018, 1:45 AM

Mar 30 2018

kromanova committed rL328904: Prevent data races in concurrent ThinLTO processes..
Prevent data races in concurrent ThinLTO processes.
Mar 30 2018, 2:38 PM
kromanova closed D45076: Prevent data races in concurrent ThinLTO processes.
Mar 30 2018, 2:38 PM
kromanova added inline comments to D45076: Prevent data races in concurrent ThinLTO processes.
Mar 30 2018, 1:43 PM
kromanova updated the diff for D45076: Prevent data races in concurrent ThinLTO processes.

Fixed code review comments from Steven Wu.

Mar 30 2018, 1:43 PM

Mar 29 2018

kromanova created D45076: Prevent data races in concurrent ThinLTO processes.
Mar 29 2018, 7:11 PM

Mar 1 2018

kromanova committed rL326537: [ThinLTO] Added a couple of C LTO API interfaces to control the cache policy..
[ThinLTO] Added a couple of C LTO API interfaces to control the cache policy.
Mar 1 2018, 7:53 PM
kromanova closed D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..
Mar 1 2018, 7:53 PM

Feb 27 2018

kromanova updated the diff for D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..

Updated this patch to address Steven Wu's comments:

Feb 27 2018, 7:41 PM

Feb 15 2018

kromanova added a reviewer for D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size.: steven_wu.

Peter suggested that someone from Apple should have a look. I added Steven Wu as a reviewer.
Steven, could you (or someone else responsible for ld64 or ThinLTO) review and approve?

Feb 15 2018, 7:45 PM
kromanova closed D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API..

kromanova committed r325303: Allow 0 to be a valid value pruning interval in C LTO API.

Feb 15 2018, 7:38 PM
kromanova committed rL325312: [DOXYGEN] There was a request in the review D41507 to change the notation for….
[DOXYGEN] There was a request in the review D41507 to change the notation for…
Feb 15 2018, 7:13 PM
kromanova committed rC325312: [DOXYGEN] There was a request in the review D41507 to change the notation for….
[DOXYGEN] There was a request in the review D41507 to change the notation for…
Feb 15 2018, 7:13 PM
kromanova closed D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h.
Feb 15 2018, 7:13 PM
kromanova updated the diff for D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h.

Doug Yung (the reviewer for this patch) noticed that some lines exceed 80 characters limitation. I fixed that.

Feb 15 2018, 5:45 PM
kromanova added a reviewer for D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h: dyung.
Feb 15 2018, 5:20 PM
kromanova committed rL325303: Allow 0 to be a valid value pruning interval in C LTO API. Value 0 will cause….
Allow 0 to be a valid value pruning interval in C LTO API. Value 0 will cause…
Feb 15 2018, 3:32 PM

Feb 12 2018

kromanova added a reviewer for D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size.: pcc.

Teresa said that Peter Collingbourne might be the code owner for C LTO API, so I'm including him as a reviewer for this code review as well. This review was sitting for a while. Peter, could you please have a look and approve if everything looks OK to you.

Feb 12 2018, 2:19 PM
kromanova added a reviewer for D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API.: pcc.

Teresa said that Peter Collingbourne might be the code owner for C LTO API, so I'm including him as a reviewer. This patch was sitting for a while. Peter, could you please have a look and approve if everything looks OK to you.

Feb 12 2018, 2:16 PM

Feb 6 2018

kromanova added a comment to D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API..

Great! Teresa, please let me know if it's OK to commit or if you want me to change something in this patch.
I got an OK from Steven Wu, Apple's ThinLTO/ld64 developer.

Feb 6 2018, 4:58 PM
kromanova added a comment to D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API..

I am definitely not against the change. It would be good to have the number means the same thing in C/C++ API. I think ld64 can be updated in advance before we release 7.0 so we can have a larger compatibility window so I don't think this should be a blocker.

Feb 6 2018, 3:52 PM
kromanova updated subscribers of D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..

Adding Apple's developers to the list of subscribers, since this patch is related to C LTO API .

Feb 6 2018, 3:28 PM
kromanova added a comment to D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API..

This indeed affects how ld64 interact with libLTO. If user didn't specify a value, ld64 will always call thinlto_codegen_set_cache_pruning_interval with interval 0. This is currently a no-op so it will use whatever the default value in libLTO. With this change, it will be force pruning.

It is possible for us to make change to future ld64 to use different value but it is not going work very well for compatibility. If old ld64 loaded a new libLTO, it is going to lose incremental build.

Feb 6 2018, 3:23 PM
kromanova added a comment to D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..

Please let me know if more changes needed to this patch.

Feb 6 2018, 1:04 PM
kromanova added a comment to D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API..

It looks ok to me, but I am not sure how ld64 is using this - are they also setting to 0 by default expecting default behavior?

Feb 6 2018, 12:54 PM

Feb 1 2018

kromanova updated subscribers of D28462: clang-format: Add new style option AlignConsecutiveMacros.

We have a request for this feature in clang-format in Sony.

Feb 1 2018, 4:39 PM · Restricted Project, Restricted Project

Jan 31 2018

kromanova planned changes to D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..
Jan 31 2018, 2:57 AM
kromanova added inline comments to D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..
Jan 31 2018, 2:50 AM
kromanova updated the diff for D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..

Addressed code review comments.

Jan 31 2018, 2:47 AM

Jan 29 2018

kromanova added a comment to D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..

Hello,
Will it possible to review this patch also? Thank you so much in advance.
Does someone knows who in Apple is responsible for ThinLTO? It might be helpful to add this person as a reviewer.
Katya.

Jan 29 2018, 2:31 PM
kromanova added a comment to D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API..

Hello,
Will it possible to review this patch? Thank you so much in advance.
Katya.

Jan 29 2018, 2:30 PM

Jan 23 2018

kromanova created D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size..
Jan 23 2018, 3:05 PM

Jan 19 2018

kromanova added inline comments to D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API..
Jan 19 2018, 1:16 PM

Jan 18 2018

kromanova created D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API..
Jan 18 2018, 3:40 PM

Jan 9 2018

kromanova updated subscribers of D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h.
Jan 9 2018, 3:49 PM
kromanova created D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h.
Jan 9 2018, 3:48 PM

Jan 8 2018

kromanova added a comment to D41523: xmmintrin.h documentation fixes and updates.

The builtins are tested in tests like test/CodeGen/sse-builtins.c,

Jan 8 2018, 11:53 PM
kromanova added inline comments to D41516: emmintrin.h documentation fixes and updates.
Jan 8 2018, 8:04 PM
kromanova added inline comments to D41516: emmintrin.h documentation fixes and updates.
Jan 8 2018, 6:35 PM
kromanova accepted D41507: avxintrin.h documentation fixes and updates.

LGTM too.

Jan 8 2018, 12:25 PM

Jan 5 2018

kromanova added a comment to D41523: xmmintrin.h documentation fixes and updates.

Sort of related - should we enable -Wdocumentation (it's currently -Wall and -Weverything might be too much....) on the respective clang builtin tests? Doesn't have to be part of this patch.

Jan 5 2018, 1:38 PM

Jan 4 2018

kromanova added inline comments to D41516: emmintrin.h documentation fixes and updates.
Jan 4 2018, 8:12 PM
kromanova added inline comments to D41523: xmmintrin.h documentation fixes and updates.
Jan 4 2018, 7:29 PM
kromanova added inline comments to D41517: mmintrin.h documentation fixes and updates.
Jan 4 2018, 6:43 PM

Jan 3 2018

kromanova added inline comments to D41517: mmintrin.h documentation fixes and updates.
Jan 3 2018, 5:30 PM

Dec 21 2017

kromanova added a reviewer for D41507: avxintrin.h documentation fixes and updates: kromanova.
Dec 21 2017, 5:11 PM
kromanova added inline comments to D41507: avxintrin.h documentation fixes and updates.
Dec 21 2017, 5:10 PM

Dec 19 2017

kromanova added inline comments to D41231: [Support][CachePruning] Fix regression that prevents disabling of pruning.
Dec 19 2017, 3:46 AM
kromanova added inline comments to D41231: [Support][CachePruning] Fix regression that prevents disabling of pruning.
Dec 19 2017, 3:14 AM

Dec 15 2017

kromanova added inline comments to D41279: [ThinLTO][C-API] Correct api comments.
Dec 15 2017, 11:36 PM
kromanova added inline comments to D41279: [ThinLTO][C-API] Correct api comments.
Dec 15 2017, 3:42 PM
kromanova accepted D41279: [ThinLTO][C-API] Correct api comments.
Dec 15 2017, 3:24 PM
kromanova added a reviewer for D41279: [ThinLTO][C-API] Correct api comments: kromanova.
Dec 15 2017, 2:58 PM

Sep 20 2017

kromanova updated the diff for D38002: Re-submit r289925 (Update .debug_line section version to match DWARF version).

Thank you for the review, David! I have changed debug line version to V4, when DWARF V5 is requested (this is just a temporary measure until debug line V5 is supported).

Sep 20 2017, 1:01 PM · debug-info

Sep 18 2017

kromanova created D38002: Re-submit r289925 (Update .debug_line section version to match DWARF version).
Sep 18 2017, 3:17 PM · debug-info

Jul 24 2017

kromanova abandoned D16442: Set of all x86 intrinsic header files with generated doxygen comments (as per Sean Silva request)..

This was for information purpose only (by Sean Silva's request) and no review was needed. All doxygen comments for x86 intrinsic had already landed, so I am abandoning this review.

Jul 24 2017, 4:12 PM

Jul 12 2017

kromanova committed rL307838: [DOXYGEN] Corrected typos and incorrect parameters description..
[DOXYGEN] Corrected typos and incorrect parameters description.
Jul 12 2017, 1:19 PM

Jun 6 2017

kromanova committed rL304840: [DOXYGEN] Corrected several typos and incorrect parameters description that….
[DOXYGEN] Corrected several typos and incorrect parameters description that…
Jun 6 2017, 3:58 PM

May 16 2017

kromanova committed rL303228: (1) Fixed mismatch in intrinsics names in declarations and in doxygen comments..
(1) Fixed mismatch in intrinsics names in declarations and in doxygen comments.
May 16 2017, 6:59 PM

May 14 2017

kromanova committed rL303031: [DOXYGEN] Minor improvements in doxygen comments..
[DOXYGEN] Minor improvements in doxygen comments.
May 14 2017, 8:38 PM

Apr 28 2017

kromanova committed rL301652: [DOXYGEN] Minor improvements in doxygen comments..
[DOXYGEN] Minor improvements in doxygen comments.
Apr 28 2017, 9:58 AM

Apr 18 2017

kromanova committed rL300578: [DOXYGEN] Minor improvements in doxygen comments..
[DOXYGEN] Minor improvements in doxygen comments.
Apr 18 2017, 12:57 PM

Mar 21 2017

kromanova committed rL298371: [DOXYGEN] Improvements to smmintrin.h and emmintrin.h intrinsics..
[DOXYGEN] Improvements to smmintrin.h and emmintrin.h intrinsics.
Mar 21 2017, 6:46 AM

Feb 16 2017

kromanova committed rL295404: Added doxygen comments to smmintrin.h's intrinsics..
Added doxygen comments to smmintrin.h's intrinsics.
Feb 16 2017, 7:01 PM

Jan 31 2017

kromanova committed rL293745: Doxygen comments for prfchwintrin.h.
Doxygen comments for prfchwintrin.h
Jan 31 2017, 11:49 PM

Jan 12 2017

kromanova committed rL291876: [DOXYGEN] Documentation for the newly added x86 intrinsics..
[DOXYGEN] Documentation for the newly added x86 intrinsics.
Jan 12 2017, 5:25 PM
kromanova closed D28503: Documentation for the newly added x86 intrinsics. by committing rL291876: [DOXYGEN] Documentation for the newly added x86 intrinsics..
Jan 12 2017, 5:25 PM

Jan 11 2017

kromanova updated the diff for D28503: Documentation for the newly added x86 intrinsics..

Changed the instruction name from VMOVSD to VMOVQ for _mm_loadu_si64

Jan 11 2017, 3:20 PM
kromanova added inline comments to D28503: Documentation for the newly added x86 intrinsics..
Jan 11 2017, 3:11 PM
kromanova added inline comments to D28503: Documentation for the newly added x86 intrinsics..
Jan 11 2017, 3:01 PM

Jan 9 2017

kromanova retitled D28503: Documentation for the newly added x86 intrinsics. from to Documentation for the newly added x86 intrinsics..
Jan 9 2017, 4:53 PM

Dec 27 2016

kromanova committed rL290619: [DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics..
[DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics.
Dec 27 2016, 11:04 AM

Dec 26 2016

kromanova committed rL290561: [DOXYGEN] Improved doxygen comments for x86 intrinsics..
[DOXYGEN] Improved doxygen comments for x86 intrinsics.
Dec 26 2016, 5:00 PM

Dec 23 2016

kromanova committed rL290458: [DOXYGEN] Improved doxygen comments for tmmintrin.h intrinsics..
[DOXYGEN] Improved doxygen comments for tmmintrin.h intrinsics.
Dec 23 2016, 3:47 PM
kromanova committed rL290455: [DOXYGEN] Improved doxygen comments for tmmintrin.h intrinsics..
[DOXYGEN] Improved doxygen comments for tmmintrin.h intrinsics.
Dec 23 2016, 2:58 PM

Dec 15 2016

kromanova committed rL289925: Update .debug_line section version information to match DWARF version..
Update .debug_line section version information to match DWARF version.
Dec 15 2016, 9:20 PM
kromanova closed D16697: Updating .debug_line section version information to match DWARF version. by committing rL289925: Update .debug_line section version information to match DWARF version..
Dec 15 2016, 9:20 PM
kromanova updated the diff for D16697: Updating .debug_line section version information to match DWARF version..

I have committed this patch today r285355 and have to revert it shortly in r285362, because some tests were failing.

Dec 15 2016, 10:40 AM

Dec 9 2016

kromanova committed rL289249: [DOXYGEN] Improved doxygen comments for x86 intrinsics headers..
[DOXYGEN] Improved doxygen comments for x86 intrinsics headers.
Dec 9 2016, 10:46 AM
kromanova committed rL289159: [DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics..
[DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics.
Dec 9 2016, 4:02 AM
kromanova committed rL289154: [DOXYGEN] Improved doxygen comments..
[DOXYGEN] Improved doxygen comments.
Dec 9 2016, 4:02 AM

Dec 8 2016

kromanova committed rL289116: [DOXYGEN] Improved doxygen comments for emmintrin.h intrinsics..
[DOXYGEN] Improved doxygen comments for emmintrin.h intrinsics.
Dec 8 2016, 2:21 PM
kromanova committed rL289083: [DOXYGEN] Improved doxygen comments..
[DOXYGEN] Improved doxygen comments.
Dec 8 2016, 10:07 AM

Dec 7 2016

kromanova committed rL289022: [DOXYGEN] Improved doxygen comments for avxintrin.h intrinsics..
[DOXYGEN] Improved doxygen comments for avxintrin.h intrinsics.
Dec 7 2016, 8:19 PM

Nov 26 2016

kromanova committed rL287990: [DOXYGEN] Updated instruction names corresponding to avxintrin.h intrinsics..
[DOXYGEN] Updated instruction names corresponding to avxintrin.h intrinsics.
Nov 26 2016, 11:48 AM

Nov 20 2016

kromanova committed rL287483: Add doxygen comments to immintrin.h's intrinsics..
Add doxygen comments to immintrin.h's intrinsics.
Nov 20 2016, 12:44 AM

Nov 18 2016

kromanova committed rL287436: Doxygen comments for avxintrin.h..
Doxygen comments for avxintrin.h.
Nov 18 2016, 9:09 PM

Nov 17 2016

kromanova committed rL287317: Add doxygen comments for lzcntintrin.h's intrinsics..
Add doxygen comments for lzcntintrin.h's intrinsics.
Nov 17 2016, 10:35 PM
kromanova committed rL287295: Add doxygen comments to fxsrintrin.h's intrinsics..
Add doxygen comments to fxsrintrin.h's intrinsics.
Nov 17 2016, 5:51 PM
kromanova committed rL287278: Minor changes in x86 intrinsics headers; NFC.
Minor changes in x86 intrinsics headers; NFC
Nov 17 2016, 3:11 PM