Related to http://reviews.llvm.org/D15772
Depends on http://reviews.llvm.org/D16888
Adds support for immediate operand for [D]DIV[U] instructions.
Paths
| Differential D16889
[mips] Addition of the immediate cases for the instructions [d]div, [d]divu ClosedPublic Authored by sdardis on Feb 4 2016, 8:25 AM.
Details Summary Related to http://reviews.llvm.org/D15772 Depends on http://reviews.llvm.org/D16888 Adds support for immediate operand for [D]DIV[U] instructions.
Diff Detail Event TimelineComment Actions It looks like this patch also contains D16888. Could you reduce it to just the changes for this patch? obucina edited edge metadata. Comment ActionsPatch reduced to contain only changes for adding immediate operand for DIV macro. dsanders edited edge metadata. Comment ActionsLGTM with a couple small changes
This revision is now accepted and ready to land.Mar 11 2016, 6:09 AM obucina edited edge metadata. Comment ActionsAdding 64bit constants to test cases.
Eugene.Zelenko added a parent revision: D16888: [mips] Addition of a third operand to the instructions [d]div, [d]divu
.Sep 26 2016, 2:10 PM Closed by commit rL293614: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu (authored by sdardis). · Explain WhyJan 31 2017, 3:00 AM This revision was automatically updated to reflect the committed changes. sdardis marked an inline comment as done.
Revision Contents
Diff 46924 lib/Target/Mips/AsmParser/MipsAsmParser.cpp
lib/Target/Mips/MipsInstrInfo.td
test/MC/Mips/macro-ddiv.s
test/MC/Mips/macro-ddivu.s
test/MC/Mips/macro-div.s
test/MC/Mips/macro-divu.s
|
I believe this simm16 should be simm32. It currently works because I haven't added range checking to simm16 yet.
Similarly for the other 32-bit divides below.