This is an archive of the discontinued LLVM Phabricator instance.

Differential D16845

[TSan] Fix PrintMatchedSuppressions: Read hit count for suppression atomically
ClosedPublic

Authored by mohit.bhakkad on Feb 3 2016, 1:07 AM.

Download Raw Diff

Details

Reviewers

kcc
dvyukov
samsonov

Commits

rG770bbbc05bca: Merging r259755: --------------------------------------------------------------…
rG4199f3df29e5: [TSan] Fix PrintMatchedSuppressions: Read hit count for suppression atomically
rCRT259755: [TSan] Fix PrintMatchedSuppressions: Read hit count for suppression atomically
rL259755: [TSan] Fix PrintMatchedSuppressions: Read hit count for suppression atomically

Diff Detail

Repository: rL LLVM

Event Timeline

mohit.bhakkad updated this revision to Diff 46754.Feb 3 2016, 1:07 AM

mohit.bhakkad retitled this revision from to [TSan] Fix PrintMatchedSuppressions: Read hit count for suppression atomically.

mohit.bhakkad updated this object.

mohit.bhakkad added reviewers: dvyukov, kcc, samsonov.

mohit.bhakkad set the repository for this revision to rL LLVM.

mohit.bhakkad added subscribers: jaydeep, slthakur, dsanders.

dvyukov added inline comments.Feb 3 2016, 3:13 AM

lib/tsan/rtl/tsan_suppressions.cc
161–162	This is longer than 80 symbols. "ninja check-tsan" should point to it.

Fixed indentation

dvyukov accepted this revision.Feb 3 2016, 3:47 AM

dvyukov edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2016, 3:47 AM

mohit.bhakkad edited edge metadata.Feb 3 2016, 9:31 PM

mohit.bhakkad added a subscriber: llvm-commits.

Closed by commit rL259755: [TSan] Fix PrintMatchedSuppressions: Read hit count for suppression atomically (authored by mohit.bhakkad). · Explain WhyFeb 3 2016, 9:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

tsan/

rtl/

tsan_suppressions.cc

4 lines

Diff 46761

lib/tsan/rtl/tsan_suppressions.cc

	Show First 20 Lines • Show All 152 Lines • ▼ Show 20 Lines		void PrintMatchedSuppressions() {
	suppression_ctx->GetMatched(&matched);			suppression_ctx->GetMatched(&matched);
	if (!matched.size())			if (!matched.size())
	return;			return;
	int hit_count = 0;			int hit_count = 0;
	for (uptr i = 0; i < matched.size(); i++)			for (uptr i = 0; i < matched.size(); i++)
	hit_count += atomic_load_relaxed(&matched[i]->hit_count);			hit_count += atomic_load_relaxed(&matched[i]->hit_count);
	Printf("ThreadSanitizer: Matched %d suppressions (pid=%d):\n", hit_count,			Printf("ThreadSanitizer: Matched %d suppressions (pid=%d):\n", hit_count,
	(int)internal_getpid());			(int)internal_getpid());
	for (uptr i = 0; i < matched.size(); i++) {			for (uptr i = 0; i < matched.size(); i++) {
	Printf("%d %s:%s\n", matched[i]->hit_count, matched[i]->type,			Printf("%d %s:%s\n", atomic_load_relaxed(&matched[i]->hit_count),
				dvyukovUnsubmitted Not Done Reply Inline Actions This is longer than 80 symbols. "ninja check-tsan" should point to it. dvyukov: This is longer than 80 symbols. "ninja check-tsan" should point to it.
	matched[i]->templ);			matched[i]->type, matched[i]->templ);
	}			}
	}			}
	} // namespace __tsan			} // namespace __tsan