Page MenuHomePhabricator

[cc1as] Add MCTargetOptions argument to createAsmBackend
ClosedPublic

Authored by joelkevinjones on Jan 25 2016, 9:08 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

joelkevinjones retitled this revision from to [cc1as] Add MCTargetOptions argument to createAsmBackend.
joelkevinjones updated this object.
joelkevinjones added reviewers: dsanders, echristo.
joelkevinjones added a subscriber: cfe-commits.
echristo edited edge metadata.Jan 27 2016, 2:22 PM

Hi Joel,

Since you're likely going to need to start filling in the Options there anyhow, can you lift the one from the TODO and start filling it in?

-eric

Did you mean remove the duplication from addPassesToEmitFile mentioned in the FIXME or something else?

Ping.

The FIXME at cc1as_main.cpp:413

The FIXME comment doesn't make sense to me. I'm not sure what sanitizer arguments would be passed to the assembler.

dsanders edited edge metadata.Mar 11 2016, 6:24 AM
dsanders added subscribers: eugenis, ygorshenin.

I think it refers to MCTargetOptions::SanitizeAddress but I don't know where we'd get that information from. Unfortunately, it seems that the original author (@ygorshenin) might not be on the list anymore (phabricator shows no activity since 2014) but we can ask Evgeniy.

tools/driver/cc1as_main.cpp
413–416 ↗(On Diff #45872)

@eugenis: Do you know what needs to be done for this FIXME?

eugenis added inline comments.Mar 11 2016, 11:31 AM
tools/driver/cc1as_main.cpp
413–416 ↗(On Diff #45872)

I think this is about allowing -fsanitize=address as a cc1as flag to enable asan instrumentation in standalone assembly files. Currently it is only supported in inline assembly.

joelkevinjones edited edge metadata.

Updated to ToT. Passes "make check-clang"

Ping. This change needs to be made once D16213 goes in.

This revision was automatically updated to reflect the committed changes.