Page MenuHomePhabricator

joelkevinjones (Joel Jones)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 14 2016, 8:08 AM (174 w, 6 d)

Recent Activity

Apr 11 2019

joelkevinjones added a comment to D32530: [SVE][IR] Scalable Vector IR Type.

I think this is a coherent set of changes. Given the current top of trunk, this expands support from just assembly/disassembly of machine instructions to include LLVM IR, right? Such being the case, I think this patch should go in. I have some ideas on how to structure passes so SV IR supporting optimizations can be added incrementally. If anyone thinks such a proposal would, let me know.

Apr 11 2019, 7:20 PM

Feb 27 2019

joelkevinjones added a comment to D53927: [AArch64] Enable libm vectorized functions via SLEEF.

I'm not sure what the proposed split would consist of. Would it be

  • A patch consisting of only the changes in Intrinsics.td which would be applied first. Wouldn't the changes in SelectionDAG be required as well?
  • Everything but the changes in TargetLibraryInfo.cpp etc. for supporting SLEEF and including any related test cases that would be upstreamed 2nd?

Would the second choice be useful by itself? Either in functionality or improved cross-platform testing before the SLEEF support went in?

Feb 27 2019, 7:21 AM · Restricted Project

Jan 18 2018

joelkevinjones added a comment to D40696: Enable aggressive FMA on T99 and provide AArch64 option for other micro-arch's.

It looks like the latest changes address the earlier concerns expressed in the review comments:

Jan 18 2018, 12:20 PM

Jan 10 2018

joelkevinjones added a comment to D40694: Remove Unsupported flag from T99 Scheduler.

Okay, I'll be sure to add "[AArch64]" when I do the commit.

Jan 10 2018, 11:30 AM

Nov 16 2017

joelkevinjones added a comment to D40075: [test-suite] Fix unix-smail symbol clash with the symbols in libc when linking statically..

Since I don't perceive a requirement that the benchmark source continue to exactly match that of the original, I would prefer just changing the benchmark source to not conflict.

Nov 16 2017, 6:54 AM

Oct 10 2017

joelkevinjones updated subscribers of D35260: [AArch64] Move AES instruction fusion support.
Oct 10 2017, 9:45 AM

Jul 18 2017

joelkevinjones updated the diff for D35058: [docs] Document how to debug instruction scheduling model generation.

Remove assumption that the build directory is a subdirectory of the source directory.

Jul 18 2017, 10:10 AM

Jul 14 2017

joelkevinjones updated the diff for D35058: [docs] Document how to debug instruction scheduling model generation.

Describe distinction between sched model and itinerary vis-a-vis schedcover.py.
Give complete command for llvm-tblgen debug output

Jul 14 2017, 12:00 PM
joelkevinjones added a comment to D35058: [docs] Document how to debug instruction scheduling model generation.

If you know the command, I agree that digging through the verbose make output is unnecessary. I'll give the entire command and make your suggested change vis-a-vis distinguishing itinerary and machine scheduler model.

Jul 14 2017, 8:14 AM

Jul 12 2017

joelkevinjones accepted D34958: [AArch64] Add AArch64Subtarget::isFusion function..

Thanks Stefan. LGTM

Jul 12 2017, 11:59 AM

Jul 6 2017

joelkevinjones accepted D34951: [AArch64] Add test case for preferred function alignment (NFC). .

LGTM

Jul 6 2017, 9:37 AM
joelkevinjones updated the diff for D35058: [docs] Document how to debug instruction scheduling model generation.

Used complete file diff

Jul 6 2017, 8:02 AM
joelkevinjones created D35058: [docs] Document how to debug instruction scheduling model generation.
Jul 6 2017, 7:58 AM

Jul 5 2017

joelkevinjones added a reviewer for D34958: [AArch64] Add AArch64Subtarget::isFusion function.: steleman.

Stefan has been doing the back-end as well.

Jul 5 2017, 9:39 AM

Jun 27 2017

joelkevinjones added inline comments to D34713: [TableGen] Improve Debug Output for --debug-only=subtarget-emitter NFCI.
Jun 27 2017, 5:00 PM
joelkevinjones created D34713: [TableGen] Improve Debug Output for --debug-only=subtarget-emitter NFCI.
Jun 27 2017, 3:37 PM

Jun 26 2017

joelkevinjones requested review of D31801: Performance enhancements for Cavium ThunderX2 T99.

Ping?

Jun 26 2017, 11:44 AM

Jun 22 2017

joelkevinjones accepted D34220: [AArch64] Prefer B.cond to CBZ/CBNZ/TBZ/TBNZ when NZCV flags can be set for "free".

I concur with the analysis for ThunderXT99.

Jun 22 2017, 12:24 PM

Jun 20 2017

joelkevinjones updated the diff for D31801: Performance enhancements for Cavium ThunderX2 T99.

Removed matching on "^SUB" which was inadvertently matching "SUBREG_TO_REG", with resulting failure in test/Codegen/AArch64/machine-combine-madd.ll

Jun 20 2017, 5:35 PM
joelkevinjones commandeered D31801: Performance enhancements for Cavium ThunderX2 T99.

There is an issue with madd not being generated when this revision is applied to ToT. I have a fix that I will upload. It appears I have to commandeer the revision to do this?

Jun 20 2017, 5:15 PM
joelkevinjones added a reviewer for D31801: Performance enhancements for Cavium ThunderX2 T99: joelkevinjones.
Jun 20 2017, 3:37 PM

Jun 6 2017

joelkevinjones added a comment to D33836: [AArch64] Enable FeatureFuseAES for the generic processor model..

I'm okay with this change

Jun 6 2017, 3:42 PM

Jun 2 2017

joelkevinjones added a comment to D33836: [AArch64] Enable FeatureFuseAES for the generic processor model..

I can probably scare up whether this impacts ThunderX processors. What benchmark should I look at? OpenSSL?

Jun 2 2017, 2:57 PM

Apr 30 2017

joelkevinjones updated the diff for D32072: [AArch64] ILP32 Backend Relocation Support.
  • 0x07b is now named R_AARCH64_P32_TLSDESC_ADR_PREL21
  • "#include... Debug " removed
  • Tests for R_AARCH64_P32_TLSLE_LD128_TPREL_LO12 and ...ST..._NC added
  • For R_AARCH64_TLSDESC_ADR_PREL19, documented in summary as definition added, but not implemented.
  • Documented as definitions added, but not implemented: R_AARCH64_P32_TLSGD_ADR_PREL21, R_AARCH64_P32_TLSGD_ADR_PAGE21, R_AARCH64_P32_TLSGD_ADD_LO12_NC
  • I've added tests to arm{64,32}-{elf,tls}-relocs.s. I've added an encoding test for LDST128_ABS_LO12_NC to arm{64,32}-elf-relocs.s instead of where the other encoding tests are, arm{64,32}-tls-relocs.s, as this relocation isn't for TLS.
Apr 30 2017, 9:22 PM

Apr 26 2017

joelkevinjones updated the diff for D32072: [AArch64] ILP32 Backend Relocation Support.

Address comments about missing tests (for those relocations intended to implemented) and about misnamed relocation.

Apr 26 2017, 8:34 AM

Apr 25 2017

joelkevinjones added a comment to D32072: [AArch64] ILP32 Backend Relocation Support.

As noted in the inline comments, there are several relocations with no implementations in LP64 or ILP32. My intent with this patch was towards the goal of ILP32 parity with LP64. I still need to file a defect for the missing functionality.

Apr 25 2017, 2:42 PM

Apr 20 2017

joelkevinjones added a comment to D32072: [AArch64] ILP32 Backend Relocation Support.

Ping

Apr 20 2017, 9:07 AM

Apr 19 2017

joelkevinjones added a comment to D31628: Add Explanation of Mips Backend Relocation Principles.

Ping

Apr 19 2017, 7:14 AM

Apr 18 2017

joelkevinjones created D32169: [AArch64] Refactor instruction selection lowering for addresses. NFCI.
Apr 18 2017, 8:55 AM

Apr 13 2017

joelkevinjones abandoned D29192: [AArch64] Fix incorrect relocation encodings for ILP32.

This revision is included in an omnibus ILP32 relocation change: https://reviews.llvm.org/D32072

Apr 13 2017, 9:06 PM
joelkevinjones abandoned D30473: [AARCH64] Incorrect relocation name TLSDESC_LD64_LO12_NC.

This revision is included in an omnibus ILP32 relocation change: https://reviews.llvm.org/D32072

Apr 13 2017, 9:05 PM
joelkevinjones abandoned D30573: [AARCH64] Add more ILP32 relocation support.

This revision is included in an omnibus ILP32 relocation change: https://reviews.llvm.org/D32072

Apr 13 2017, 9:04 PM
joelkevinjones created D32072: [AArch64] ILP32 Backend Relocation Support.
Apr 13 2017, 9:01 PM

Apr 6 2017

joelkevinjones updated the diff for D31628: Add Explanation of Mips Backend Relocation Principles.

Improve consistency of capitalization of MIPS, types vs. register classes, etc.

Apr 6 2017, 3:21 PM

Apr 4 2017

joelkevinjones updated the diff for D31628: Add Explanation of Mips Backend Relocation Principles.

Updated per comments.

Apr 4 2017, 10:35 AM
joelkevinjones added a comment to D31628: Add Explanation of Mips Backend Relocation Principles.

Thanks for all your comments. I'm about to post a new revision modified per your comments.

Apr 4 2017, 10:33 AM

Apr 3 2017

joelkevinjones created D31628: Add Explanation of Mips Backend Relocation Principles.
Apr 3 2017, 3:02 PM

Mar 3 2017

joelkevinjones created D30573: [AARCH64] Add more ILP32 relocation support.
Mar 3 2017, 7:15 AM

Feb 28 2017

joelkevinjones created D30473: [AARCH64] Incorrect relocation name TLSDESC_LD64_LO12_NC.
Feb 28 2017, 2:22 PM
joelkevinjones added a comment to D29192: [AArch64] Fix incorrect relocation encodings for ILP32.

I haven't abandoned this patch. In working on this one, I've found several issues that I am going to deal with first.

Feb 28 2017, 2:06 PM

Feb 1 2017

joelkevinjones added inline comments to D29192: [AArch64] Fix incorrect relocation encodings for ILP32.
Feb 1 2017, 8:49 AM

Jan 31 2017

joelkevinjones added inline comments to D29192: [AArch64] Fix incorrect relocation encodings for ILP32.
Jan 31 2017, 2:56 PM

Jan 26 2017

joelkevinjones created D29192: [AArch64] Fix incorrect relocation encodings for ILP32.
Jan 26 2017, 11:11 AM

Nov 28 2016

joelkevinjones added inline comments to D26621: [AArch64] Refactor LSE support as feature separate from V8.1a support..
Nov 28 2016, 9:48 AM

Nov 23 2016

joelkevinjones updated the diff for D26621: [AArch64] Refactor LSE support as feature separate from V8.1a support..

Added requested explanation of what LSE is.

Nov 23 2016, 3:17 PM
joelkevinjones added a comment to D26621: [AArch64] Refactor LSE support as feature separate from V8.1a support..

Ping?

Nov 23 2016, 8:59 AM

Nov 14 2016

joelkevinjones updated D26621: [AArch64] Refactor LSE support as feature separate from V8.1a support..
Nov 14 2016, 11:27 AM
joelkevinjones retitled D26621: [AArch64] Refactor LSE support as feature separate from V8.1a support. from to [AArch64] Refactor LSE support as feature separate from V8.1a support..
Nov 14 2016, 11:14 AM

Nov 2 2016

joelkevinjones abandoned D24540: [AArch64] Add Cavium ThunderX subtarget support..

I'm splitting this revision into two parts, One will be to have the target names match those in the GCC proposal (see the gcc-patches mailing list, 1 November 2016, https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00155.html). The other will be a fix to the instruction mapping to scheduling information.

Nov 2 2016, 6:58 AM
joelkevinjones commandeered D24540: [AArch64] Add Cavium ThunderX subtarget support..

I'm in charge of this revision now.

Nov 2 2016, 6:52 AM

Oct 24 2016

joelkevinjones closed D25159: AArch64 ILP32 relocations for assembly and ELF.
Oct 24 2016, 6:46 AM

Oct 21 2016

joelkevinjones updated D25159: AArch64 ILP32 relocations for assembly and ELF.
Oct 21 2016, 12:00 PM

Oct 19 2016

joelkevinjones updated the diff for D25159: AArch64 ILP32 relocations for assembly and ELF.

AArch64 ILP32 relocations for assembly and ELF

Oct 19 2016, 3:19 PM

Oct 18 2016

joelkevinjones added a comment to D25159: AArch64 ILP32 relocations for assembly and ELF.

Ping?

Oct 18 2016, 11:51 AM
joelkevinjones added inline comments to D24540: [AArch64] Add Cavium ThunderX subtarget support..
Oct 18 2016, 9:02 AM
joelkevinjones added inline comments to D24540: [AArch64] Add Cavium ThunderX subtarget support..
Oct 18 2016, 7:08 AM
joelkevinjones added a comment to D24540: [AArch64] Add Cavium ThunderX subtarget support..

We also have some parsing tests to make sure we're not loosing anything, but I agree, the number of relevant tests there is not great.

I think this can be a task for a separate patch.

cheers,
--renato

Oct 18 2016, 6:58 AM

Oct 11 2016

joelkevinjones added a comment to D24540: [AArch64] Add Cavium ThunderX subtarget support..

I'm going to be working on this patch from Ananth. For the AsmParser test, I'm assuming that the file being referred to is: unittests/Support/TargetParserTest.cpp? If so, I have several questions:

  1. What is this testing exactly? It just seems to be repeating the information in include/llvm/Support/AArch64TargetParser.def
  2. Is simply adding "thunderx" to the "CPU" array initialization sufficient?
Oct 11 2016, 10:14 AM
joelkevinjones updated the diff for D25159: AArch64 ILP32 relocations for assembly and ELF.

Add relocations for AArch64 ILP32. Includes:

Oct 11 2016, 8:08 AM

Oct 5 2016

joelkevinjones added a comment to D25159: AArch64 ILP32 relocations for assembly and ELF.

Does anyone have any comments on the code as it is now, i. e.:

  • Relocation names matching standard
  • Correct comment about specification version
  • Use of macros to reduce duplicate code (both "?:" and error strings)
Oct 5 2016, 3:06 PM
joelkevinjones updated the diff for D25159: AArch64 ILP32 relocations for assembly and ELF.

AArch64 ILP32 relocations for assembly and ELF
Add relocations for AArch64 ILP32. Includes:

Oct 5 2016, 10:18 AM

Oct 4 2016

joelkevinjones added a comment to D25159: AArch64 ILP32 relocations for assembly and ELF.

Thanks for your detailed comments. I have made the changes suggested earlier with regard to the proper names (R_AARCH32* -> R_AARCH64_P32). I agree with your comment about the repeated code. A macro that mimics the tables in the specification is probably clearer. I'll try that and see how it goes. I also concur with your comment about the text of the error messages.

Oct 4 2016, 8:57 AM

Oct 3 2016

joelkevinjones added inline comments to D25159: AArch64 ILP32 relocations for assembly and ELF.
Oct 3 2016, 2:13 PM
joelkevinjones added inline comments to D25159: AArch64 ILP32 relocations for assembly and ELF.
Oct 3 2016, 1:20 PM
joelkevinjones added a comment to D25159: AArch64 ILP32 relocations for assembly and ELF.

Thanks for your comments. I'll change the relocation names and change the citation to use the internal revision history name and make a comment about the discrepancy with the cover page.

Oct 3 2016, 7:08 AM

Oct 1 2016

joelkevinjones retitled D25159: AArch64 ILP32 relocations for assembly and ELF from Add relocations for AArch64 ILP32. Includes: - definition of new -target-abi: ilp32 - Addition of definitions for R_AARCH32_* - Defnition of data layout string - tests for added relocations---not comprehensive, but matches existing... to AArch64 ILP32 relocations for assembly and ELF.
Oct 1 2016, 10:35 AM
joelkevinjones retitled D25159: AArch64 ILP32 relocations for assembly and ELF from to Add relocations for AArch64 ILP32. Includes: - definition of new -target-abi: ilp32 - Addition of definitions for R_AARCH32_* - Defnition of data layout string - tests for added relocations---not comprehensive, but matches existing....
Oct 1 2016, 10:20 AM

Jul 25 2016

joelkevinjones updated the diff for D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.

Trying to get "arc commit" to not complain about "generated from '', but current working copy root is '/llvm/trunk'"

Jul 25 2016, 9:49 AM

Jul 19 2016

joelkevinjones added a comment to D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend.

Ping. This change needs to be made once D16213 goes in.

Jul 19 2016, 6:57 AM
joelkevinjones added a comment to D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.

Thanks for your comments. I'll take your advice and push forward.

Jul 19 2016, 6:55 AM

Jul 18 2016

joelkevinjones added a comment to D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.

I'm trying to reconcile how this patch should interact with the set of proposed patches rooted at: https://reviews.llvm.org/D21465
The have similar goals, that is to support ABIs in a uniform fashion.

Jul 18 2016, 2:22 PM

Jul 6 2016

joelkevinjones added a comment to D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.

I've tried doing a commit using "arc commit --revision D16213", but I seem to have forgotten my password. Further, I'm 100% certain my email was set to the one at Apple. Could someone do the commit and the associated clang change for me?

Jul 6 2016, 1:49 PM

Jul 5 2016

joelkevinjones updated the diff for D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend.

Updated to ToT. Passes "make check-clang"

Jul 5 2016, 2:31 PM
joelkevinjones updated the diff for D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.

Rebased against ToT. Passes "make check".

Jul 5 2016, 12:19 PM

Jun 27 2016

joelkevinjones added a comment to D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.

Thanks for the follow up. I haven't gotten back to the work that motivated
the change. Would it be better to somehow retract the change and start
fresh when I pick up the work again? I don't follow LLVM development
closely enough to know the proper procedure.

Jun 27 2016, 9:03 AM

Feb 26 2016

joelkevinjones added a comment to D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend.

The FIXME comment doesn't make sense to me. I'm not sure what sanitizer arguments would be passed to the assembler.

Feb 26 2016, 6:52 AM

Feb 4 2016

joelkevinjones added a comment to D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend.

Ping.

Feb 4 2016, 2:29 PM

Jan 27 2016

joelkevinjones added a comment to D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend.

Did you mean remove the duplication from addPassesToEmitFile mentioned in the FIXME or something else?

Jan 27 2016, 3:09 PM

Jan 25 2016

joelkevinjones updated subscribers of D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend.
Jan 25 2016, 9:14 AM
joelkevinjones updated D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.
Jan 25 2016, 9:13 AM
joelkevinjones retitled D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC from [MD] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC to [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.
Jan 25 2016, 9:12 AM
joelkevinjones added a comment to D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.

I've made the necessary change to clang and put it in:

Jan 25 2016, 9:09 AM
joelkevinjones retitled D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend from to [cc1as] Add MCTargetOptions argument to createAsmBackend.
Jan 25 2016, 9:08 AM

Jan 14 2016

joelkevinjones retitled D16213: [MC] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC from to [MD] Provide an MCTargetOptions to implementors of MCAsmBackendCtorTy, NFC.
Jan 14 2016, 9:15 PM