And use it in PPCLoopDataPrefetch.cpp.
@hfinkel, please let me know if your preference would be to preserve the
ppc-loop-prefetch-cache-line option in order to be able to override the
value of TTI::getCacheLineSize for PPC.
Paths
| Differential D16306
[TTI] Add getCacheLineSize ClosedPublic Authored by anemet on Jan 18 2016, 3:53 PM.
Details Summary And use it in PPCLoopDataPrefetch.cpp. @hfinkel, please let me know if your preference would be to preserve the
Diff Detail Event Timelineanemet updated this object. • hulx2000 added inline comments.
Comment Actions Adam, this looks good to me, assuming Hal is OK with the flag being removed. I think we'll be able to use this hook in some of the loop optimizations (e.g., interchange). Comment Actions Now that we have a PPC hook for this, it's actually trivial to retain the the I'll commit this shortly per Geoff's approval. Thanks guys! Comment Actions
Sorry, per Matt, of course. This revision is now accepted and ready to land.Jan 21 2016, 10:28 AM Closed by commit rL258419: [TTI] Add getCacheLineSize (authored by anemet). · Explain WhyJan 21 2016, 10:32 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 45217 include/llvm/Analysis/TargetTransformInfo.h
include/llvm/Analysis/TargetTransformInfoImpl.h
lib/Analysis/TargetTransformInfo.cpp
lib/Target/PowerPC/PPCLoopDataPrefetch.cpp
|
Return 64 by default is not good, it would be better if assert or return unsupported message by default, and only return 64 for PPC.