- User Since
- Nov 18 2014, 4:05 PM (270 w, 1 d)
May 9 2016
Thanks James for your comments, sorry that I missed that last week.
May 2 2016
Apr 20 2016
Thanks a lot for reviewing, patch updated.
Apr 13 2016
Thanks a lot Hal.
Thanks James for the update, have a a nice vacation then.
Apr 11 2016
Apr 8 2016
Did you get time on this?
Apr 5 2016
Mar 30 2016
Patch updated, could you please continue your review?
Feb 29 2016
Caught by tight release schedule again, will address your comment after freed up.
Feb 18 2016
Feb 15 2016
Feb 12 2016
Feb 11 2016
Jan 25 2016
Thanks a lot for your quick response, Hal.
Jan 22 2016
Remove one space spotted by Hal
fix a minor format issue
Jan 20 2016
Jan 19 2016
Jan 18 2016
Very sorry that it took too long before I get back to this patch due to our release related work, now I need to rebase the code and fix the checking pattern of the testcase, could you please take a look again and give me a LGTM again? This time it will merged quickly.
Jan 14 2016
updated to address Johannes's comment, thanks Johannes
I agree, that's better, I will update that.
Jan 13 2016
Nov 23 2015
Nov 17 2015
Oct 27 2015
Oct 26 2015
Oct 12 2015
Sep 30 2015
Thanks, James, most of your concerns are addressed
Sep 28 2015
Thanks Hal for your prompt comments, I have updated the patch.
Sep 25 2015
Just saw comments from Hal and Nadav.
Sep 24 2015
Thanks Michael, just see your comments (not inline comments).
Sep 23 2015
merged as git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@248420 91177308-0d34-0410-b5e6-96231b3b80d8
Sep 22 2015
Aug 13 2015
Aug 7 2015
Interesting though, James said he turned off that Pass because Apple seeing non-negligible slowdowns, he said ok to turn it back on with tweaks, but "you’ll have to provide evidence to convince Gerolf".
Aug 6 2015
I have seen up and down with Splitting GEP pass.
Author: James Molloy <email@example.com>
Date: Wed Apr 22 09:11:38 2015 +0000
Thanks Andrew and Quentin.
Aug 1 2015
A better version is uploaded to http://reviews.llvm.org/D11051
moved the code back to Splitting GEP pass.
Opened a bug Bug 24171 - Load PRE inserts badly placed fully-redundant address arithmetic for it Daniel is working on the right solution.
Jul 29 2015
Forgot to mention.
About your comments, I have asked to reach an agreement, and posted my earlier version of this patch (in SeparateConstOffsetFromGEP) to http://reviews.llvm.org/D11443 to see if you guys like it or not.
Jul 28 2015
Jul 25 2015
Thanks for review.
Jul 24 2015
committed as git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@243171 91177308-0d34-0410-b5e6-96231b3b80d8
Jul 23 2015
Do you have any other comments about this patch, could you please accept it if not?
Could you please accept it if you have now further comment? It will be easier for me to prepare next two patches.
Jul 22 2015
Can we reach an agreement about where to do it? I posted my older patch which is part of Split GEP at http://reviews.llvm.org/D11443.
Jul 21 2015
Addressed Michael's comment
Jul 17 2015
typo: for me.
I will add Assert from the next test and on.
Jul 16 2015
Thanks, James for your valuable comments.
Jul 15 2015
Jul 14 2015
upload the full context diff