Page MenuHomePhabricator

hulx2000 (Lawrence Hu)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 18 2014, 4:05 PM (243 w, 4 d)

Recent Activity

May 9 2016

hulx2000 updated the diff for D19820: Enable loopreroll for sext of loop control only IV.

Thanks James for your comments, sorry that I missed that last week.

May 9 2016, 11:02 AM

May 2 2016

hulx2000 retitled D19820: Enable loopreroll for sext of loop control only IV from to Enable loopreroll for sext of loop control only IV.
May 2 2016, 12:00 PM

Apr 20 2016

hulx2000 updated the diff for D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

Thanks a lot for reviewing, patch updated.

Apr 20 2016, 12:18 PM
hulx2000 added a comment to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.
Apr 20 2016, 12:17 PM

Apr 13 2016

hulx2000 added a comment to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

Thanks a lot Hal.

Apr 13 2016, 1:42 PM
hulx2000 added a comment to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

Thanks James for the update, have a a nice vacation then.

Apr 13 2016, 12:13 PM

Apr 11 2016

hulx2000 added a comment to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

ping

Apr 11 2016, 11:30 AM

Apr 8 2016

hulx2000 added inline comments to D7299: Prevent hoisting fmul from THEN/ELSE to IF if there is fmsub/fmadd opportunity.
Apr 8 2016, 3:18 PM
hulx2000 added a comment to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

Did you get time on this?

Apr 8 2016, 3:16 PM

Apr 5 2016

hulx2000 added a comment to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

ping

Apr 5 2016, 2:35 PM

Mar 30 2016

hulx2000 updated the diff for D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

Patch updated, could you please continue your review?

Mar 30 2016, 3:12 PM
hulx2000 added inline comments to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.
Mar 30 2016, 3:10 PM

Feb 29 2016

hulx2000 added a comment to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

Caught by tight release schedule again, will address your comment after freed up.

Feb 29 2016, 6:13 PM

Feb 18 2016

hulx2000 added a comment to D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 18 2016, 4:46 PM
hulx2000 added a comment to D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 18 2016, 2:39 PM
hulx2000 updated the diff for D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 18 2016, 2:38 PM

Feb 15 2016

hulx2000 added inline comments to D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 15 2016, 11:39 AM

Feb 12 2016

hulx2000 added a comment to D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 12 2016, 5:12 PM
hulx2000 updated the diff for D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 12 2016, 1:54 PM
hulx2000 added a comment to D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 12 2016, 1:27 PM
hulx2000 updated D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 12 2016, 1:27 PM
hulx2000 updated the diff for D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast.
Feb 12 2016, 1:26 PM

Feb 11 2016

hulx2000 added a comment to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.

ping

Feb 11 2016, 10:13 AM
hulx2000 retitled D17154: Bug fix: use dyn_cast_or_null instead of dyn_cast from to Bug fix: check nullptr before call dyn_cast.
Feb 11 2016, 10:12 AM

Jan 25 2016

hulx2000 added inline comments to D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.
Jan 25 2016, 4:37 PM
hulx2000 retitled D16550: Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables from to Reroll loops with multiple IV and negative step part 3/3 -- support multiple induction variables.
Jan 25 2016, 12:17 PM
hulx2000 added a comment to D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

Thanks a lot for your quick response, Hal.

Jan 25 2016, 10:33 AM

Jan 22 2016

hulx2000 added a comment to D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.
Jan 22 2016, 5:06 PM
hulx2000 updated the diff for D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

Remove one space spotted by Hal

Jan 22 2016, 5:05 PM
hulx2000 updated the diff for D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

fix a minor format issue

Jan 22 2016, 4:52 PM

Jan 20 2016

hulx2000 added inline comments to D16306: [TTI] Add getCacheLineSize.
Jan 20 2016, 11:35 AM

Jan 19 2016

hulx2000 added inline comments to D16306: [TTI] Add getCacheLineSize.
Jan 19 2016, 2:36 PM
hulx2000 removed a reviewer for D16306: [TTI] Add getCacheLineSize: hulx2000.
Jan 19 2016, 2:36 PM
hulx2000 added a reviewer for D16306: [TTI] Add getCacheLineSize: hulx2000.
Jan 19 2016, 2:15 PM

Jan 18 2016

hulx2000 updated the diff for D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

Very sorry that it took too long before I get back to this patch due to our release related work, now I need to rebase the code and fix the checking pattern of the testcase, could you please take a look again and give me a LGTM again? This time it will merged quickly.

Jan 18 2016, 4:23 PM

Jan 14 2016

hulx2000 added a comment to D16160: Make sure we preserve alignment information after hoisting invariant load.
Jan 14 2016, 4:35 PM · Restricted Project
hulx2000 updated the diff for D16160: Make sure we preserve alignment information after hoisting invariant load.

updated again

Jan 14 2016, 4:35 PM · Restricted Project
hulx2000 added inline comments to D16160: Make sure we preserve alignment information after hoisting invariant load.
Jan 14 2016, 4:30 PM · Restricted Project
hulx2000 added a comment to D16160: Make sure we preserve alignment information after hoisting invariant load.
Jan 14 2016, 3:59 PM · Restricted Project
hulx2000 updated the diff for D16160: Make sure we preserve alignment information after hoisting invariant load.

updated to address Johannes's comment, thanks Johannes

Jan 14 2016, 2:55 PM · Restricted Project
hulx2000 added a comment to D16160: Make sure we preserve alignment information after hoisting invariant load.

I agree, that's better, I will update that.

Jan 14 2016, 11:55 AM · Restricted Project

Jan 13 2016

hulx2000 retitled D16160: Make sure we preserve alignment information after hoisting invariant load from to Make sure we preserve alignment information after hoisting invariant load.
Jan 13 2016, 3:38 PM · Restricted Project

Nov 23 2015

hulx2000 updated subscribers of rL253536: Fix bug 25440: GVN assertion after coercing loads.
Nov 23 2015, 5:18 PM

Nov 17 2015

hulx2000 added a comment to D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

ping

Nov 17 2015, 5:51 PM

Oct 27 2015

hulx2000 updated the diff for D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

clang-format it

Oct 27 2015, 9:31 AM

Oct 26 2015

hulx2000 updated the diff for D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.
Oct 26 2015, 2:13 PM
hulx2000 added inline comments to D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.
Oct 26 2015, 2:12 PM

Oct 12 2015

hulx2000 added a comment to D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

ping

Oct 12 2015, 6:00 PM

Sep 30 2015

hulx2000 added a comment to D9804: Optimize scattered vector insert/extract pattern.

Just saw comments from Hal and Nadav.

For Hal's comments:

  1. If the original ext is used more than once, then the original ext can't be deleted after my transformation, so it may not gain anything, that's why I check hasOneUse() on it.

No, you'd replace them all with the corresponding extract. What am I missing?

Sep 30 2015, 6:07 PM
hulx2000 updated the diff for D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.
Sep 30 2015, 6:02 PM
hulx2000 added a comment to D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

Thanks, James, most of your concerns are addressed

Sep 30 2015, 6:01 PM

Sep 28 2015

hulx2000 updated the diff for D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.

Thanks Hal for your prompt comments, I have updated the patch.

Sep 28 2015, 3:41 PM

Sep 25 2015

hulx2000 added a comment to D9804: Optimize scattered vector insert/extract pattern.

Just saw comments from Hal and Nadav.

Sep 25 2015, 2:40 PM

Sep 24 2015

hulx2000 retitled D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3 from to Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3.
Sep 24 2015, 5:02 PM
hulx2000 added a comment to D9804: Optimize scattered vector insert/extract pattern.

Thanks Michael, just see your comments (not inline comments).

Sep 24 2015, 10:51 AM

Sep 23 2015

hulx2000 added a comment to D9804: Optimize scattered vector insert/extract pattern.
Sep 23 2015, 3:09 PM
hulx2000 added a comment to D9804: Optimize scattered vector insert/extract pattern.

ping

Sep 23 2015, 3:07 PM
hulx2000 updated the diff for D9804: Optimize scattered vector insert/extract pattern.
Sep 23 2015, 3:07 PM
hulx2000 closed D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

merged as git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@248420 91177308-0d34-0410-b5e6-96231b3b80d8

Sep 23 2015, 1:15 PM

Sep 22 2015

hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

ping

Sep 22 2015, 10:59 AM

Aug 13 2015

hulx2000 updated the diff for D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Aug 13 2015, 2:50 PM
hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Aug 13 2015, 2:49 PM

Aug 7 2015

hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

Interesting though, James said he turned off that Pass because Apple seeing non-negligible slowdowns, he said ok to turn it back on with tweaks, but "you’ll have to provide evidence to convince Gerolf".

Aug 7 2015, 10:50 AM

Aug 6 2015

hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

I have seen up and down with Splitting GEP pass.

Aug 6 2015, 3:53 PM
hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

commit 89cc8dd3b84a636b2798028a994f4b71c78e0163
Author: James Molloy <james.molloy@arm.com>
Date: Wed Apr 22 09:11:38 2015 +0000

Aug 6 2015, 3:42 PM
hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

Thanks Andrew and Quentin.

Aug 6 2015, 3:30 PM

Aug 1 2015

hulx2000 abandoned D11443: Create constant GEP first to allow more LICM..

A better version is uploaded to http://reviews.llvm.org/D11051

Aug 1 2015, 2:41 PM
hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

moved the code back to Splitting GEP pass.

Aug 1 2015, 2:39 PM
hulx2000 updated the diff for D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Aug 1 2015, 2:38 PM
hulx2000 updated the diff for D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Aug 1 2015, 2:34 PM
hulx2000 abandoned D11234: Add debug option to turn off zero cost phi node inserting in PRE.

Opened a bug Bug 24171 - Load PRE inserts badly placed fully-redundant address arithmetic for it Daniel is working on the right solution.

Aug 1 2015, 10:28 AM

Jul 29 2015

hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

Forgot to mention.

Jul 29 2015, 10:02 AM
hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

About your comments, I have asked to reach an agreement, and posted my earlier version of this patch (in SeparateConstOffsetFromGEP) to http://reviews.llvm.org/D11443 to see if you guys like it or not.

Jul 29 2015, 10:01 AM

Jul 28 2015

hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Jul 28 2015, 10:14 AM
hulx2000 updated the diff for D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Jul 28 2015, 10:14 AM
hulx2000 added inline comments to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Jul 28 2015, 10:11 AM

Jul 25 2015

hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Jul 25 2015, 5:13 PM
hulx2000 updated the diff for D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..
Jul 25 2015, 5:12 PM
hulx2000 updated the diff for D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

Thanks Hal.

Jul 25 2015, 4:26 PM
hulx2000 added a comment to D11443: Create constant GEP first to allow more LICM..

Thanks for review.

Jul 25 2015, 11:18 AM

Jul 24 2015

hulx2000 closed D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

committed as git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@243171 91177308-0d34-0410-b5e6-96231b3b80d8

Jul 24 2015, 3:27 PM
hulx2000 updated the diff for D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

Thanks, Hal,

Jul 24 2015, 10:10 AM

Jul 23 2015

hulx2000 added a comment to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

Do you have any other comments about this patch, could you please accept it if not?

Jul 23 2015, 12:25 PM
hulx2000 added a comment to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

Could you please accept it if you have now further comment? It will be easier for me to prepare next two patches.

Jul 23 2015, 12:11 PM
hulx2000 retitled D11467: enable coalescing of COPY and MOVi32imm from to enable coalescing of COPY and MOVi32imm.
Jul 23 2015, 10:46 AM

Jul 22 2015

hulx2000 added reviewers for D11443: Create constant GEP first to allow more LICM.: joker-eph-DISABLED, mcrosier, atrick, hfinkel, qcolombet.
Jul 22 2015, 6:19 PM
hulx2000 added a comment to D11051: Swap loop invariant GEP with loop variant GEP to allow more LICM..

Can we reach an agreement about where to do it? I posted my older patch which is part of Split GEP at http://reviews.llvm.org/D11443.

Jul 22 2015, 6:18 PM
hulx2000 retitled D11443: Create constant GEP first to allow more LICM. from to Create constant GEP first to allow more LICM..
Jul 22 2015, 6:17 PM
hulx2000 added a comment to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.
Jul 22 2015, 10:40 AM
hulx2000 added a comment to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.
Jul 22 2015, 10:39 AM

Jul 21 2015

hulx2000 updated the diff for D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

Addressed Michael's comment

Jul 21 2015, 6:53 PM
hulx2000 added inline comments to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.
Jul 21 2015, 6:51 PM

Jul 17 2015

hulx2000 added a comment to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

typo: for me.

Jul 17 2015, 4:19 PM
hulx2000 added a comment to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

I will add Assert from the next test and on.

Jul 17 2015, 4:18 PM
hulx2000 added inline comments to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.
Jul 17 2015, 10:34 AM
hulx2000 updated the diff for D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

Thanks Jame.

Jul 17 2015, 10:32 AM

Jul 16 2015

hulx2000 updated the diff for D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

Thanks, James for your valuable comments.

Jul 16 2015, 2:11 PM

Jul 15 2015

hulx2000 retitled D11234: Add debug option to turn off zero cost phi node inserting in PRE from to Add debug option to turn off zero cost phi node inserting in PRE.
Jul 15 2015, 11:43 AM
hulx2000 added inline comments to D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.
Jul 15 2015, 10:39 AM

Jul 14 2015

hulx2000 updated the diff for D10477: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 1/3.

upload the full context diff

Jul 14 2015, 11:42 AM