Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D159524

[BOLT] Speedup symbol table sort
ClosedPublic
Actions

Authored by maksfb on Sun, Sep 17, 1:08 PM.

Details

Reviewers
jobnoorman
yota9
Amir
ayermolo
rafauler
Commits
rG1e9b006add11: [BOLT] Speedup symbol table sort
Summary

Memoize SymbolRef::getAddress() for sorting symbol table entries by
their address. Saves about 10 seconds of processing time on large
binaries with over 2 million symbols. NFCI.

Diff Detail

Event Timeline

maksfb created this revision.Sun, Sep 17, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Sep 17, 1:08 PM
Herald added a subscriber: treapster. · View Herald Transcript
maksfb requested review of this revision.Sun, Sep 17, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Sep 17, 1:08 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B257321: Diff 556915.Sun, Sep 17, 1:10 PM
jobnoorman accepted this revision.Mon, Sep 18, 12:59 AM
jobnoorman added inline comments.
bolt/lib/Rewrite/RewriteInstance.cpp
820

emplace_back?

This revision is now accepted and ready to land.Mon, Sep 18, 12:59 AM
Amir added a child revision: D159525: [BOLT][NFC] Refactor RI::discoverFileObjects().Mon, Sep 18, 9:59 AM
Amir accepted this revision.Mon, Sep 18, 10:30 AM
Closed by commit rG1e9b006add11: [BOLT] Speedup symbol table sort (authored by maksfb). · Explain WhyMon, Sep 18, 11:29 AM
This revision was automatically updated to reflect the committed changes.
maksfb added a commit: rG1e9b006add11: [BOLT] Speedup symbol table sort.
maksfb marked an inline comment as done.Mon, Sep 18, 11:30 AM
maksfb added inline comments.
bolt/lib/Rewrite/RewriteInstance.cpp
820

Doesn't work with structs.

Revision Contents
Changeset List

PathSize
bolt/
lib/
Rewrite/
103 lines

Diff 556963

View Options

bolt/lib/Rewrite/RewriteInstance.cpp

Loading...