[mlir][linalg][transform][python] Make divisor arg to Multitile optional

[ingomueller-net]

Summary

The mix-in of the MultiTileSizesOp set the default value of its
divisor argument. This repeats information from the tablegen
defintion, is not necessary (since the generic code deals with None
and default values), and has the risk of running out of sync without
people noticing. This patch removes the setting of the value and forward
None to the generic constructor instead.

mlir/python/mlir/dialects/_structured_transform_ops_ext.py

):
             _get_op_result_or_value(target),
             ops=ArrayAttr.get(list(map(lambda s: StringAttr.get(s), names))),
             loc=loc,
             ip=ip,
         )
 
 
 class MultiTileSizesOp:
-    """Specialization for MultitileSizesOp class."""
+    """Specialization for MultiTileSizesOp class."""
 
     def __init__(
         self,
         result_type: Type,
         target: Union[Operation, Value],
         *,
         dimension: Union[int, IntegerAttr],
         target_size: Union[int, IntegerAttr],
         divisor: Optional[Optional[Union[int, IntegerAttr]]] = None,
         loc=None,
         ip=None,
     ):
-        if divisor is None:
-            divisor = 1
         super().__init__(
             result_type,
             result_type,
             result_type,
             _get_op_result_or_value(target),
             dimension=dimension,
             target_size=target_size,
             divisor=divisor,

mlir/test/python/dialects/transform_structured_ext.py

with InsertionPoint(sequence.body):
         transform.YieldOp()
     # CHECK-LABEL: TEST: testMatchOpNamesTyped
     # CHECK: transform.structured.match ops
     # CHECK-SAME: ["test.dummy"]
     # CHECK-SAME: (!transform.any_op) -> !transform.op<"test.dummy">
 
 
 @run
-def testMultitileSizes():
+def testMultitileSizesCompact():
     sequence = transform.SequenceOp(
         transform.FailurePropagationMode.Propagate, [], pdl.OperationType.get()
     )
     with InsertionPoint(sequence.body):
         structured.MultiTileSizesOp(
             pdl.OperationType.get(), sequence.bodyTarget, dimension=1, target_size=42
         )
         transform.YieldOp()
     # CHECK-LABEL: TEST: testMultitileSizes
     # CHECK: transform.sequence
+    # CHECK-NOT: divisor
     # CHECK: transform.structured.multitile_sizes
+    # CHECK-NOT: divisor
     # CHECK-DAG: dimension = 1
+    # CHECK-NOT: divisor
+    # CHECK-DAG: target_size = 42
+    # CHECK-NOT: divisor
+
+
+@run
+def testMultitileSizesAllArgs():
+    sequence = transform.SequenceOp(
+        transform.FailurePropagationMode.Propagate, [], pdl.OperationType.get()
+    )
+    with InsertionPoint(sequence.body):
+        structured.MultiTileSizesOp(
+            pdl.OperationType.get(),
+            sequence.bodyTarget,
+            dimension=1,
+            target_size=42,
+            divisor=2,
+        )
+        transform.YieldOp()
+    # CHECK-LABEL: TEST: testMultitileSizes
+    # CHECK: transform.sequence
+    # CHECK: transform.structured.multitile_sizes
+    # CHECK-DAG: dimension = 1
+    # CHECK-DAG: divisor = 2
     # CHECK-DAG: target_size = 42
 
 
 @run
 def testPadOpNoArgs():
     sequence = transform.SequenceOp(
         transform.FailurePropagationMode.Propagate, [], pdl.OperationType.get()
     )