User Details
- User Since
- Nov 18 2021, 7:23 AM (62 w, 3 d)
Wed, Jan 25
Single-character comment-only fix --> self-accepting.
White-space-in-comments only change and builds passing: self-accepting.
Please review carefully; this is just copy'n'pasting from similar places and I am not sure whether this actually does the notification that is required.
Dec 14 2022
Add missing new line at end of file.
Dec 5 2022
I have investigate a bit more on the limitation of allowing only pure ops to be inlined. I have found two that I would like to be inlinable for my use case and where I don't see any reason that they shouldn't be:
Dec 2 2022
Two comments:
Jul 22 2022
Awesome, thanks! I confirm that this makes the code run that I had initially problems with!
Jul 20 2022
Jul 15 2022
Updating D129762: [mlir][mbr] Improve diagnostics on error with raise from.
Jul 14 2022
It seems like this is the inverse direction than what is needed: The constructor you point to constructs a FrozenRewritePatternSet from a RewritePatternSet (which freezes the set); however, in the example, we have a FrozenRewritepatternSet that is given to a function that expected a RewritePatternSet (which would "unfreeze" the set, which I guess shouldn't be possible). My commit makes the function accept a FrozenRewritePatternSet instead, but one could also never freeze it in the first place. I don't really understand the code, so any more informed suggestions are welcome!
Updating D129738: [mlir][benchmark] Fix import in sparse benchmark.
Hold on, I am not sure whether this fixes all problems :S
May 9 2022
Apr 20 2022
Yes :) Landed!
Apr 19 2022
Mar 30 2022
Mar 28 2022
@nicolasvasilache: I couldn't find out how to get this revision out of draft mode but I am done with it.
Mar 17 2022
I don't have the permission; can someone land this for me?
Rebasing to latest main. I had not understood the review process
when I submitted the first revision some months ago, so this
change never got landed...
Mar 16 2022
I don't have permission, can someone land this for me?
Nov 22 2021
Applying changes suggested by nicolasvasilache
Nov 18 2021
Fix another formatting issue.
Actually, I think that this needs more fixing but I am not too sure how it should look like.