Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

ingomueller-net (Ingo Müller)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 18 2021, 7:23 AM (97 w, 6 d)

Recent Activity

Fri, Sep 29

ingomueller-net committed rG61ba0b2815ee: [mlir][transform] Improve error message when file not found. (authored by ingomueller-net).
[mlir][transform] Improve error message when file not found.
Fri, Sep 29, 7:08 AM · Restricted Project, Restricted Project

Tue, Sep 26

ingomueller-net committed rGf40e620956c2: Reapply "[mlir][transform] Improve error message of tracking listener. (#66987)" (authored by ingomueller-net).
Reapply "[mlir][transform] Improve error message of tracking listener. (#66987)"
Tue, Sep 26, 6:00 AM · Restricted Project, Restricted Project

Thu, Sep 21

ingomueller-net committed rG6464a016804e: [mlir][linalg][transform] Fix test breakage from 69bc1cbb. (NFC) (authored by ingomueller-net).
[mlir][linalg][transform] Fix test breakage from 69bc1cbb. (NFC)
Thu, Sep 21, 6:48 AM · Restricted Project, Restricted Project

Sat, Sep 16

ingomueller-net added a comment to D157774: [mlir][transform] Extend `MaskedVectorizeOp` to work for regular vectorization too.

As discussed with @nicolasvasilache, I have started to rename the ops here. That PR is still work in progress but feedback on the new names is already welcome. (Current suggestion: Vectorize => VectorizeChildren and MaskedVectorize => Vectorize.)

Sat, Sep 16, 6:06 AM · Restricted Project, Restricted Project

Wed, Sep 6

ingomueller-net abandoned D159093: WIP: [mlir][gpu][transform] Broken test cases for MapForallToBlocks..

Fixed by 92f088d335e4a55f10e74c541ac52ec2a4d4ceeb.

Wed, Sep 6, 12:11 AM · Restricted Project, Restricted Project
ingomueller-net abandoned D156527: [mlir][gpu][transform] Fix regressions in MapForallToBlocks..

Abandoning because 92f088d335e4a55f10e74c541ac52ec2a4d4ceeb fixes the issues and has landed.

Wed, Sep 6, 12:11 AM · Restricted Project, Restricted Project
ingomueller-net committed rGca23c933bda9: [mlir][python] Create all missing attribute builders. (authored by ingomueller-net).
[mlir][python] Create all missing attribute builders.
Wed, Sep 6, 12:10 AM · Restricted Project, Restricted Project
ingomueller-net closed D159403: [mlir][python] Create all missing attribute builders..
Wed, Sep 6, 12:09 AM · Restricted Project, Restricted Project

Sep 4 2023

ingomueller-net added a comment to D159403: [mlir][python] Create all missing attribute builders..

@ftynse: should I wait for you to have a look or go ahead and land?

Sep 4 2023, 7:59 AM · Restricted Project, Restricted Project
ingomueller-net committed rG33278321e6ca: [mlir][linalg][transform][python] Make divisor arg to Multitile optional (authored by ingomueller-net).
[mlir][linalg][transform][python] Make divisor arg to Multitile optional
Sep 4 2023, 6:26 AM · Restricted Project, Restricted Project
ingomueller-net committed rGea4a5127c49d: [mlir][linalg][transform][python] Refactor TileOp mix-in. (authored by ingomueller-net).
[mlir][linalg][transform][python] Refactor TileOp mix-in.
Sep 4 2023, 6:25 AM · Restricted Project, Restricted Project
ingomueller-net closed D159416: [mlir][linalg][transform][python] Make divisor arg to Multitile optional.
Sep 4 2023, 6:25 AM · Restricted Project, Restricted Project
ingomueller-net closed D159417: [mlir][linalg][transform][python] Refactor TileOp mix-in..
Sep 4 2023, 6:25 AM · Restricted Project, Restricted Project
ingomueller-net committed rGd5946fd3ede0: [mlir][linalg][transform][python] Simplify mix-in of PadOp. (authored by ingomueller-net).
[mlir][linalg][transform][python] Simplify mix-in of PadOp.
Sep 4 2023, 6:25 AM · Restricted Project, Restricted Project
ingomueller-net closed D159419: [mlir][linalg][transform][python] Simplify mix-in of PadOp..
Sep 4 2023, 6:25 AM · Restricted Project, Restricted Project
ingomueller-net accepted D159420: [mlir][linalg] Fix bufferize_to_allocation error checking.
Sep 4 2023, 4:36 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D152006: [mlir][tensor] Realloc to bufferize ReshapeOp with non-identity layout..

@springerm: Is this patch completely obsolete now? Should we abandon it?

Sep 4 2023, 4:35 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D153688: [mlir][tensor] Remove element type constraint on SplatOp..

With the goal of flushing my Phabricator pipeline, I expanded the set of reviewers.

Sep 4 2023, 4:34 AM · Restricted Project, Restricted Project
ingomueller-net added reviewers for D153688: [mlir][tensor] Remove element type constraint on SplatOp.: ftynse, springerm.
Sep 4 2023, 4:33 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D159419: [mlir][linalg][transform][python] Simplify mix-in of PadOp..

Oh, yeah, thanks for the reminder! Will do!

Sep 4 2023, 4:31 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159419: [mlir][linalg][transform][python] Simplify mix-in of PadOp..
Sep 4 2023, 1:39 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159417: [mlir][linalg][transform][python] Refactor TileOp mix-in..
Sep 4 2023, 1:34 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159416: [mlir][linalg][transform][python] Make divisor arg to Multitile optional.
Sep 4 2023, 1:12 AM · Restricted Project, Restricted Project
ingomueller-net committed rG9b91ae13f41f: [mlir][python][linalg][transform] Forward missing params in mix-ins. (authored by ingomueller-net).
[mlir][python][linalg][transform] Forward missing params in mix-ins.
Sep 4 2023, 12:59 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D159403: [mlir][python] Create all missing attribute builders..

Implement changes suggested by @rkayaith:

Sep 4 2023, 12:48 AM · Restricted Project, Restricted Project
ingomueller-net added inline comments to D159403: [mlir][python] Create all missing attribute builders..
Sep 4 2023, 12:47 AM · Restricted Project, Restricted Project

Sep 2 2023

ingomueller-net committed rG6ff7ef433158: [mlir][python] Fix-forward 9442b441c1c50e4e6782fd2e6aa16925c9d22e29. (authored by ingomueller-net).
[mlir][python] Fix-forward 9442b441c1c50e4e6782fd2e6aa16925c9d22e29.
Sep 2 2023, 7:23 AM · Restricted Project, Restricted Project
ingomueller-net retitled D159403: [mlir][python] Create all missing attribute builders. from WIP: [mlir][python] Create all missing attribute builders. to [mlir][python] Create all missing attribute builders..
Sep 2 2023, 5:38 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159403: [mlir][python] Create all missing attribute builders..
Sep 2 2023, 5:38 AM · Restricted Project, Restricted Project
ingomueller-net committed rG9442b441c1c5: [mlir][linalg][transform][python] Fix optional args of PadOp mix-in. (authored by ingomueller-net).
[mlir][linalg][transform][python] Fix optional args of PadOp mix-in.
Sep 2 2023, 4:19 AM · Restricted Project, Restricted Project
ingomueller-net closed D158844: [mlir][linalg][transform][python] Fix optional args of PadOp mix-in..
Sep 2 2023, 4:19 AM · Restricted Project, Restricted Project

Sep 1 2023

ingomueller-net abandoned D159182: [mlir][python] Add tests for implicit pybind casts..

The only thing that isn't tested that explicitly in the attributes tests is that the automatic conversion done by pybind works as expected. But in a way that's a pybind feature... Abandoning.

Sep 1 2023, 12:38 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D158844: [mlir][linalg][transform][python] Fix optional args of PadOp mix-in..

Could somebody look at this patch?

Sep 1 2023, 12:36 AM · Restricted Project, Restricted Project
ingomueller-net committed rG9f5335487ae5: [mlir][python] Remove __str__ from bindings of StringAttr. (authored by ingomueller-net).
[mlir][python] Remove __str__ from bindings of StringAttr.
Sep 1 2023, 12:36 AM · Restricted Project, Restricted Project
ingomueller-net closed D159255: [mlir][python] Remove __str__ from bindings of StringAttr..
Sep 1 2023, 12:36 AM · Restricted Project, Restricted Project

Aug 31 2023

ingomueller-net updated the diff for D159255: [mlir][python] Remove __str__ from bindings of StringAttr..
  • Rebase to a version from yesterday with working Windows build.
Aug 31 2023, 7:37 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D159255: [mlir][python] Remove __str__ from bindings of StringAttr..
  • Rebasing to current main to resolve unrelated CI failures.
Aug 31 2023, 6:35 AM · Restricted Project, Restricted Project
ingomueller-net added a reviewer for D158844: [mlir][linalg][transform][python] Fix optional args of PadOp mix-in.: martin-luecke.
Aug 31 2023, 1:48 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D159182: [mlir][python] Add tests for implicit pybind casts..

Do these tests provide value beyond finding out how __str__ and pybind11 interact? If yes, I guess I'll rebase this patch on top of https://reviews.llvm.org/D159255 and land (after approval)...

Aug 31 2023, 1:10 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159255: [mlir][python] Remove __str__ from bindings of StringAttr..
Aug 31 2023, 1:08 AM · Restricted Project, Restricted Project
ingomueller-net committed rGd7746220b10c: [mlir][lsp] Register all extensions and TestDynDialect in main. (authored by ingomueller-net).
[mlir][lsp] Register all extensions and TestDynDialect in main.
Aug 31 2023, 12:55 AM · Restricted Project, Restricted Project
ingomueller-net closed D159091: [mlir][lsp] Register all extensions and TestDynDialect in main..
Aug 31 2023, 12:54 AM · Restricted Project, Restricted Project

Aug 30 2023

ingomueller-net updated the diff for D159091: [mlir][lsp] Register all extensions and TestDynDialect in main..
  • Rebase to resolve unrelated CI problems.
Aug 30 2023, 2:41 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159182: [mlir][python] Add tests for implicit pybind casts..
Aug 30 2023, 2:37 AM · Restricted Project, Restricted Project

Aug 29 2023

ingomueller-net added a comment to D158974: [mlir][python] Add __{bool,float,int,str}__ to bindings of attributes..

I agree. I'll investigate tomorrow when I am back at work.

Aug 29 2023, 11:14 AM · Restricted Project, Restricted Project
ingomueller-net committed rG41cb3c4d8728: Fix-forward broken test case from 2a5d497494c24425e99655b85e2277dd3f15a400. (authored by ingomueller-net).
Fix-forward broken test case from 2a5d497494c24425e99655b85e2277dd3f15a400.
Aug 29 2023, 8:06 AM · Restricted Project, Restricted Project
ingomueller-net committed rGa17313794be0: [mlir][linalg][transform] Return copy_back op from PadOp. (authored by springerm).
[mlir][linalg][transform] Return copy_back op from PadOp.
Aug 29 2023, 7:56 AM · Restricted Project, Restricted Project
ingomueller-net closed D159088: [mlir][linalg][transform] Return copy_back op from PadOp..
Aug 29 2023, 7:55 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D159100: WIP: [mlir][transform][python] Test that mix-ins stay in sync with tablegen..
  • Add file I forgot to add in the initial revision.
Aug 29 2023, 7:54 AM · Restricted Project, Restricted Project
ingomueller-net committed rG2a5d497494c2: [mlir][python] Add __{bool,float,int,str}__ to bindings of attributes. (authored by ingomueller-net).
[mlir][python] Add __{bool,float,int,str}__ to bindings of attributes.
Aug 29 2023, 7:53 AM · Restricted Project, Restricted Project
ingomueller-net closed D158974: [mlir][python] Add __{bool,float,int,str}__ to bindings of attributes..
Aug 29 2023, 7:53 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159100: WIP: [mlir][transform][python] Test that mix-ins stay in sync with tablegen..
Aug 29 2023, 7:51 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159093: WIP: [mlir][gpu][transform] Broken test cases for MapForallToBlocks..
Aug 29 2023, 7:00 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159091: [mlir][lsp] Register all extensions and TestDynDialect in main..
Aug 29 2023, 6:45 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D159088: [mlir][linalg][transform] Return copy_back op from PadOp..
  • Fix mix-in by adding default type for new result value.
Aug 29 2023, 6:09 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D159088: [mlir][linalg][transform] Return copy_back op from PadOp..
Aug 29 2023, 5:59 AM · Restricted Project, Restricted Project

Aug 28 2023

ingomueller-net committed rG8dcb67225b2c: [mlir][python] Make DenseBoolArrayAttr.get work with list of bools. (authored by ingomueller-net).
[mlir][python] Make DenseBoolArrayAttr.get work with list of bools.
Aug 28 2023, 8:15 AM · Restricted Project, Restricted Project
ingomueller-net closed D158973: [mlir][python] Make DenseBoolArrayAttr.get work with list of bools..
Aug 28 2023, 8:15 AM · Restricted Project, Restricted Project
ingomueller-net added inline comments to D158974: [mlir][python] Add __{bool,float,int,str}__ to bindings of attributes..
Aug 28 2023, 8:10 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D158987: WIP: [mlir][python] Add type casters for PyDictAttribute..

Sorry, I meant to submit this patch as a draft but forgot to add the flag. If somebody knows how to convert it to a patch, please let me know; otherwise, you'll be spammed by my updates to the patch... :S

Aug 28 2023, 7:52 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D158987: WIP: [mlir][python] Add type casters for PyDictAttribute..
Aug 28 2023, 7:16 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D158974: [mlir][python] Add __{bool,float,int,str}__ to bindings of attributes..
Aug 28 2023, 3:05 AM · Restricted Project, Restricted Project
ingomueller-net abandoned D145501: [mlir] Extend 1:N type conversion tests to decompose complex<T>..
Aug 28 2023, 2:49 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D158973: [mlir][python] Make DenseBoolArrayAttr.get work with list of bools..
Aug 28 2023, 2:47 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D158726: [mlir][linalg][transform][python] Extend mix-in for Vectorize.

OK, done! Unfortunately, I show up as an author now on git. I spend a bit of time trying to find out who was going to be the author and how to make sure it remains you but I didn't find anything. Turns out that the one who lands becomes the author...

Aug 28 2023, 1:08 AM · Restricted Project, Restricted Project
ingomueller-net committed rGa470df3ffc7e: [mlir][linalg][transform][python] Extend mix-in for Vectorize (authored by ingomueller-net).
[mlir][linalg][transform][python] Extend mix-in for Vectorize
Aug 28 2023, 1:06 AM · Restricted Project, Restricted Project
ingomueller-net closed D158726: [mlir][linalg][transform][python] Extend mix-in for Vectorize.
Aug 28 2023, 1:06 AM · Restricted Project, Restricted Project

Aug 25 2023

ingomueller-net updated the diff for D158844: [mlir][linalg][transform][python] Fix optional args of PadOp mix-in..
  • Fix type hints.
  • Add test for StringAttr padding value.
Aug 25 2023, 6:32 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D158844: [mlir][linalg][transform][python] Fix optional args of PadOp mix-in..
Aug 25 2023, 6:25 AM · Restricted Project, Restricted Project

Aug 24 2023

ingomueller-net accepted D158726: [mlir][linalg][transform][python] Extend mix-in for Vectorize.
Aug 24 2023, 9:17 AM · Restricted Project, Restricted Project

Aug 21 2023

ingomueller-net committed rG57c090b2ea03: [mlir][linalg][transform][python] Improve mix-in for PadOp. (authored by ingomueller-net).
[mlir][linalg][transform][python] Improve mix-in for PadOp.
Aug 21 2023, 6:36 AM · Restricted Project, Restricted Project
ingomueller-net closed D157789: [mlir][linalg][transform][python] Improve mix-in for PadOp..
Aug 21 2023, 6:36 AM · Restricted Project, Restricted Project
ingomueller-net added inline comments to D157789: [mlir][linalg][transform][python] Improve mix-in for PadOp..
Aug 21 2023, 4:39 AM · Restricted Project, Restricted Project

Aug 16 2023

ingomueller-net added a comment to D157735: [mlir][linalg][transform][python] Add mix-in for MaskedVectorize..

Thanks for notifying! I just pushed d7e26b56207cbd8995296c5bb7c11ce676b649da to fix it.

Aug 16 2023, 9:30 AM · Restricted Project, Restricted Project
ingomueller-net committed rGd7e26b56207c: [mlir][linalg][transform][python] Fix mix-in for MaskedVectorize. (authored by ingomueller-net).
[mlir][linalg][transform][python] Fix mix-in for MaskedVectorize.
Aug 16 2023, 9:28 AM · Restricted Project, Restricted Project
ingomueller-net committed rG67c092c8c883: [mlir][transform][python] Add test for AnyValueType binding. (authored by ingomueller-net).
[mlir][transform][python] Add test for AnyValueType binding.
Aug 16 2023, 8:08 AM · Restricted Project, Restricted Project
ingomueller-net committed rGdac19b457e2c: [mlir][linalg][transform][python] Add mix-in for MaskedVectorize. (authored by ingomueller-net).
[mlir][linalg][transform][python] Add mix-in for MaskedVectorize.
Aug 16 2023, 8:08 AM · Restricted Project, Restricted Project
ingomueller-net committed rG2d3dcd4aecb9: [mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp. (authored by ingomueller-net).
[mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp.
Aug 16 2023, 8:08 AM · Restricted Project, Restricted Project
ingomueller-net closed D158074: [mlir][transform][python] Add test for AnyValueType binding..
Aug 16 2023, 8:08 AM · Restricted Project, Restricted Project
ingomueller-net closed D157735: [mlir][linalg][transform][python] Add mix-in for MaskedVectorize..
Aug 16 2023, 8:08 AM · Restricted Project, Restricted Project
ingomueller-net closed D158075: [mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp..
Aug 16 2023, 8:07 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D158075: [mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp..

The original patch has been reviewed and the update is trivial. Will self-accept when CI has passed.

Aug 16 2023, 6:18 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D158075: [mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp..
Aug 16 2023, 6:18 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D158074: [mlir][transform][python] Add test for AnyValueType binding..

Trivial change, will self-accept once CI passed.

Aug 16 2023, 6:13 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D158074: [mlir][transform][python] Add test for AnyValueType binding..
Aug 16 2023, 6:12 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D157735: [mlir][linalg][transform][python] Add mix-in for MaskedVectorize..
  • Rebase onto current main (with merge conflict).
Aug 16 2023, 6:08 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D157735: [mlir][linalg][transform][python] Add mix-in for MaskedVectorize..
  • Changing CHECK directives as suggested by @springerm.
Aug 16 2023, 12:21 AM · Restricted Project, Restricted Project

Aug 14 2023

ingomueller-net added a comment to rG20966fcbfea5: [mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp..

Aha, the vertical bar for type hi ts only exists since Python 3.10 (see https://peps.python.org/pep-0604/) and some downstream tests run Python 3.8. Will fix and reapply later.

Aug 14 2023, 10:35 AM · Restricted Project, Restricted Project
ingomueller-net committed rG20966fcbfea5: [mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp. (authored by ingomueller-net).
[mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp.
Aug 14 2023, 6:46 AM · Restricted Project, Restricted Project
ingomueller-net closed D157704: [mlir][linalg][transform][python] Add mix-in for BufferizeToAllocOp..
Aug 14 2023, 6:45 AM · Restricted Project, Restricted Project
ingomueller-net committed rG691a2fab88a0: [mlir][linalg][transform][python] Add mix-in for MapCopyToThreadsOp. (authored by ingomueller-net).
[mlir][linalg][transform][python] Add mix-in for MapCopyToThreadsOp.
Aug 14 2023, 6:40 AM · Restricted Project, Restricted Project
ingomueller-net closed D157706: [mlir][linalg][transform][python] Add mix-in for MapCopyToThreadsOp..
Aug 14 2023, 6:39 AM · Restricted Project, Restricted Project
ingomueller-net committed rG030e315ee771: [mlir][linalg][transform][python] Verify modules in mix-in tests. (authored by ingomueller-net).
[mlir][linalg][transform][python] Verify modules in mix-in tests.
Aug 14 2023, 6:38 AM · Restricted Project, Restricted Project
ingomueller-net closed D157790: [mlir][linalg][transform][python] Verify modules in mix-in tests..
Aug 14 2023, 6:38 AM · Restricted Project, Restricted Project

Aug 13 2023

ingomueller-net committed rG1800038fba42: [clang] Fix ClangScanDeps test for #61006. (authored by ingomueller-net).
[clang] Fix ClangScanDeps test for #61006.
Aug 13 2023, 11:24 AM · Restricted Project, Restricted Project
ingomueller-net closed D157817: [clang] Fix ClangScanDeps test for #61006..
Aug 13 2023, 11:23 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D157817: [clang] Fix ClangScanDeps test for #61006..
Aug 13 2023, 10:59 AM · Restricted Project, Restricted Project

Aug 12 2023

ingomueller-net requested review of D157790: [mlir][linalg][transform][python] Verify modules in mix-in tests..
Aug 12 2023, 10:18 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D157789: [mlir][linalg][transform][python] Improve mix-in for PadOp..
  • Fix unit test.
Aug 12 2023, 10:14 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D157789: [mlir][linalg][transform][python] Improve mix-in for PadOp..
Aug 12 2023, 10:12 AM · Restricted Project, Restricted Project