As discussed with @nicolasvasilache, I have started to rename the ops here. That PR is still work in progress but feedback on the new names is already welcome. (Current suggestion: Vectorize => VectorizeChildren and MaskedVectorize => Vectorize.)

Fixed by 92f088d335e4a55f10e74c541ac52ec2a4d4ceeb.

Abandoning because 92f088d335e4a55f10e74c541ac52ec2a4d4ceeb fixes the issues and has landed.

@ftynse: should I wait for you to have a look or go ahead and land?

@springerm: Is this patch completely obsolete now? Should we abandon it?

With the goal of flushing my Phabricator pipeline, I expanded the set of reviewers.

Oh, yeah, thanks for the reminder! Will do!

Implement changes suggested by @rkayaith:

The only thing that isn't tested that explicitly in the attributes tests is that the automatic conversion done by pybind works as expected. But in a way that's a pybind feature... Abandoning.

Could somebody look at this patch?

• Rebase to a version from yesterday with working Windows build.

• Rebasing to current main to resolve unrelated CI failures.

Do these tests provide value beyond finding out how __str__ and pybind11 interact? If yes, I guess I'll rebase this patch on top of https://reviews.llvm.org/D159255 and land (after approval)...

• Rebase to resolve unrelated CI problems.

I agree. I'll investigate tomorrow when I am back at work.

• Add file I forgot to add in the initial revision.

• Fix mix-in by adding default type for new result value.

Sorry, I meant to submit this patch as a draft but forgot to add the flag. If somebody knows how to convert it to a patch, please let me know; otherwise, you'll be spammed by my updates to the patch... :S

OK, done! Unfortunately, I show up as an author now on git. I spend a bit of time trying to find out who was going to be the author and how to make sure it remains you but I didn't find anything. Turns out that the one who lands becomes the author...

• Fix type hints.
• Add test for StringAttr padding value.

Thanks for notifying! I just pushed d7e26b56207cbd8995296c5bb7c11ce676b649da to fix it.

The original patch has been reviewed and the update is trivial. Will self-accept when CI has passed.

Trivial change, will self-accept once CI passed.

• Rebase onto current main (with merge conflict).

• Changing CHECK directives as suggested by @springerm.

Aha, the vertical bar for type hi ts only exists since Python 3.10 (see https://peps.python.org/pep-0604/) and some downstream tests run Python 3.8. Will fix and reapply later.

• Fix unit test.