Page MenuHomePhabricator

ingomueller-net (Ingo Müller)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 18 2021, 7:23 AM (62 w, 3 d)

Recent Activity

Wed, Jan 25

ingomueller-net committed rGb0e4d389d33b: [mlir][scf] Fix typo in comment in BufferizableOpInterfaceImpl.cpp (NFC). (authored by ingomueller-net).
[mlir][scf] Fix typo in comment in BufferizableOpInterfaceImpl.cpp (NFC).
Wed, Jan 25, 11:06 AM · Restricted Project, Restricted Project
ingomueller-net closed D142554: [mlir][scf] Fix typo in comment in BufferizableOpInterfaceImpl.cpp (NFC)..
Wed, Jan 25, 11:06 AM · Restricted Project, Restricted Project
ingomueller-net accepted D142554: [mlir][scf] Fix typo in comment in BufferizableOpInterfaceImpl.cpp (NFC)..

Single-character comment-only fix --> self-accepting.

Wed, Jan 25, 11:05 AM · Restricted Project, Restricted Project
ingomueller-net retitled D142554: [mlir][scf] Fix typo in comment in BufferizableOpInterfaceImpl.cpp (NFC). from [mlir][scf] Fix typo in comment in BufferizableOpInterfaceImpl.cpp. to [mlir][scf] Fix typo in comment in BufferizableOpInterfaceImpl.cpp (NFC)..
Wed, Jan 25, 8:23 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D142554: [mlir][scf] Fix typo in comment in BufferizableOpInterfaceImpl.cpp (NFC)..
Wed, Jan 25, 8:23 AM · Restricted Project, Restricted Project
ingomueller-net committed rG4313af3750b2: [mlir] Improve line breaks of code snippets in comments (NFC). (authored by ingomueller-net).
[mlir] Improve line breaks of code snippets in comments (NFC).
Wed, Jan 25, 5:06 AM · Restricted Project, Restricted Project
ingomueller-net closed D142528: [mlir] Improve line breaks of code snippets in comments (NFC)..
Wed, Jan 25, 5:05 AM · Restricted Project, Restricted Project
ingomueller-net accepted D142528: [mlir] Improve line breaks of code snippets in comments (NFC)..

White-space-in-comments only change and builds passing: self-accepting.

Wed, Jan 25, 5:05 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D142528: [mlir] Improve line breaks of code snippets in comments (NFC)..
Wed, Jan 25, 2:06 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D142525: [mlir] Add RewriterBase::replaceAllUsesWith for Blocks..

Please review carefully; this is just copy'n'pasting from similar places and I am not sure whether this actually does the notification that is required.

Wed, Jan 25, 1:00 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D142525: [mlir] Add RewriterBase::replaceAllUsesWith for Blocks..
Wed, Jan 25, 12:56 AM · Restricted Project, Restricted Project

Dec 14 2022

ingomueller-net committed rG3a43e68ed1cb: Allow inline of all pure ops from the LLVM dialect. (authored by ingomueller-net).
Allow inline of all pure ops from the LLVM dialect.
Dec 14 2022, 7:19 AM · Restricted Project, Restricted Project
ingomueller-net closed D139187: Allow inline of all pure ops from the LLVM dialect..
Dec 14 2022, 7:18 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D139187: Allow inline of all pure ops from the LLVM dialect..

Add missing new line at end of file.

Dec 14 2022, 7:17 AM · Restricted Project, Restricted Project

Dec 5 2022

ingomueller-net added a comment to D139187: Allow inline of all pure ops from the LLVM dialect..

I have investigate a bit more on the limitation of allowing only pure ops to be inlined. I have found two that I would like to be inlinable for my use case and where I don't see any reason that they shouldn't be:

Dec 5 2022, 2:25 AM · Restricted Project, Restricted Project

Dec 2 2022

ingomueller-net added a comment to D139187: Allow inline of all pure ops from the LLVM dialect..

Two comments:

Dec 2 2022, 3:24 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D139187: Allow inline of all pure ops from the LLVM dialect..
Dec 2 2022, 3:07 AM · Restricted Project, Restricted Project

Jul 22 2022

ingomueller-net added a comment to D130271: [mlir][python] Fix issues with block argument slices.

Awesome, thanks! I confirm that this makes the code run that I had initially problems with!

Jul 22 2022, 1:21 AM · Restricted Project, Restricted Project

Jul 20 2022

ingomueller-net committed rG000e4264492e: [mlir][bufferize][doc] Fix documentation of return type of `to_memref`. (authored by ingomueller-net).
[mlir][bufferize][doc] Fix documentation of return type of `to_memref`.
Jul 20 2022, 6:22 AM · Restricted Project, Restricted Project
ingomueller-net closed D130159: [mlir][bufferize][doc] Fix documentation of return type of `to_memref`..
Jul 20 2022, 6:22 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D130159: [mlir][bufferize][doc] Fix documentation of return type of `to_memref`..
Jul 20 2022, 5:06 AM · Restricted Project, Restricted Project

Jul 15 2022

ingomueller-net committed rGb9f5b02fd071: [mlir][mbr] Improve diagnostics on error with `raise from`. (authored by ingomueller-net).
[mlir][mbr] Improve diagnostics on error with `raise from`.
Jul 15 2022, 8:16 AM · Restricted Project, Restricted Project
ingomueller-net closed D129762: [mlir][mbr] Improve diagnostics on error with `raise from`..
Jul 15 2022, 8:16 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D129762: [mlir][mbr] Improve diagnostics on error with `raise from`..

Updating D129762: [mlir][mbr] Improve diagnostics on error with raise from.

Jul 15 2022, 12:31 AM · Restricted Project, Restricted Project
ingomueller-net committed rG5da5483ffb40: [mlir][benchmark] Fix import in sparse benchmark. (authored by ingomueller-net).
[mlir][benchmark] Fix import in sparse benchmark.
Jul 15 2022, 12:16 AM · Restricted Project, Restricted Project
ingomueller-net closed D129738: [mlir][benchmark] Fix import in sparse benchmark..
Jul 15 2022, 12:16 AM · Restricted Project, Restricted Project

Jul 14 2022

ingomueller-net added a comment to D125236: [mlir][doc] Fix usage of PatternApplicator..

It seems like this is the inverse direction than what is needed: The constructor you point to constructs a FrozenRewritePatternSet from a RewritePatternSet (which freezes the set); however, in the example, we have a FrozenRewritepatternSet that is given to a function that expected a RewritePatternSet (which would "unfreeze" the set, which I guess shouldn't be possible). My commit makes the function accept a FrozenRewritePatternSet instead, but one could also never freeze it in the first place. I don't really understand the code, so any more informed suggestions are welcome!

Jul 14 2022, 6:28 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D129762: [mlir][mbr] Improve diagnostics on error with `raise from`..
Jul 14 2022, 5:21 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D129738: [mlir][benchmark] Fix import in sparse benchmark..

Updating D129738: [mlir][benchmark] Fix import in sparse benchmark.

Jul 14 2022, 5:00 AM · Restricted Project, Restricted Project
ingomueller-net committed rGd4a7ca81feb4: [mlir][doc] Fix usage of PatternApplicator. (authored by ingomueller-net).
[mlir][doc] Fix usage of PatternApplicator.
Jul 14 2022, 2:08 AM · Restricted Project, Restricted Project
ingomueller-net closed D125236: [mlir][doc] Fix usage of PatternApplicator..
Jul 14 2022, 2:08 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D129738: [mlir][benchmark] Fix import in sparse benchmark..

Hold on, I am not sure whether this fixes all problems :S

Jul 14 2022, 1:10 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D129738: [mlir][benchmark] Fix import in sparse benchmark..
Jul 14 2022, 1:07 AM · Restricted Project, Restricted Project

May 9 2022

ingomueller-net requested review of D125236: [mlir][doc] Fix usage of PatternApplicator..
May 9 2022, 8:06 AM · Restricted Project, Restricted Project

Apr 20 2022

ingomueller-net added a comment to D123999: [mlir][docs] Add missing parentheses in example code on walkers..

Yes :) Landed!

Apr 20 2022, 2:44 AM · Restricted Project, Restricted Project
ingomueller-net committed rG1fe1f913c548: [mlir][docs] Add missing parentheses in example code on walkers. (authored by ingomueller-net).
[mlir][docs] Add missing parentheses in example code on walkers.
Apr 20 2022, 2:44 AM · Restricted Project, Restricted Project
ingomueller-net closed D123999: [mlir][docs] Add missing parentheses in example code on walkers..
Apr 20 2022, 2:43 AM · Restricted Project, Restricted Project

Apr 19 2022

ingomueller-net requested review of D123999: [mlir][docs] Add missing parentheses in example code on walkers..
Apr 19 2022, 6:21 AM · Restricted Project, Restricted Project

Mar 30 2022

ingomueller-net committed rGe124f73b52ad: [mlir][docs] Convert block comments to line comments. (authored by ingomueller-net).
[mlir][docs] Convert block comments to line comments.
Mar 30 2022, 1:09 AM · Restricted Project, Restricted Project
ingomueller-net closed D122565: [mlir][docs] Convert block comments to line comments..
Mar 30 2022, 1:08 AM · Restricted Project, Restricted Project
ingomueller-net accepted D122565: [mlir][docs] Convert block comments to line comments..
Mar 30 2022, 1:04 AM · Restricted Project, Restricted Project

Mar 28 2022

ingomueller-net published D122565: [mlir][docs] Convert block comments to line comments. for review.

@nicolasvasilache: I couldn't find out how to get this revision out of draft mode but I am done with it.

Mar 28 2022, 2:32 AM · Restricted Project, Restricted Project

Mar 17 2022

ingomueller-net added a comment to D114165: [mlir][docs] Fix formatting issue in Dialects/Vector.md..

I don't have the permission; can someone land this for me?

Mar 17 2022, 2:21 AM · Restricted Project, Restricted Project
ingomueller-net updated the diff for D114165: [mlir][docs] Fix formatting issue in Dialects/Vector.md..

Rebasing to latest main. I had not understood the review process
when I submitted the first revision some months ago, so this
change never got landed...

Mar 17 2022, 2:19 AM · Restricted Project, Restricted Project

Mar 16 2022

ingomueller-net added a comment to D121814: Fix link to Rationale document from doc on tuple..

I don't have permission, can someone land this for me?

Mar 16 2022, 1:44 PM · Restricted Project, Restricted Project
ingomueller-net published D121814: Fix link to Rationale document from doc on tuple. for review.
Mar 16 2022, 8:40 AM · Restricted Project, Restricted Project

Nov 22 2021

ingomueller-net updated the diff for D114165: [mlir][docs] Fix formatting issue in Dialects/Vector.md..

Applying changes suggested by nicolasvasilache

Nov 22 2021, 1:10 AM · Restricted Project, Restricted Project

Nov 18 2021

ingomueller-net updated the diff for D114165: [mlir][docs] Fix formatting issue in Dialects/Vector.md..

Fix another formatting issue.

Nov 18 2021, 8:07 AM · Restricted Project, Restricted Project
ingomueller-net added a comment to D114165: [mlir][docs] Fix formatting issue in Dialects/Vector.md..

Actually, I think that this needs more fixing but I am not too sure how it should look like.

Nov 18 2021, 7:54 AM · Restricted Project, Restricted Project
ingomueller-net requested review of D114165: [mlir][docs] Fix formatting issue in Dialects/Vector.md..
Nov 18 2021, 7:50 AM · Restricted Project, Restricted Project