Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D159407

[BOLT] Incorporate umask into the output file permission
ClosedPublic
Actions

Authored by Kepontry on Sat, Sep 2, 9:13 PM.

Details

Reviewers
maksfb
rafauler
hzq
Amir
yota9
Commits
rG473b9dd442e4: [BOLT] Incorporate umask into the output file permission
Summary

Fix https://github.com/llvm/llvm-project/issues/65061

Diff Detail

Event Timeline

Kepontry created this revision.Sat, Sep 2, 9:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Sep 2, 9:13 PM
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
Kepontry requested review of this revision.Sat, Sep 2, 9:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Sep 2, 9:13 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B256437: Diff 555611.Sat, Sep 2, 9:19 PM
Amir added a comment.Sun, Sep 3, 4:35 PM

Thank you for taking care of it. Can you please also add a test?

Amir added a comment.Sun, Sep 3, 4:36 PM
This comment was removed by Amir.
Kepontry updated this revision to Diff 556539.Tue, Sep 12, 2:31 AM
Harbormaster completed remote builds in B257048: Diff 556539.Tue, Sep 12, 6:44 AM
Kepontry added a comment.Tue, Sep 12, 6:22 PM

Add a testcase.

hans added a subscriber: hans.Wed, Sep 13, 5:25 AM
Amir accepted this revision.Fri, Sep 15, 7:32 AM

Thank you for the fix and the test!

This revision is now accepted and ready to land.Fri, Sep 15, 7:32 AM
maksfb accepted this revision.Fri, Sep 15, 1:01 PM
Closed by commit rG473b9dd442e4: [BOLT] Incorporate umask into the output file permission (authored by Kepontry, committed by hezuoqiang <hezuoqiang2@huawei.com>). · Explain WhySat, Sep 16, 9:13 AM
This revision was automatically updated to reflect the committed changes.
hezuoqiang <hezuoqiang2@huawei.com> added a commit: rG473b9dd442e4: [BOLT] Incorporate umask into the output file permission.

Revision Contents
Changeset List

PathSize
bolt/
lib/
Rewrite/
6 lines
5 lines
test/
13 lines

Diff 556896

View Options

bolt/lib/Rewrite/MachORewriteInstance.cpp

Loading...
View Options

bolt/lib/Rewrite/RewriteInstance.cpp

Loading...
View Options

bolt/test/permission.test

Loading...