This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Fix incorrect handling of nested `#ifndef` directives
ClosedPublic

Authored by myhsu on Aug 30 2023, 4:17 PM.

Details

Summary

TableGen's lexer was unable to handle nested #ifndef when the outer #ifdef / #ifndef scope is subject to skip. This was caused by returning the canonicalized token when it should have returned the original one.

Fix #65100 .

Diff Detail

Event Timeline

myhsu created this revision.Aug 30 2023, 4:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2023, 4:17 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
myhsu requested review of this revision.Aug 30 2023, 4:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2023, 4:17 PM
mehdi_amini accepted this revision.Sep 6 2023, 4:13 PM
This revision is now accepted and ready to land.Sep 6 2023, 4:13 PM
This revision was landed with ongoing or failed builds.Sep 7 2023, 12:58 PM
This revision was automatically updated to reflect the committed changes.