This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Improve mask detection in `foldICmpWithLowBitMaskedVal`
AbandonedPublic

Authored by goldstein.w.n on Aug 28 2023, 9:29 PM.

Details

Summary

Make recursive matcher that is able to detect a lot more patterns.
Proofs for all supported patterns: https://alive2.llvm.org/ce/z/fSQ3nZ

Diff Detail

Event Timeline

goldstein.w.n created this revision.Aug 28 2023, 9:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 9:29 PM
goldstein.w.n requested review of this revision.Aug 28 2023, 9:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 9:29 PM
nikic added a comment.Aug 29 2023, 3:55 AM

I thin this patch does too many changes at the same time. Can we separate support for the zero pattern from the recursive mask recognition?

Make this commit masks only

goldstein.w.n retitled this revision from [InstCombine] Improve scope of `foldICmpWithLowBitMaskedVal` to [InstCombine] Improve mask detection in `foldICmpWithLowBitMaskedVal`.Aug 31 2023, 6:33 PM
goldstein.w.n edited the summary of this revision. (Show Details)
goldstein.w.n edited the summary of this revision. (Show Details)

Rebase

goldstein.w.n abandoned this revision.Sep 19 2023, 9:09 AM

Abandoning and resubmitting on GH