eq (and X, Y), X)`
Needs ReviewPublic
Actions

Authored by goldstein.w.n on Mon, Mar 6, 2:16 PM.

Details

Reviewers

nikic
spatel
majnemer

Summary

eq/ne are generally easier to reason about elsewhere.

ult -> ne: https://alive2.llvm.org/ce/z/5wxXGt
uge -> eq: https://alive2.llvm.org/ce/z/Dw6kqG

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

goldstein.w.n created this revision.Mon, Mar 6, 2:16 PM

Herald added a project: Restricted Project. · View Herald TranscriptMon, Mar 6, 2:16 PM

Herald added a subscriber: hiraditya. · View Herald Transcript

goldstein.w.n requested review of this revision.Mon, Mar 6, 2:16 PM

Herald added a project: Restricted Project. · View Herald TranscriptMon, Mar 6, 2:16 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

goldstein.w.n added a child revision: D145426: [InstCombine] Add transforms `(icmp spred (and X, Y), X)` if `X` or `Y` are known signed/unsigned.Mon, Mar 6, 2:18 PM

goldstein.w.n added reviewers: nikic, spatel, majnemer.

Herald added a subscriber: StephenFan. · View Herald TranscriptMon, Mar 6, 2:18 PM

goldstein.w.n added a parent revision: D145424: [InstCombine] Add tests for transforming `(icmp pred (and X, Y), X)`; NFC.Mon, Mar 6, 2:18 PM

Harbormaster completed remote builds in B217705: Diff 502803.Mon, Mar 6, 7:23 PM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

InstCombine/

InstCombineCompares.cpp

26 lines

test/

Transforms/

InstCombine/

canonicalize-constant-low-bit-mask-and-icmp-uge-to-icmp-ule.ll

14 lines

canonicalize-constant-low-bit-mask-and-icmp-ugt-to-icmp-ugt.ll

6 lines

canonicalize-constant-low-bit-mask-and-icmp-ule-to-icmp-ule.ll

6 lines

canonicalize-constant-low-bit-mask-and-icmp-ult-to-icmp-ugt.ll

6 lines

icmp-of-and-x.ll

8 lines

Diff 502803

View Options

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

View Options

llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-uge-to-icmp-ule.ll

View Options

llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ugt-to-icmp-ugt.ll

View Options

llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ule-to-icmp-ule.ll

View Options

llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ult-to-icmp-ugt.ll

View Options

llvm/test/Transforms/InstCombine/icmp-of-and-x.ll

[InstCombine] Transform `(icmp ult/uge (and X, Y), X)` -> `(icmp ne/eq (and X, Y), X)`Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 502803

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-uge-to-icmp-ule.ll

llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ugt-to-icmp-ugt.ll

llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ule-to-icmp-ule.ll

llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ult-to-icmp-ugt.ll

llvm/test/Transforms/InstCombine/icmp-of-and-x.ll

[InstCombine] Transform `(icmp ult/uge (and X, Y), X)` -> `(icmp ne/eq (and X, Y), X)`
Needs ReviewPublic
Actions

Revision Contents
Changeset List