This is an archive of the discontinued LLVM Phabricator instance.

Differential D159003

[OpenMP] Disable intermittently failing OpenMP test on AMD GPU
ClosedPublic

Authored by doru1004 on Aug 28 2023, 9:30 AM.

Download Raw Diff

Details

Reviewers

ronl
jdoerfert
jplehr
dhruvachak
carlo.bertolli
tianshilei1992
ronlieb

Summary

For now, we need to disable this test due its intermittent failing mode.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

doru1004 created this revision.Aug 28 2023, 9:30 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 9:30 AM

Herald added subscribers: guansong, yaxunl. · View Herald Transcript

doru1004 requested review of this revision.Aug 28 2023, 9:30 AM

Herald added subscribers: openmp-commits, sstefan1. · View Herald TranscriptAug 28 2023, 9:30 AM

doru1004 added a reviewer: tianshilei1992.Aug 28 2023, 9:30 AM

thx, lgtm

This revision is now accepted and ready to land.Aug 28 2023, 9:31 AM

Harbormaster completed remote builds in B255247: Diff 553966.Aug 28 2023, 9:33 AM

This should really be a AMDGPU bug, but I'm fine with disabling it.

In D159003#4621766, @tianshilei1992 wrote:

This should really be a AMDGPU bug, but I'm fine with disabling it.

We want to prevent the buidlbot from throwing too many false alarms while we look into this.

Doru Bercea <doru.bercea@amd.com> mentioned this in rG5fe6f56563a3: Disable intermittently failing OpenMP test..Aug 28 2023, 9:56 AM

Commit: 5fe6f56563a3f727c9387e87d3a797292eb4980f

Revision Contents

Path

Size

openmp/

libomptarget/

test/

offloading/

memory_manager.cpp

1 line

Diff 553966

openmp/libomptarget/test/offloading/memory_manager.cpp

	// RUN: %libomptarget-compilexx-run-and-check-generic			// RUN: %libomptarget-compilexx-run-and-check-generic

				// UNSUPPORTED: amdgcn-amd-amdhsa
	// UNSUPPORTED: x86_64-pc-linux-gnu			// UNSUPPORTED: x86_64-pc-linux-gnu
	// UNSUPPORTED: x86_64-pc-linux-gnu-LTO			// UNSUPPORTED: x86_64-pc-linux-gnu-LTO

	#include <omp.h>			#include <omp.h>

	#include <cassert>			#include <cassert>
	#include <iostream>			#include <iostream>

	Show All 35 Lines