powr is just pow with the assumption that x >= 0, otherwise nan. This
fires at least 6 times in luxmark
Details
Details
Diff Detail
Diff Detail
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp | ||
---|---|---|
855 | Can you check the value before inserting declaration? Just to avoid unused declarations. Plus the way it is now you may return false when you have actually modified the module. |
Comment Actions
Fix not hitting the other edge case folds
llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp | ||
---|---|---|
855 | Nothing else in the pass bothers trying to avoid declarations, globaldce is going to run after anyway. Plus it's quite possibly more expensive to do the recursive value check than to just insert and delete the unused declaration later |
Can you check the value before inserting declaration? Just to avoid unused declarations. Plus the way it is now you may return false when you have actually modified the module.