Fix static analyzer concerns about null value reference
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM
clang/include/clang/ExtractAPI/ExtractAPIVisitor.h | ||
---|---|---|
269–271 | NIT: It's not immediately obvious that the check if (Decl->isStaticDataMember()) guarantees that Decl->getDeclContext() is a RecordDecl. Would you mind adding a comment static that? |
clang/lib/ExtractAPI/DeclarationFragments.cpp | ||
---|---|---|
691–693 | Maybe we can just do this, so we don't isa two times. |
NIT: It's not immediately obvious that the check if (Decl->isStaticDataMember()) guarantees that Decl->getDeclContext() is a RecordDecl. Would you mind adding a comment static that?