[NFC][Clang] Fix static analyzer concerns

[eandrews]

Summary

Fix static analyzer concerns about null value reference

[dang]

LGTM

clang/include/clang/ExtractAPI/ExtractAPIVisitor.h

269–271

NIT: It's not immediately obvious that the check if (Decl->isStaticDataMember()) guarantees that Decl->getDeclContext() is a RecordDecl. Would you mind adding a comment static that?

[Fznamznon]

clang/lib/ExtractAPI/DeclarationFragments.cpp

691–693

Maybe we can just do this, so we don't isa two times.

[aaron.ballman]

LGTM with some nits

clang/include/clang/ExtractAPI/ExtractAPIVisitor.h

269–271

clang/lib/ExtractAPI/DeclarationFragments.cpp

691–693

+1 to this, isa followed by cast is a code smell.

[eandrews]

Thanks for the reviews! Requested changes have been made in latest patch

clang/include/clang/ExtractAPI/ExtractAPIVisitor.h

bool ExtractAPIVisitorBase<Derived>::VisitVarDecl(const VarDecl *Decl) {
   // Build declaration fragments and sub-heading for the variable.
   DeclarationFragments Declaration =
       DeclarationFragmentsBuilder::getFragmentsForVar(Decl);
   DeclarationFragments SubHeading =
       DeclarationFragmentsBuilder::getSubHeading(Decl);
 
   if (Decl->isStaticDataMember()) {
     SymbolReference Context;
-    auto Record = dyn_cast<RecordDecl>(Decl->getDeclContext());
+    // getDeclContext() should return a RecordDecl since we
+    // are currently handling a static data member.
+    auto *Record = cast<RecordDecl>(Decl->getDeclContext());
     Context.Name = Record->getName();
     Context.USR = API.recordUSR(Record);
     auto Access = DeclarationFragmentsBuilder::getAccessControl(Decl);
     API.addStaticField(Name, USR, Loc, AvailabilitySet(Decl), Linkage, Comment,
                        Declaration, SubHeading, Context, Access,
                        isInSystemHeader(Decl));
   } else
     // Add the global variable record to the API set.

clang/lib/ExtractAPI/DeclarationFragments.cpp

DeclarationFragments DeclarationFragmentsBuilder::getFragmentsForCXXClass(
   return Fragments.append(";", DeclarationFragments::FragmentKind::Text);
 }
 
 DeclarationFragments
 DeclarationFragmentsBuilder::getFragmentsForSpecialCXXMethod(
     const CXXMethodDecl *Method) {
   DeclarationFragments Fragments;
   std::string Name;
-  if (isa<CXXConstructorDecl>(Method)) {
+  if (const auto *Constructor = dyn_cast<CXXConstructorDecl>(Method)) {
     Name = Method->getNameAsString();
-    if (dyn_cast<CXXConstructorDecl>(Method)->isExplicit())
+    if (Constructor->isExplicit())
       Fragments.append("explicit", DeclarationFragments::FragmentKind::Keyword)
           .appendSpace();
   } else if (isa<CXXDestructorDecl>(Method))
     Name = Method->getNameAsString();
 
   DeclarationFragments After;
   Fragments.append(Name, DeclarationFragments::FragmentKind::Identifier)
       .append(std::move(After));

clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

struct SpecialMemberTypeInfoRebuilder
 
         RecordTypeLoc NewTL = TLB.push<RecordTypeLoc>(Result);
         NewTL.setNameLoc(TL.getNameLoc());
         return Result;
       }
     } IR{*this, PatternRec, NewRec};
 
     TypeSourceInfo *NewSI = IR.TransformType(Function->getTypeSourceInfo());
+    assert(NewSI && "Type Transform failed?");
     Function->setType(NewSI->getType());
     Function->setTypeSourceInfo(NewSI);
 
     ParmVarDecl *Parm = Function->getParamDecl(0);
     TypeSourceInfo *NewParmSI = IR.TransformType(Parm->getTypeSourceInfo());
     Parm->setType(NewParmSI->getType());
     Parm->setTypeSourceInfo(NewParmSI);
   };