This is an archive of the discontinued LLVM Phabricator instance.

Differential D158560

access time is not reliably preserved on darwin
AbandonedPublic

Authored by hiraditya on Aug 22 2023, 3:36 PM.

Details

Reviewers
bogner
alexander-shaposhnikov
jhenderson
Summary

ninja check-llvm-tools-llvm-objcopy sometimes passes and sometimes fails on llvm-project/llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test

https://github.com/llvm/llvm-project/issues/64908

Diff Detail

Event Timeline

hiraditya created this revision.Aug 22 2023, 3:36 PM
Herald added a reviewer: alexander-shaposhnikov. · View Herald TranscriptAug 22 2023, 3:36 PM
Herald added a reviewer: jhenderson. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: emaste. · View Herald Transcript
hiraditya requested review of this revision.Aug 22 2023, 3:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2023, 3:36 PM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B254207: Diff 552521.Aug 22 2023, 4:52 PM
jhenderson added inline comments.Aug 22 2023, 11:49 PM
llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
4–6

Please add a comment explaining why this is disabled on Darwin (with an explanation of the actual cause of the test failure, not simply "it sometimes fails"). Ideally, if it's something fixable, we'd have an issue created for it, with the comment referencing that.

hiraditya updated this revision to Diff 553191.Aug 24 2023, 10:48 AM

Added link to issue in the testcase.

hiraditya marked an inline comment as done.Aug 24 2023, 10:48 AM
Harbormaster completed remote builds in B254671: Diff 553191.Aug 24 2023, 1:17 PM
jhenderson added a comment.Aug 24 2023, 11:49 PM

Functionally, the change does what it says it does, and I have no issues with that. However, the discussion in the ticket seems to suggest this isn't a general issue in Darwin, but rather something about your system setup. That needs resolving before this lands.

hiraditya abandoned this revision.Sep 15 2023, 10:16 AM

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
ELF/
4 lines

Diff 553191

llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test

# Note: ls -lu prints the accessed timestamp # Note: ls -lu prints the accessed timestamp
# NetBSD: noatime mounts currently inhibit 'touch -a' updates # NetBSD: noatime mounts currently inhibit 'touch -a' updates
# Windows: the last access time is disabled by default in the OS # Windows: the last access time is disabled by default in the OS
# UNSUPPORTED: system-netbsd, system-windows # Darwin: The test fails frequently because atime gets modified randomly
# Darwin: https://github.com/llvm/llvm-project/issues/64908
# UNSUPPORTED: system-netbsd, system-windows, system-darwin
jhendersonUnsubmitted
Done
ReplyInline Actions

Please add a comment explaining why this is disabled on Darwin (with an explanation of the actual cause of the test failure, not simply "it sometimes fails"). Ideally, if it's something fixable, we'd have an issue created for it, with the comment referencing that.

jhenderson: Please add a comment explaining why this is disabled on Darwin (with an explanation of the…
# Preserve dates when stripping to an output file. # Preserve dates when stripping to an output file.
# RUN: yaml2obj %s -o %t.1.o # RUN: yaml2obj %s -o %t.1.o
# RUN: touch -a -t 199505050555.55 %t.1.o # RUN: touch -a -t 199505050555.55 %t.1.o
# RUN: llvm-strip -p %t.1.o -o %t-preserved.1.o # RUN: llvm-strip -p %t.1.o -o %t-preserved.1.o
# RUN: ls -lu %t-preserved.1.o | FileCheck %s --check-prefix=CHECK-PRESERVE-ATIME # RUN: ls -lu %t-preserved.1.o | FileCheck %s --check-prefix=CHECK-PRESERVE-ATIME
# Check that the stripped output is in fact a valid object file. # Check that the stripped output is in fact a valid object file.
# RUN: llvm-readobj %t-preserved.1.o # RUN: llvm-readobj %t-preserved.1.o
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines