This is an archive of the discontinued LLVM Phabricator instance.

[builtins][AArch64] Implement _sync out-of-line atomics
ClosedPublic

Authored by jrtc27 on Aug 22 2023, 11:58 AM.

Details

Summary

Whilst Clang does not use these, recent GCC does, and so on systems such
as FreeBSD that wish to use compiler-rt as the system runtime library
but also wish to support building programs with GCC these interfaces are
needed.

This is a light adaptation of the code committed to GCC by Sebastian Pop
<spop@amazon.com>, relicensed with permission for use in compiler-rt.

Fixes https://github.com/llvm/llvm-project/issues/63483

Diff Detail

Event Timeline

jrtc27 created this revision.Aug 22 2023, 11:58 AM
jrtc27 requested review of this revision.Aug 22 2023, 11:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2023, 11:58 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
sebpop accepted this revision.Aug 22 2023, 7:01 PM
sebpop added a subscriber: sebpop.

Looks good to me.
Thank you.

This revision is now accepted and ready to land.Aug 22 2023, 7:01 PM
jrtc27 updated this revision to Diff 553228.Aug 24 2023, 12:21 PM

Updated documentation comments at top of file

jrtc27 edited the summary of this revision. (Show Details)Aug 24 2023, 12:24 PM

Ping for a compiler-rt-facing person's review?

MaskRay accepted this revision.Sep 3 2023, 4:36 PM
This revision was automatically updated to reflect the committed changes.