This is an archive of the discontinued LLVM Phabricator instance.

Differential D158430

[flang][driver] Mark -fuse-ld as visible in Flang
ClosedPublic

Authored by erjin on Aug 21 2023, 8:33 AM.

Download Raw Diff

Details

Reviewers

sscalpone
awarzynski
bryanpkc
kiranchandramohan

Commits

rGdc8e46c7e5ea: [flang][driver] Mark -fuse-ld as visible in Flang

Summary

The option fuse-ld is not visible in Flang. Flang reports "Unknown argument: '-fuse-ld' during linker stage.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	94,900 ms	clang CI - Running libc++ test suite with Clang Modules > llvm-libc++-shared-cfg-in.llvm-libc++-shared-cfg-in::/var/lib/buildkite-agent/builds/llvm-project/build/generic-modules/test/libcxx/modules_include.gen.py/__std_clang_module.compile.pass.mm

Event Timeline

erjin created this revision.Aug 21 2023, 8:33 AM

Herald added a reviewer: sscalpone. · View Herald TranscriptAug 21 2023, 8:33 AM

Herald added a reviewer: awarzynski. · View Herald Transcript

Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

erjin requested review of this revision.Aug 21 2023, 8:33 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 8:33 AM

Herald added subscribers: cfe-commits, jdoerfert. · View Herald Transcript

erjin edited the summary of this revision. (Show Details)Aug 21 2023, 8:36 AM

erjin added reviewers: bryanpkc, kiranchandramohan.

Harbormaster completed remote builds in B253861: Diff 552034.Aug 21 2023, 9:10 AM

Thanks.

This revision is now accepted and ready to land.Aug 21 2023, 9:16 AM

Rebase

In D158430#4603925, @kiranchandramohan wrote:

Thanks.

Thank you for the review!

Harbormaster completed remote builds in B253882: Diff 552068.Aug 21 2023, 11:03 AM

erjin updated this revision to Diff 552091.Aug 21 2023, 11:47 AM

This comment was removed by erjin.

Harbormaster completed remote builds in B253896: Diff 552091.Aug 21 2023, 12:45 PM

awarzynski accepted this revision.Aug 21 2023, 1:22 PM

Rebase

Harbormaster completed remote builds in B254187: Diff 552498.Aug 22 2023, 2:26 PM

@erjin Could you land this patch?

This revision was landed with ongoing or failed builds.Aug 23 2023, 9:44 AM

Closed by commit rGdc8e46c7e5ea: [flang][driver] Mark -fuse-ld as visible in Flang (authored by erjin, committed by bryanpkc). · Explain Why

This revision was automatically updated to reflect the committed changes.

bryanpkc added a commit: rGdc8e46c7e5ea: [flang][driver] Mark -fuse-ld as visible in Flang.

Revision Contents

Path

Size

clang/

include/

clang/

Driver/

2 lines

flang/

test/

Driver/

3 lines

Diff 552068

clang/include/clang/Driver/Options.td

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 5,879 Lines • ▼ Show 20 Lines
	def fbinutils_version_EQ : Joined<["-"], "fbinutils-version=">,			def fbinutils_version_EQ : Joined<["-"], "fbinutils-version=">,
	MetaVarName<"<major.minor>">, Group<f_Group>,			MetaVarName<"<major.minor>">, Group<f_Group>,
	Visibility<[ClangOption, CC1Option]>,			Visibility<[ClangOption, CC1Option]>,
	HelpText<"Produced object files can use all ELF features supported by this "			HelpText<"Produced object files can use all ELF features supported by this "
	"binutils version and newer. If -fno-integrated-as is specified, the "			"binutils version and newer. If -fno-integrated-as is specified, the "
	"generated assembly will consider GNU as support. 'none' means that all ELF "			"generated assembly will consider GNU as support. 'none' means that all ELF "
	"features can be used, regardless of binutils support. Defaults to 2.26.">;			"features can be used, regardless of binutils support. Defaults to 2.26.">;
	def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, Group<f_Group>,			def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, Group<f_Group>,
	Flags<[LinkOption]>, Visibility<[ClangOption, CLOption]>;			Flags<[LinkOption]>, Visibility<[ClangOption, FlangOption, CLOption]>;
	def ld_path_EQ : Joined<["--"], "ld-path=">, Group<Link_Group>;			def ld_path_EQ : Joined<["--"], "ld-path=">, Group<Link_Group>;

	defm align_labels : BooleanFFlag<"align-labels">, Group<clang_ignored_gcc_optimization_f_Group>;			defm align_labels : BooleanFFlag<"align-labels">, Group<clang_ignored_gcc_optimization_f_Group>;
	def falign_labels_EQ : Joined<["-"], "falign-labels=">, Group<clang_ignored_gcc_optimization_f_Group>;			def falign_labels_EQ : Joined<["-"], "falign-labels=">, Group<clang_ignored_gcc_optimization_f_Group>;
	defm align_loops : BooleanFFlag<"align-loops">, Group<clang_ignored_gcc_optimization_f_Group>;			defm align_loops : BooleanFFlag<"align-loops">, Group<clang_ignored_gcc_optimization_f_Group>;
	defm align_jumps : BooleanFFlag<"align-jumps">, Group<clang_ignored_gcc_optimization_f_Group>;			defm align_jumps : BooleanFFlag<"align-jumps">, Group<clang_ignored_gcc_optimization_f_Group>;
	def falign_jumps_EQ : Joined<["-"], "falign-jumps=">, Group<clang_ignored_gcc_optimization_f_Group>;			def falign_jumps_EQ : Joined<["-"], "falign-jumps=">, Group<clang_ignored_gcc_optimization_f_Group>;

	▲ Show 20 Lines • Show All 2,330 Lines • Show Last 20 Lines

flang/test/Driver/misc-flags.f90

	! Make sure that `-l` is "visible" to Flang's driver			! Make sure that `-l` is "visible" to Flang's driver
	! RUN: %flang -lpgmath -### %s			! RUN: %flang -lpgmath -### %s

	! Make sure that `-Wl` is "visible" to Flang's driver			! Make sure that `-Wl` is "visible" to Flang's driver
	! RUN: %flang -Wl,abs -### %s			! RUN: %flang -Wl,abs -### %s

				! Make sure that `-fuse-ld' is "visible" to Flang's driver
				! RUN: %flang -fuse-ld= -### %s

	program hello			program hello
	write(,), "Hello world!"			write(,), "Hello world!"
	end program hello			end program hello