This is an archive of the discontinued LLVM Phabricator instance.

[clang] [MinGW] Pass LTO options to the linker
ClosedPublic

Authored by mstorsjo on Aug 21 2023, 4:47 AM.

Download Raw Diff

Details

Reviewers

MaskRay
mati865

Commits

rGa23bf1786be7: [clang] [MinGW] Pass LTO options to the linker

Summary

This matches what is done on other platforms too.

This fixes one part of
https://github.com/mstorsjo/llvm-mingw/issues/349.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	88,240 ms	clang CI - Running libc++ test suite with Clang Modules > llvm-libc++-shared-cfg-in.llvm-libc++-shared-cfg-in::/var/lib/buildkite-agent/builds/llvm-project/build/generic-modules/test/libcxx/modules_include.gen.py/__std_clang_module.compile.pass.mm

Event Timeline

mstorsjo created this revision.Aug 21 2023, 4:47 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 4:47 AM

Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. · View Herald Transcript

mstorsjo requested review of this revision.Aug 21 2023, 4:47 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 4:47 AM

Harbormaster completed remote builds in B253820: Diff 551985.Aug 21 2023, 5:13 AM

mstorsjo added a reviewer: mati865.Aug 22 2023, 10:04 AM

LGTM

This revision is now accepted and ready to land.Aug 24 2023, 7:12 AM

This revision was landed with ongoing or failed builds.Aug 24 2023, 1:16 PM

Closed by commit rGa23bf1786be7: [clang] [MinGW] Pass LTO options to the linker (authored by mstorsjo). · Explain Why

This revision was automatically updated to reflect the committed changes.

mstorsjo added a commit: rGa23bf1786be7: [clang] [MinGW] Pass LTO options to the linker.

mstorsjo mentioned this in D158412: [LLD] [MinGW] Pass LLVM specific LTO options through to lld-link.Aug 24 2023, 1:18 PM

LGTM

Revision Contents

Path

Size

clang/

lib/

Driver/

ToolChains/

MinGW.cpp

6 lines

test/

Driver/

mingw-lto.c

4 lines

Diff 551985

clang/lib/Driver/ToolChains/MinGW.cpp

Show First 20 Lines • Show All 232 Lines • ▼ Show 20 Lines	if (TC.getVFS().exists(LibPath))
CmdArgs.push_back(Args.MakeArgString("-L" + LibPath));		CmdArgs.push_back(Args.MakeArgString("-L" + LibPath));
}		}
auto CRTPath = TC.getCompilerRTPath();		auto CRTPath = TC.getCompilerRTPath();
if (TC.getVFS().exists(CRTPath))		if (TC.getVFS().exists(CRTPath))
CmdArgs.push_back(Args.MakeArgString("-L" + CRTPath));		CmdArgs.push_back(Args.MakeArgString("-L" + CRTPath));

AddLinkerInputs(TC, Inputs, Args, CmdArgs, JA);		AddLinkerInputs(TC, Inputs, Args, CmdArgs, JA);

		if (D.isUsingLTO()) {
		assert(!Inputs.empty() && "Must have at least one input.");
		addLTOOptions(TC, Args, CmdArgs, Output, Inputs[0],
		D.getLTOMode() == LTOK_Thin);
		}

if (C.getDriver().IsFlangMode()) {		if (C.getDriver().IsFlangMode()) {
addFortranRuntimeLibraryPath(TC, Args, CmdArgs);		addFortranRuntimeLibraryPath(TC, Args, CmdArgs);
addFortranRuntimeLibs(TC, CmdArgs);		addFortranRuntimeLibs(TC, CmdArgs);
}		}

// TODO: Add profile stuff here		// TODO: Add profile stuff here

if (TC.ShouldLinkCXXStdlib(Args)) {		if (TC.ShouldLinkCXXStdlib(Args)) {
▲ Show 20 Lines • Show All 562 Lines • Show Last 20 Lines

clang/test/Driver/mingw-lto.c

	// The default linker doesn't support LLVM bitcode			// The default linker doesn't support LLVM bitcode
	// RUN: not %clang --target=i686-pc-windows-gnu %s -flto -fuse-ld=bfd			// RUN: not %clang --target=i686-pc-windows-gnu %s -flto -fuse-ld=bfd
	// When using lld, this is allowed though.			// When using lld, this is allowed though.
	// RUN: %clang --target=i686-pc-windows-gnu -### %s -flto -fuse-ld=lld -B%S/Inputs/lld			// RUN: %clang --target=i686-pc-windows-gnu -### %s -flto -fuse-ld=lld -B%S/Inputs/lld -femulated-tls 2>&1 \| FileCheck %s

				// CHECK: "-plugin-opt=-emulated-tls"