This is an archive of the discontinued LLVM Phabricator instance.

Clang/MIPS: computeTargetTriple considering -march option
Needs ReviewPublic

Authored by wzssyqa on Aug 17 2023, 7:25 AM.

Details

Summary

If -march=mips32r6 or -march=mips64r6 option is given,
we should set SubArch to llvm::Triple::MipsSubArch_r6.

Thus the default triple will become

mipsisa32r6(el)-*

or

mipsisa64r6(el)-*.

Diff Detail

Event Timeline

wzssyqa created this revision.Aug 17 2023, 7:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 7:25 AM
wzssyqa requested review of this revision.Aug 17 2023, 7:25 AM

Such driver changes without tests cannot be accepted. It's likely someone wants to clean up the code. Without testing they cannot know whether they would break your cases.

wzssyqa updated this revision to Diff 552331.Aug 22 2023, 6:24 AM
wzssyqa edited the summary of this revision. (Show Details)
brad added a comment.Oct 21 2023, 3:56 AM

@wzssyqa You see from the build that one of the tests is currently failing?

OK, Since the CI cannot work with Phabricator shutdown timeline, I will update it and migrate it to GitHub.

OK, Since the CI cannot work with Phabricator shutdown timeline, I will update it and migrate it to GitHub.

The CI is shared. You are not forced to migrate. Actually, I think migrating is semi-discouraged.

Actually, I think migrating is semi-discouraged.

More than that, there's the big red banner at the top that explicitly says not to do that, which you kindly added to the site after I suggested it to avoid people doing precisely this kind of migration