If -march=mips32r6 or -march=mips64r6 option is given,
we should set SubArch to llvm::Triple::MipsSubArch_r6.
Thus the default triple will become
mipsisa32r6(el)-*
or
mipsisa64r6(el)-*.
Paths
| Differential D158184
Clang/MIPS: computeTargetTriple considering -march option Needs ReviewPublic Authored by wzssyqa on Aug 17 2023, 7:25 AM.
Details
Diff Detail
Unit TestsFailed Event TimelineComment Actions Such driver changes without tests cannot be accepted. It's likely someone wants to clean up the code. Without testing they cannot know whether they would break your cases. Comment Actions OK, Since the CI cannot work with Phabricator shutdown timeline, I will update it and migrate it to GitHub. Comment Actions
The CI is shared. You are not forced to migrate. Actually, I think migrating is semi-discouraged. Comment Actions
More than that, there's the big red banner at the top that explicitly says not to do that, which you kindly added to the site after I suggested it to avoid people doing precisely this kind of migration
Revision Contents
Diff 552331 clang/lib/Driver/Driver.cpp
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips-linux-gnu/12/64/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips-linux-gnu/12/64/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips-linux-gnu/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips-linux-gnu/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips-linux-gnu/12/n32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips-linux-gnu/12/n32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabi64/12/32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabi64/12/32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabi64/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabi64/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabi64/12/n32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabi64/12/n32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabin32/12/32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabin32/12/32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabin32/12/64/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabin32/12/64/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabin32/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64-linux-gnuabin32/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabi64/12/32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabi64/12/32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabi64/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabi64/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabi64/12/n32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabi64/12/n32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabin32/12/32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabin32/12/32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabin32/12/64/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabin32/12/64/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabin32/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mips64el-linux-gnuabin32/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsel-linux-gnu/12/64/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsel-linux-gnu/12/64/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsel-linux-gnu/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsel-linux-gnu/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsel-linux-gnu/12/n32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsel-linux-gnu/12/n32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6-linux-gnu/12/64/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6-linux-gnu/12/64/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6-linux-gnu/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6-linux-gnu/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6-linux-gnu/12/n32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6-linux-gnu/12/n32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6el-linux-gnu/12/64/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6el-linux-gnu/12/64/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6el-linux-gnu/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6el-linux-gnu/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6el-linux-gnu/12/n32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa32r6el-linux-gnu/12/n32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabi64/12/32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabi64/12/32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabi64/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabi64/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabi64/12/n32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabi64/12/n32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabin32/12/32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabin32/12/32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabin32/12/64/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabin32/12/64/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabin32/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6-linux-gnuabin32/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabi64/12/32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabi64/12/32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabi64/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabi64/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabi64/12/n32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabi64/12/n32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabin32/12/32/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabin32/12/32/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabin32/12/64/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabin32/12/64/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabin32/12/crtbegin.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/lib/gcc-cross/mipsisa64r6el-linux-gnuabin32/12/crtend.o
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabi64/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabi64/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabi64/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabi64/lib32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabi64/libo32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabin32/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabin32/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabin32/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabin32/lib64/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64-linux-gnuabin32/libo32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabi64/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabi64/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabi64/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabi64/lib32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabi64/libo32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabin32/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabin32/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabin32/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabin32/lib64/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mips64el-linux-gnuabin32/libo32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsel-linux-gnu/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6-linux-gnu/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6-linux-gnu/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6-linux-gnu/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6-linux-gnu/lib32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6-linux-gnu/lib64/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6el-linux-gnu/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6el-linux-gnu/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6el-linux-gnu/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6el-linux-gnu/lib32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa32r6el-linux-gnu/lib64/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabi64/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabi64/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabi64/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabi64/lib32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabi64/libo32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabin32/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabin32/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabin32/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabin32/lib64/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6-linux-gnuabin32/libo32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabi64/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabi64/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabi64/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabi64/lib32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabi64/libo32/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabin32/bin/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabin32/include/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabin32/lib/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabin32/lib64/.keep
clang/test/Driver/Inputs/debian_multiarch_tree/usr/mipsisa64r6el-linux-gnuabin32/libo32/.keep
clang/test/Driver/linux-cross.cpp
|