This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Drop implicit-def $exec from v_add/sub_u64_pseudos
ClosedPublic

Authored by rampitec on Aug 15 2023, 3:46 PM.

Diff Detail

Event Timeline

rampitec created this revision.Aug 15 2023, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 3:46 PM
rampitec requested review of this revision.Aug 15 2023, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 3:46 PM
Herald added a subscriber: wdng. · View Herald Transcript

Arguably VCC is also not needed. The pseudo itself does not produce carry, and instructions after expansion will have required defs.

arsenm accepted this revision.Aug 15 2023, 3:54 PM

Arguably VCC is also not needed. The pseudo itself does not produce carry, and instructions after expansion will have required defs.

VCC is definitely needed. The intermediate clobber needs to be tracked

This revision is now accepted and ready to land.Aug 15 2023, 3:54 PM
This revision was landed with ongoing or failed builds.Aug 15 2023, 3:59 PM
This revision was automatically updated to reflect the committed changes.