This is an archive of the discontinued LLVM Phabricator instance.

[libc++][chrono] Fixes FreeBSD tests.
ClosedPublic

Authored by Mordante on Aug 12 2023, 6:10 AM.

Details

Reviewers
emaste
dim
philnik
Group Reviewers
Restricted Project
Commits
rG8f01029b17a3: [libc++][chrono] Fixes FreeBSD tests.
Summary

This adjusts the output of the tests to match reality.

Diff Detail

Event Timeline

Mordante created this revision.Aug 12 2023, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 6:10 AM
Mordante requested review of this revision.Aug 12 2023, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 6:10 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
emaste added a reviewer: dim.Aug 12 2023, 7:40 AM
emaste accepted this revision.Aug 12 2023, 7:50 AM

I'm a bit surprised by avr. vs avril - it appears we allow up to 5 chars (janv., févr. etc.) so it would seem avril is preferable to avr.. In any case of course these libc++ tests should match what FreeBSD does.

dim accepted this revision.Aug 12 2023, 8:09 AM

I'm a bit surprised by avr. vs avril - it appears we allow up to 5 chars (janv., févr. etc.) so it would seem avril is preferable to avr.. In any case of course these libc++ tests should match what FreeBSD does.

This comes from https://github.com/freebsd/freebsd-src/blob/main/share/timedef/fr_FR.UTF-8.src#L10, and that in turn comes from https://github.com/unicode-org/cldr/blob/release-43-1/common/main/fr.xml#L2812 where the FreeBSD sources the Unicode stuff from. So it's probably just a quirk. The CLDR project has had "avr." as abbreviation since the original fr.xml was committed in 2003.

I'm a bit surprised by avr. vs avril - it appears we allow up to 5 chars (janv., févr. etc.) so it would seem avril is preferable to avr.. In any case of course these libc++ tests should match what FreeBSD does.

This comes from https://github.com/freebsd/freebsd-src/blob/main/share/timedef/fr_FR.UTF-8.src#L10, and that in turn comes from https://github.com/unicode-org/cldr/blob/release-43-1/common/main/fr.xml#L2812 where the FreeBSD sources the Unicode stuff from. So it's probably just a quirk. The CLDR project has had "avr." as abbreviation since the original fr.xml was committed in 2003.

Thanks for the reviews! I indeed just match the tests with reality ;-)

philnik accepted this revision.Aug 16 2023, 11:03 AM
philnik added a subscriber: philnik.

Given that the FreeBSD folks are happy, I'm happy too.

This revision is now accepted and ready to land.Aug 16 2023, 11:03 AM
This revision was landed with ongoing or failed builds.Aug 17 2023, 9:00 AM
This revision was automatically updated to reflect the committed changes.