[clang-tidy] fix None tmpdir when exporting fixes in run-clang-tidy

[5chmidti]

Summary

Differential https://reviews.llvm.org/D145477 removed the check for (yaml and args.export_fixes) in line 303 to skip looking for the clang-apply-replacements binary. However, the tmpdir variable was set in this true branch when exporting fixes and therefore is None when invoking run-clang-tidy with run-clang-tidy -p . -export-fixes fixes.yaml.

[PiotrZSL]

LGTM

[5chmidti]

Thanks. I don't have commit access, could somebody please commit this for me with Julian Schmidt <[e-mail]>?

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

def main():
 
     clang_tidy_binary = find_binary(args.clang_tidy_binary, "clang-tidy", build_path)
 
     tmpdir = None
     if args.fix:
         clang_apply_replacements_binary = find_binary(
             args.clang_apply_replacements_binary, "clang-apply-replacements", build_path
         )
+
+    if args.fix or (yaml and args.export_fixes):
         tmpdir = tempfile.mkdtemp()
 
     try:
         invocation = get_tidy_invocation(
             "",
             clang_tidy_binary,
             args.checks,
             None,